From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Fri, 22 Jul 2016 18:31:34 -0600 Subject: [U-Boot] Pull request, u-boot-tegra/master In-Reply-To: <20160723002254.GQ14698@bill-the-cat> References: <20160723001013.GV14698@bill-the-cat> <5792B77C.1000408@wwwdotorg.org> <20160723002254.GQ14698@bill-the-cat> Message-ID: <5792BAE6.7090301@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/22/2016 06:22 PM, Tom Rini wrote: > On Fri, Jul 22, 2016 at 06:17:00PM -0600, Stephen Warren wrote: >> On 07/22/2016 06:10 PM, Tom Rini wrote: >>> On Thu, Jul 21, 2016 at 01:17:33PM -0700, Tom Warren wrote: >>> >>>> Tom, >>>> >>>> Please pull u-boot-tegra/master into U-Boot/master. Thanks! >>>> >>>> All Tegra builds are OK, and Stephen's automated test system reports that >>>> all tests pass, except for a sandbox issue (also in mainline) that he's >>>> sent a patch for. >>>> >>>> The following changes since commit ff87b0810753cfaec0e3094aa9fda8b12d6ca569: >>>> >>>> image: fix IH_ARCH_... values for uImage compatibility (2016-07-21 >>>> 10:47:03 -0400) >>>> >>>> are available in the git repository at: >>>> >>>> git://git.denx.de/u-boot-tegra.git master >>>> >>>> for you to fetch changes up to 2a5f7f20747637cd1f94d4accfd7caa99a7c6035: >>>> >>>> ARM: tegra: pick up actual memory size (2016-07-21 09:31:30 -0700) >>>> >>> >>> Applied to u-boot/master, thanks! >>> >>> ... but this commit breaks sandbox_spl, please work out a fix ASAP: >>> commit 0388634a6ce9f0167747a3abac29001e2abc3879 >>> Author: Stephen Warren >>> Date: Mon Jul 18 12:15:03 2016 -0600 >>> >>> ARM: tegra: fix Tegra186 DT GPIO binding header >> >> In what way? That commit only edits a file that sandbox definitely >> should not be including, since it's a Tegra-specific device-tree >> file. > > +(sandbox_spl) drivers/built-in.o: In function `i2c_eeprom_read': > +(sandbox_spl) build/../drivers/misc/i2c_eeprom.c:16: undefined reference to `dm_i2c_read' > +(sandbox_spl) collect2: error: ld returned 1 exit status I believe that's actually caused by the commit below; it fails like that, the previous commit builds, and if I take u-boot/master and revert that one commit the build succeeds. It's also the most recent commit to touch the failing file. > commit d7e28918aa3f4bafc15b16c546826d43fbcbe9f6 > Author: mario.six at gdsys.cc > Date: Wed Jun 22 15:14:16 2016 +0200 > > i2c_eeprom: Add reading support > > This patch implements the reading functionality for the generic I2C > EEPROM driver, which was just a non-functional stub until now. > > Since the page size will be of importance for the writing support, we > add suitable members to the private data structure to keep track of it. > > Compatibility strings for a range of at24c* chips are added. > > Signed-off-by: Mario Six > Reviewed-by: Simon Glass > Reviewed-by: Heiko Schocher