From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Date: Tue, 15 Jan 2019 16:30:29 +0200 Message-ID: <5798967.qfukvHqhlx@avalon> References: <20190115104137.25695-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190115104137.25695-1-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: nouveau@lists.freedesktop.org, DRI Development , virtualization@lists.linux-foundation.org, Benjamin Gaignard , Daniel Vetter , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Intel Graphics Development , etnaviv@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org List-Id: linux-tegra@vger.kernel.org SGkgRGFuaWVsLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAxNSBKYW51 YXJ5IDIwMTkgMTI6NDE6MzcgRUVUIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gSGF2aW5nIHRoZSBw cm9iZSBoZWxwZXIgc3R1ZmYgKHdoaWNoIHByZXR0eSBtdWNoIGV2ZXJ5b25lIG5lZWRzKSBpbgo+ IHRoZSBkcm1fY3J0Y19oZWxwZXIuaCBmaWxlICh3aGljaCBhdG9taWMgZHJpdmVycyBzaG91bGQg bmV2ZXIgbmVlZCkgaXMKPiBjb25mdXNpbmcuIFNwbGl0IHRoZW0gb3V0Lgo+IAo+IFRvIG1ha2Ug c3VyZSBJIGFjdHVhbGx5IGFjaGlldmVkIHRoZSBnb2FsIGhlcmUgSSB3ZW50IHRocm91Z2ggYWxs Cj4gZHJpdmVycy4gQW5kIGluZGVlZCwgYWxsIGF0b21pYyBkcml2ZXJzIGFyZSBub3cgZnJlZSBv Zgo+IGRybV9jcnRjX2hlbHBlci5oIGluY2x1ZGVzLgo+IAo+IHYyOiBNYWtlIGl0IGNvbXBpbGUu IFRoZXJlIHdhcyBzbyBtdWNoIGNvbXBpbGUgZmFpbCBvbiBhcm0gZHJpdmVycwo+IHRoYXQgSSBm aWd1cmVkIEknbGwgYmV0dGVyIG5vdCBpbmNsdWRlIGFueSBvZiB0aGUgYWNrcyBvbiB2MS4KPiAK PiB2MzogTWFzc2l2ZSByZWJhc2UgYmVjYXVzZSBpOTE1IGhhcyBsb3N0IGEgbG90IG9mIGRybVAu aCBpbmNsdWRlcywgYnV0Cj4gbm90IGFsbDogVGhyb3VnaCBkcm1fY3J0Y19oZWxwZXIuaCA+IGRy bV9tb2Rlc2V0X2hlbHBlci5oIC0+IGRybVAuaAo+IHRoZXJlIHdhcyBzdGlsbCBvbmUsIHdoaWNo IHRoaXMgcGF0Y2ggbGFyZ2VseSByZW1vdmVzLiBXaGljaCBtZWFucwo+IHJvbGxpbmcgb3V0IGxv dHMgbW9yZSBpbmNsdWRlcyBhbGwgb3Zlci4KPiAKPiBUaGlzIHdpbGwgYWxzbyBjb25mbGljdCB3 aXRoIG9uZ29pbmcgZHJtUC5oIGNsZWFudXAgYnkgb3RoZXJzIEkKPiBleHBlY3QuCj4gCj4gdjM6 IFJlYmFzZSBvbiB0b3Agb2YgYXRvbWljIGJvY2hzLgo+IAo+IENjOiBTYW0gUmF2bmJvcmcgPHNh bUByYXZuYm9yZy5vcmc+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRl bC5jb20+Cj4gQ2M6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJv YXJkLmNvbT4KPiBBY2tlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t PiAodjIpCj4gQWNrZWQtYnk6IEJlbmphbWluIEdhaWduYXJkIDxiZW5qYW1pbi5nYWlnbmFyZEBs aW5hcm8ub3JnPiAodjIpCj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBpbnRlbC5jb20+Cj4gQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y Zwo+IENjOiB2aXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwo+IENjOiBl dG5hdml2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBsaW51eC1zYW1zdW5nLXNvY0B2Z2Vy Lmtlcm5lbC5vcmcKPiBDYzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBs aW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCj4gQ2M6IGxpbnV4LWFtbG9naWNAbGlz dHMuaW5mcmFkZWFkLm9yZwo+IENjOiBsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZwo+IENj OiBmcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IG5vdXZlYXVAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gQ2M6IHNwaWNlLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENj OiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBsaW51eC1yZW5lc2FzLXNvY0B2 Z2VyLmtlcm5lbC5vcmcKPiBDYzogbGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwo+ IENjOiBsaW51eC1zdG0zMkBzdC1tZC1tYWlsbWFuLnN0b3JtcmVwbHkuY29tCj4gQ2M6IGxpbnV4 LXRlZ3JhQHZnZXIua2VybmVsLm9yZwo+IENjOiB4ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwo+IC0t LQo+IE1lcmdpbmcgdGhpcyBpcyBnb2luZyB0byBiZSBhIGJpdCBhIG1lc3MgZHVlIHRvIGFsbCB0 aGUgb25nb2luZyBkcm1QLmgKPiBjbGVhbnVwcy4gSSB0aGluayB0aGUgZm9sbG93aW5nIHNob3Vs ZCB3b3JrOgo+IC0gQXBwbHkgU2FtJ3MgcHJlcCBwYXRjaGVzIGZvciByZW1vdmluZyBkcm1QLmgg ZnJvbQo+ICAgZHJtX21vZGVzZXRfaGVscGVyLmgKPiAtIEdldCB0aGUgaTkxNSBkcm1QLmggY2xl YW51cCBiYWNrbWVyZ2VkIGludG8gZHJtLW1pc2MtbmV4dAo+IC0gQXBwbHkgdGhpcyBwYXRjaC4K PiAtIEFwcGx5IFNhbSdzIHBhdGNoIHRvIHJlbW92ZSBkcm1QLmggZnJvbSBkcm1fbW9kZXNldF9o ZWxwZXIuaAo+IC0gQWxsIHRocm91Z2ggZHJtLW1pc2MtbmV4dCwgd2hpY2ggaGFzIHNvbWUgcG90 ZW50aWFsIGZvciB0cml2aWFsCj4gICBjb25mbGljdHMgYXJvdW5kICNpbmNsdWRlcyB3aXRoIG90 aGVyIGRyaXZlcnMgdW5mb3J0dW5hdGVseS4KPiAKPiBJIGhvcGUgdGhlcmUncyBubyBvdGhlciBk cml2ZXIgd2hvJ2xsIGJsb3cgdXAgYWNjaWRlbnRhbGx5IGJlY2F1c2UKPiBzb21lb25lIGVsc2Ug aXMgZG9pbmcgYSBkcm1QLmggY2xlYW51cC4gTGF1cmVudCBtYXliZT8KClRoZXJlJ3MgYSBkcm1Q LmggY2xlYW51cCBpbiB0aGUgUi1DYXIgRFUgZHJpdmVyLCBidXQgaXQgZG9lc24ndCBjb25mbGlj dCB3aXRoIAp0aGlzIHBhdGNoLCB0aGUgY29tYmluYXRpb24gb2YgYm90aCBjb21waWxlcyBmaW5l LgoKPiBKYW5pLCBhY2sgb24gdGhpcz8KPiAtRGFuaWVsCj4gLS0tCgpbc25pcF0KCj4gIGRyaXZl cnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExLmggICAgICB8ICA1ICstCj4gIGRyaXZl cnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgtYW54Nzh4eC5jICAgICB8ICAyICstCj4gIGRyaXZl cnMvZ3B1L2RybS9icmlkZ2UvZHVtYi12Z2EtZGFjLmMgICAgICAgICB8ICAyICstCj4gIGRyaXZl cnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctaGRtaS5jICAgICB8ICAyICstCj4gIGRyaXZl cnMvZ3B1L2RybS9icmlkZ2UvdGktdGZwNDEwLmMgICAgICAgICAgICB8ICAyICstCj4gIGRyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jICAgICAgICAgICB8ICAxIC0KPiAgZHJpdmVy cy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYyAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL2RybV9tb2Rlc2V0X2hlbHBlci5jICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyAgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL29tYXBkcm0vb21hcF9jb25uZWN0b3IuYyAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL29tYXBkcm0vb21hcF9jcnRjLmMgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuYyAgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL29tYXBkcm0vb21hcF9kcnYuaCAgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL29tYXBkcm0vb21hcF9lbmNvZGVyLmMgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL29tYXBkcm0vb21hcF9mYi5jICAgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9lbmNvZGVyLmMgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9rbXMuYyAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9wbGFuZS5jICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV92c3AuYyAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9sdmRzLmMgICAgICAgICAgIHwgIDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL3NobW9iaWxlL3NobW9iX2RybV9jcnRjLmMgICAgIHwgIDEgKwo+ICBkcml2ZXJz L2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2Rydi5jICAgICAgfCAgMSArCj4gIGRyaXZlcnMv Z3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fa21zLmMgICAgICB8ICAxICsKPiAgaW5jbHVkZS9k cm0vZHJtX2NydGNfaGVscGVyLmggICAgICAgICAgICAgICAgIHwgMTYgLS0tLS0tCj4gIGluY2x1 ZGUvZHJtL2RybV9wcm9iZV9oZWxwZXIuaCAgICAgICAgICAgICAgICB8IDUwICsrKysrKysrKysr KysrKysrKysKCkZvciB0aGUgYWJvdmUgZmlsZXMsIHdpdGggdGhlIGNvbW1lbnRzIGJlbG93IGFk ZHJlc3NlZCwKClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0 QGlkZWFzb25ib2FyZC5jb20+Cgo+ICAyMjcgZmlsZXMgY2hhbmdlZCwgMjg5IGluc2VydGlvbnMo KyksIDIwMCBkZWxldGlvbnMoLSkKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvZHJtL2Ry bV9wcm9iZV9oZWxwZXIuaAoKW3NuaXBdCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v YnJpZGdlL2Fkdjc1MTEvYWR2NzUxMS5oCj4gYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1 MTEvYWR2NzUxMS5oIGluZGV4IDczZDhjY2I5Nzc0Mi4uZDUyZmZhYjQxZWI0Cj4gMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTEuaAo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExLmgKPiBAQCAtMTQsOCArMTQsMTEg QEAKPiAgI2luY2x1ZGUgPGxpbnV4L3JlZ21hcC5oPgo+ICAjaW5jbHVkZSA8bGludXgvcmVndWxh dG9yL2NvbnN1bWVyLmg+Cj4gCj4gLSNpbmNsdWRlIDxkcm0vZHJtX2NydGNfaGVscGVyLmg+Cj4g KyNpbmNsdWRlIDxkcm0vZHJtX3Byb2JlX2hlbHBlci5oPgoKVGhlIHByb2JlIGhlbHBlcnMgYXJl IG5lZWRlZCBpbiBhZHY3NTExX2Rydi5jIG9ubHksIEkgd291bGQgbW92ZSB0aGUgaW5jbHVkZSAK dGhlcmUuCgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9taXBpX2RzaS5oPgo+ICsjaW5jbHVkZSA8ZHJt L2RybV9jb25uZWN0b3IuaD4KPiArI2luY2x1ZGUgPGRybS9kcm1fbW9kZXMuaD4KPiArI2luY2x1 ZGUgPGRybS9kcm1fYnJpZGdlLmg+CgpQbGVhc2Uga2VlcCB0aGUgaGVhZGVycyBhbHBoYWJldGlj YWxseSBzb3J0ZWQsIGhlcmUgYW5kIGluIGFsbCBvdGhlciBkcml2ZXJzLgoKPiAgI2RlZmluZSBB RFY3NTExX1JFR19DSElQX1JFVklTSU9OCQkweDAwCj4gICNkZWZpbmUgQURWNzUxMV9SRUdfTjAJ CQkJMHgwMQoKW3NuaXBdCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9v bWFwX2NydGMuYwo+IGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9jcnRjLmMgaW5kZXgg NDBhY2Y0Y2U3YzlmLi45YmViMGVkZDVmZmEKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vb21hcGRybS9vbWFwX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29t YXBfY3J0Yy5jCj4gQEAgLTE4LDcgKzE4LDcgQEAKPiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWlj Lmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIuaD4KPiAgI2luY2x1ZGUgPGRy bS9kcm1fY3J0Yy5oPgo+IC0jaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+ICsjaW5j bHVkZSA8ZHJtL2RybV9wcm9iZV9oZWxwZXIuaD4KClRoaXMgZmlsZSBkb2Vzbid0IHVzZSB0aGUg cHJvYmUgaGVscGVycywgeW91IGNhbiBkcm9wIHRoaXMuCgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9t b2RlLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX3BsYW5lX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8 bGludXgvbWF0aDY0Lmg+Cgpbc25pcF0KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9v bWFwZHJtL29tYXBfZHJ2LmgKPiBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZHJ2Lmgg aW5kZXggYmQ3ZjJjMjI3YTI1Li41MTNhZThhYjVlNjQKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL29tYXBk cm0vb21hcF9kcnYuaAo+IEBAIC0yMyw3ICsyMyw3IEBACj4gICNpbmNsdWRlIDxsaW51eC93b3Jr cXVldWUuaD4KPiAKPiAgI2luY2x1ZGUgPGRybS9kcm1QLmg+Cj4gLSNpbmNsdWRlIDxkcm0vZHJt X2NydGNfaGVscGVyLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX3Byb2JlX2hlbHBlci5oPgoKVGhp cyBpc24ndCBuZWVkZWQgZ2xvYmFsbHkgaW4gdGhlIGRyaXZlciBlaXRoZXIuCgo+ICAjaW5jbHVk ZSA8ZHJtL2RybV9nZW0uaD4KPiAgI2luY2x1ZGUgPGRybS9vbWFwX2RybS5oPgo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2VuY29kZXIuYwo+IGIvZHJpdmVy cy9ncHUvZHJtL29tYXBkcm0vb21hcF9lbmNvZGVyLmMgaW5kZXggMTQ4YjZiMjAyNzRmLi5jZDIz MjhmYTRiYTYKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Vu Y29kZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZW5jb2Rlci5jCj4g QEAgLTE4LDcgKzE4LDcgQEAKPiAgI2luY2x1ZGUgPGxpbnV4L2xpc3QuaD4KPiAKPiAgI2luY2x1 ZGUgPGRybS9kcm1fY3J0Yy5oPgo+IC0jaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+ ICsjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+CgpBcyBmYXIgYXMgSSBjYW4gdGVs bCB0aGlzIGlzIG9ubHkgdXNlZCB0byBpbmNsdWRlIApkcm1fbW9kZXNldF9oZWxwZXJfdnRhYmxl cy5oLiBTaG91bGQgd2UgaW5jbHVkZSB0aGF0IGZpbGUgaW5zdGVhZCA/Cgo+ICAjaW5jbHVkZSA8 ZHJtL2RybV9lZGlkLmg+Cj4gCj4gICNpbmNsdWRlICJvbWFwX2Rydi5oIgoKW3NuaXBdCgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYwo+IGIvZHJp dmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMgaW5kZXggOTBkYWNhYjY3YmU1Li5i MTVkMmIzYTA3ZjEKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2Fy X2R1X2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5j Cj4gQEAgLTE1LDcgKzE1LDcgQEAKPiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljLmg+Cj4gICNp bmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fY3J0 Yy5oPgo+IC0jaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+ICsjaW5jbHVkZSA8ZHJt L2RybV9wcm9iZV9oZWxwZXIuaD4KCk5vdCBuZWVkZWQgZWl0aGVyLgoKPiAgI2luY2x1ZGUgPGRy bS9kcm1fZmJfY21hX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW1fY21hX2hlbHBl ci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9wbGFuZV9oZWxwZXIuaD4KCltzbmlwXQoKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9lbmNvZGVyLmMKPiBiL2Ry aXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZW5jb2Rlci5jIGluZGV4Cj4gMTg3Nzc2NGJk NmQ5Li4wYjQ0MGY1NTRhZWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUv cmNhcl9kdV9lbmNvZGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X2VuY29kZXIuYwo+IEBAIC0xMSw3ICsxMSw3IEBACj4gCj4gICNpbmNsdWRlIDxkcm0vZHJtUC5o Pgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjLmg+Cj4gLSNpbmNsdWRlIDxkcm0vZHJtX2NydGNf aGVscGVyLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIuaD4KCkFzIGZhciBh cyBJIGNhbiB0ZWxsIHRoaXMgaXMgb25seSB1c2VkIHRvIGluY2x1ZGUgCmRybV9tb2Rlc2V0X2hl bHBlcl92dGFibGVzLmguIFNob3VsZCB3ZSBpbmNsdWRlIHRoYXQgZmlsZSBpbnN0ZWFkID8KCj4g ICNpbmNsdWRlIDxkcm0vZHJtX3BhbmVsLmg+Cj4gCj4gICNpbmNsdWRlICJyY2FyX2R1X2Rydi5o IgoKW3NuaXBdCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X3BsYW5lLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfcGxhbmUuYyBpbmRl eCAzOWQ1YWUzZmRmNzIuLmI3ZmEyNzhjYTc0NQo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9yY2FyLWR1L3JjYXJfZHVfcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2Fy LWR1L3JjYXJfZHVfcGxhbmUuYwo+IEBAIC0xMSw3ICsxMSw3IEBACj4gICNpbmNsdWRlIDxkcm0v ZHJtX2F0b21pYy5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+Cj4gICNp bmNsdWRlIDxkcm0vZHJtX2NydGMuaD4KPiAtI2luY2x1ZGUgPGRybS9kcm1fY3J0Y19oZWxwZXIu aD4KPiArI2luY2x1ZGUgPGRybS9kcm1fcHJvYmVfaGVscGVyLmg+CgpOb3QgbmVlZGVkLgoKPiAg I2luY2x1ZGUgPGRybS9kcm1fZmJfY21hX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9n ZW1fY21hX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9wbGFuZV9oZWxwZXIuaD4KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV92c3AuYwo+IGIvZHJp dmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV92c3AuYyBpbmRleCA0NTc2MTE5ZTc3NzcuLjM1 YjJhNGQzYWU3NAo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJf ZHVfdnNwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X3ZzcC5jCj4g QEAgLTEwLDcgKzEwLDcgQEAKPiAgI2luY2x1ZGUgPGRybS9kcm1QLmg+Cj4gICNpbmNsdWRlIDxk cm0vZHJtX2F0b21pY19oZWxwZXIuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fY3J0Yy5oPgo+IC0j aW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+ICsjaW5jbHVkZSA8ZHJtL2RybV9wcm9i ZV9oZWxwZXIuaD4KCk5vdCBuZWVkZWQuCgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9mYl9jbWFfaGVs cGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2dlbV9jbWFfaGVscGVyLmg+Cj4gICNpbmNsdWRl IDxkcm0vZHJtX2dlbV9mcmFtZWJ1ZmZlcl9oZWxwZXIuaD4KCltzbmlwXQoKPiBkaWZmIC0tZ2l0 IGEvaW5jbHVkZS9kcm0vZHJtX3Byb2JlX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX3Byb2Jl X2hlbHBlci5oCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLjk2 YzA2MGMxNmExZQo+IC0tLSAvZGV2L251bGwKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fcHJvYmVf aGVscGVyLmgKPiBAQCAtMCwwICsxLDUwIEBACj4gKy8qCj4gKyAqIENvcHlyaWdodCDCqSAyMDA2 IEtlaXRoIFBhY2thcmQKPiArICogQ29weXJpZ2h0IMKpIDIwMDctMjAwOCBEYXZlIEFpcmxpZQo+ ICsgKiBDb3B5cmlnaHQgwqkgMjAwNy0yMDA4IEludGVsIENvcnBvcmF0aW9uCj4gKyAqICAgSmVz c2UgQmFybmVzIDxqZXNzZS5iYXJuZXNAaW50ZWwuY29tPgo+ICsgKgo+ICsgKiBQZXJtaXNzaW9u IGlzIGhlcmVieSBncmFudGVkLCBmcmVlIG9mIGNoYXJnZSwgdG8gYW55IHBlcnNvbiBvYnRhaW5p bmcgYQo+ICsgKiBjb3B5IG9mIHRoaXMgc29mdHdhcmUgYW5kIGFzc29jaWF0ZWQgZG9jdW1lbnRh dGlvbiBmaWxlcyAodGhlCj4gIlNvZnR3YXJlIiksICsgKiB0byBkZWFsIGluIHRoZSBTb2Z0d2Fy ZSB3aXRob3V0IHJlc3RyaWN0aW9uLCBpbmNsdWRpbmcKPiB3aXRob3V0IGxpbWl0YXRpb24gKyAq IHRoZSByaWdodHMgdG8gdXNlLCBjb3B5LCBtb2RpZnksIG1lcmdlLCBwdWJsaXNoLAo+IGRpc3Ry aWJ1dGUsIHN1YmxpY2Vuc2UsICsgKiBhbmQvb3Igc2VsbCBjb3BpZXMgb2YgdGhlIFNvZnR3YXJl LCBhbmQgdG8KPiBwZXJtaXQgcGVyc29ucyB0byB3aG9tIHRoZSArICogU29mdHdhcmUgaXMgZnVy bmlzaGVkIHRvIGRvIHNvLCBzdWJqZWN0IHRvCj4gdGhlIGZvbGxvd2luZyBjb25kaXRpb25zOiAr ICoKPiArICogVGhlIGFib3ZlIGNvcHlyaWdodCBub3RpY2UgYW5kIHRoaXMgcGVybWlzc2lvbiBu b3RpY2Ugc2hhbGwgYmUgaW5jbHVkZWQKPiBpbiArICogYWxsIGNvcGllcyBvciBzdWJzdGFudGlh bCBwb3J0aW9ucyBvZiB0aGUgU29mdHdhcmUuCj4gKyAqCj4gKyAqIFRIRSBTT0ZUV0FSRSBJUyBQ Uk9WSURFRCAiQVMgSVMiLCBXSVRIT1VUIFdBUlJBTlRZIE9GIEFOWSBLSU5ELCBFWFBSRVNTCj4g T1IgKyAqIElNUExJRUQsIElOQ0xVRElORyBCVVQgTk9UIExJTUlURUQgVE8gVEhFIFdBUlJBTlRJ RVMgT0YKPiBNRVJDSEFOVEFCSUxJVFksICsgKiBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVS UE9TRSBBTkQgTk9OSU5GUklOR0VNRU5ULiAKPiBJTiBOTyBFVkVOVCBTSEFMTCArICogVEhFIENP UFlSSUdIVCBIT0xERVIoUykgT1IgQVVUSE9SKFMpIEJFIExJQUJMRSBGT1IKPiBBTlkgQ0xBSU0s IERBTUFHRVMgT1IgKyAqIE9USEVSIExJQUJJTElUWSwgV0hFVEhFUiBJTiBBTiBBQ1RJT04gT0YK PiBDT05UUkFDVCwgVE9SVCBPUiBPVEhFUldJU0UsICsgKiBBUklTSU5HIEZST00sIE9VVCBPRiBP UiBJTiBDT05ORUNUSU9OIFdJVEgKPiBUSEUgU09GVFdBUkUgT1IgVEhFIFVTRSBPUiArICogT1RI RVIgREVBTElOR1MgSU4gVEhFIFNPRlRXQVJFLgoKTGV0J3MgdXNlIGFuIFNQRFggdGFnIGluc3Rl YWQuCgo+ICsgKi8KPiArCj4gKyNpZm5kZWYgX19EUk1fUFJPQkVfSEVMUEVSX0hfXwo+ICsjZGVm aW5lIF9fRFJNX1BST0JFX0hFTFBFUl9IX18KPiArCj4gKyNpbmNsdWRlIDxsaW51eC90eXBlcy5o Pgo+ICsKPiArc3RydWN0IGRybV9jb25uZWN0b3I7Cj4gK3N0cnVjdCBkcm1fZGV2aWNlOwo+ICtz dHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHg7Cj4gKwo+ICtpbnQgZHJtX2hlbHBlcl9wcm9i ZV9zaW5nbGVfY29ubmVjdG9yX21vZGVzKHN0cnVjdCBkcm1fY29ubmVjdG9yCj4gKwkJCQkJICAg ICpjb25uZWN0b3IsIHVpbnQzMl90IG1heFgsCj4gKwkJCQkJICAgIHVpbnQzMl90IG1heFkpOwo+ ICtpbnQgZHJtX2hlbHBlcl9wcm9iZV9kZXRlY3Qoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5l Y3RvciwKPiArCQkJICAgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4LAo+ICsJ CQkgICAgYm9vbCBmb3JjZSk7Cj4gK3ZvaWQgZHJtX2ttc19oZWxwZXJfcG9sbF9pbml0KHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpOwo+ICt2b2lkIGRybV9rbXNfaGVscGVyX3BvbGxfZmluaShzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KTsKPiArYm9vbCBkcm1faGVscGVyX2hwZF9pcnFfZXZlbnQoc3Ry dWN0IGRybV9kZXZpY2UgKmRldik7Cj4gK3ZvaWQgZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVu dChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiArCj4gK3ZvaWQgZHJtX2ttc19oZWxwZXJfcG9s bF9kaXNhYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICt2b2lkIGRybV9rbXNfaGVscGVy X3BvbGxfZW5hYmxlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICtib29sIGRybV9rbXNfaGVs cGVyX2lzX3BvbGxfd29ya2VyKHZvaWQpOwo+ICsKPiArI2VuZGlmCgotLSAKUmVnYXJkcywKCkxh dXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA60C43387 for ; Tue, 15 Jan 2019 14:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9241F20873 for ; Tue, 15 Jan 2019 14:29:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JmClL8V1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729127AbfAOO3U (ORCPT ); Tue, 15 Jan 2019 09:29:20 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:42106 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726863AbfAOO3U (ORCPT ); Tue, 15 Jan 2019 09:29:20 -0500 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 104374F8; Tue, 15 Jan 2019 15:29:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1547562554; bh=6Lt8GE7mqRAOiWSVFaVewmz6sdGOGz5y3RFGYDTXlrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JmClL8V1yzOm1NiPOiRt3AbPAmmwS/zsVSQUlk77juViLMw3UAtIXX7MXO00MAwm8 vLeQVyWLKOo8hlJkFmP+xwzjmOk8y1TswwpAQ0SKPj2x5w7T+klz75gA62UJ+RSUmv LidnlD3AcVFwKpjHIs/6TJc/qh3P3wqlowbun6aQ= From: Laurent Pinchart To: Daniel Vetter Cc: Intel Graphics Development , DRI Development , Sam Ravnborg , Jani Nikula , Rodrigo Vivi , Benjamin Gaignard , Daniel Vetter , linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, spice-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, xen-devel@lists.xen.org Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Date: Tue, 15 Jan 2019 16:30:29 +0200 Message-ID: <5798967.qfukvHqhlx@avalon> Organization: Ideas on Board Oy In-Reply-To: <20190115104137.25695-1-daniel.vetter@ffwll.ch> References: <20190115104137.25695-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Daniel, Thank you for the patch. On Tuesday, 15 January 2019 12:41:37 EET Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. >=20 > To make sure I actually achieved the goal here I went through all > drivers. And indeed, all atomic drivers are now free of > drm_crtc_helper.h includes. >=20 > v2: Make it compile. There was so much compile fail on arm drivers > that I figured I'll better not include any of the acks on v1. >=20 > v3: Massive rebase because i915 has lost a lot of drmP.h includes, but > not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h > there was still one, which this patch largely removes. Which means > rolling out lots more includes all over. >=20 > This will also conflict with ongoing drmP.h cleanup by others I > expect. >=20 > v3: Rebase on top of atomic bochs. >=20 > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Laurent Pinchart > Acked-by: Rodrigo Vivi (v2) > Acked-by: Benjamin Gaignard (v2) > Signed-off-by: Daniel Vetter > Cc: linux-arm-kernel@lists.infradead.org > Cc: virtualization@lists.linux-foundation.org > Cc: etnaviv@lists.freedesktop.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: intel-gfx@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: spice-devel@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-tegra@vger.kernel.org > Cc: xen-devel@lists.xen.org > --- > Merging this is going to be a bit a mess due to all the ongoing drmP.h > cleanups. I think the following should work: > - Apply Sam's prep patches for removing drmP.h from > drm_modeset_helper.h > - Get the i915 drmP.h cleanup backmerged into drm-misc-next > - Apply this patch. > - Apply Sam's patch to remove drmP.h from drm_modeset_helper.h > - All through drm-misc-next, which has some potential for trivial > conflicts around #includes with other drivers unfortunately. >=20 > I hope there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? There's a drmP.h cleanup in the R-Car DU driver, but it doesn't conflict wi= th=20 this patch, the combination of both compiles fine. > Jani, ack on this? > -Daniel > --- [snip] > drivers/gpu/drm/bridge/adv7511/adv7511.h | 5 +- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 2 +- > drivers/gpu/drm/bridge/dumb-vga-dac.c | 2 +- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- > drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- > drivers/gpu/drm/drm_atomic_helper.c | 1 - > drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- > drivers/gpu/drm/drm_modeset_helper.c | 2 +- > drivers/gpu/drm/drm_probe_helper.c | 2 +- > drivers/gpu/drm/drm_simple_kms_helper.c | 2 +- > drivers/gpu/drm/omapdrm/omap_connector.c | 2 +- > drivers/gpu/drm/omapdrm/omap_crtc.c | 2 +- > drivers/gpu/drm/omapdrm/omap_drv.c | 2 +- > drivers/gpu/drm/omapdrm/omap_drv.h | 2 +- > drivers/gpu/drm/omapdrm/omap_encoder.c | 2 +- > drivers/gpu/drm/omapdrm/omap_fb.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +- > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 1 + > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 + > drivers/gpu/drm/shmobile/shmob_drm_kms.c | 1 + > include/drm/drm_crtc_helper.h | 16 ------ > include/drm/drm_probe_helper.h | 50 +++++++++++++++++++ =46or the above files, with the comments below addressed, Reviewed-by: Laurent Pinchart > 227 files changed, 289 insertions(+), 200 deletions(-) > create mode 100644 include/drm/drm_probe_helper.h [snip] > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h > b/drivers/gpu/drm/bridge/adv7511/adv7511.h index 73d8ccb97742..d52ffab41e= b4 > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h > @@ -14,8 +14,11 @@ > #include > #include >=20 > -#include > +#include The probe helpers are needed in adv7511_drv.c only, I would move the includ= e=20 there. > #include > +#include > +#include > +#include Please keep the headers alphabetically sorted, here and in all other driver= s. > #define ADV7511_REG_CHIP_REVISION 0x00 > #define ADV7511_REG_N0 0x01 [snip] > diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c > b/drivers/gpu/drm/omapdrm/omap_crtc.c index 40acf4ce7c9f..9beb0edd5ffa > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_crtc.c > +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c > @@ -18,7 +18,7 @@ > #include > #include > #include > -#include > +#include This file doesn't use the probe helpers, you can drop this. > #include > #include > #include [snip] > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h > b/drivers/gpu/drm/omapdrm/omap_drv.h index bd7f2c227a25..513ae8ab5e64 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.h > +++ b/drivers/gpu/drm/omapdrm/omap_drv.h > @@ -23,7 +23,7 @@ > #include >=20 > #include > -#include > +#include This isn't needed globally in the driver either. > #include > #include >=20 > diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c > b/drivers/gpu/drm/omapdrm/omap_encoder.c index 148b6b20274f..cd2328fa4ba6 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_encoder.c > +++ b/drivers/gpu/drm/omapdrm/omap_encoder.c > @@ -18,7 +18,7 @@ > #include >=20 > #include > -#include > +#include As far as I can tell this is only used to include=20 drm_modeset_helper_vtables.h. Should we include that file instead ? > #include >=20 > #include "omap_drv.h" [snip] > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 90dacab67be5..b15d2b3a07f1 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include Not needed either. > #include > #include > #include [snip] > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c index > 1877764bd6d9..0b440f554aed 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > @@ -11,7 +11,7 @@ >=20 > #include > #include > -#include > +#include As far as I can tell this is only used to include=20 drm_modeset_helper_vtables.h. Should we include that file instead ? > #include >=20 > #include "rcar_du_drv.h" [snip] > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c index 39d5ae3fdf72..b7fa278ca745 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -11,7 +11,7 @@ > #include > #include > #include > -#include > +#include Not needed. > #include > #include > #include > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 4576119e7777..35b2a4d3ae74 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > @@ -10,7 +10,7 @@ > #include > #include > #include > -#include > +#include Not needed. > #include > #include > #include [snip] > diff --git a/include/drm/drm_probe_helper.h b/include/drm/drm_probe_helpe= r.h > new file mode 100644 > index 000000000000..96c060c16a1e > --- /dev/null > +++ b/include/drm/drm_probe_helper.h > @@ -0,0 +1,50 @@ > +/* > + * Copyright =A9 2006 Keith Packard > + * Copyright =A9 2007-2008 Dave Airlie > + * Copyright =A9 2007-2008 Intel Corporation > + * Jesse Barnes > + * > + * Permission is hereby granted, free of charge, to any person obtaining= a > + * copy of this software and associated documentation files (the > "Software"), + * to deal in the Software without restriction, including > without limitation + * the rights to use, copy, modify, merge, publish, > distribute, sublicense, + * and/or sell copies of the Software, and to > permit persons to whom the + * Software is furnished to do so, subject to > the following conditions: + * > + * The above copyright notice and this permission notice shall be includ= ed > in + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS > OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT= =2E=20 > IN NO EVENT SHALL + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR > ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF > CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WI= TH > THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. Let's use an SPDX tag instead. > + */ > + > +#ifndef __DRM_PROBE_HELPER_H__ > +#define __DRM_PROBE_HELPER_H__ > + > +#include > + > +struct drm_connector; > +struct drm_device; > +struct drm_modeset_acquire_ctx; > + > +int drm_helper_probe_single_connector_modes(struct drm_connector > + *connector, uint32_t maxX, > + uint32_t maxY); > +int drm_helper_probe_detect(struct drm_connector *connector, > + struct drm_modeset_acquire_ctx *ctx, > + bool force); > +void drm_kms_helper_poll_init(struct drm_device *dev); > +void drm_kms_helper_poll_fini(struct drm_device *dev); > +bool drm_helper_hpd_irq_event(struct drm_device *dev); > +void drm_kms_helper_hotplug_event(struct drm_device *dev); > + > +void drm_kms_helper_poll_disable(struct drm_device *dev); > +void drm_kms_helper_poll_enable(struct drm_device *dev); > +bool drm_kms_helper_is_poll_worker(void); > + > +#endif =2D-=20 Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB09FC43444 for ; Tue, 15 Jan 2019 14:29:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82C852063F for ; Tue, 15 Jan 2019 14:29:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t3ZQSvtN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JmClL8V1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82C852063F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AAYk+64qiJ7+qiV8qX0LWS7P+XH3BBeUjl7fa9g9kmA=; b=t3ZQSvtNqJ5olm Tu0xHK6C2Jnbz6NRn4RS//eO7/KIENJNjTrVoDr6rUvmctctdCzkU2qQggMQ70q4ls8GWcIJ2vtI/ J5OOOt4wST803hianJ91jqx6oQDQNFkNyhwxorfH3in81+8VUprz5wqc22BCuVxOj8n1soVMdNVvf YrTLrsCjOA8ukBK5UH8upRDTMbXP2+aJVQq/8IXSEhAIxHLABQaYb68JKhJ3zX6DFvLCrDWLYKnxm FoJy2cqPdS/iiaLLn/BQPEE01B2DN5afcr1cnmQ8FyJVnF68tmr7AA8INe4FUdi0VRzlYSaF1Pjct tqSzIjeeSi4+TPdCgYLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjPih-0007Aq-2Y; Tue, 15 Jan 2019 14:29:35 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjPib-00079J-PV; Tue, 15 Jan 2019 14:29:32 +0000 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 104374F8; Tue, 15 Jan 2019 15:29:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1547562554; bh=6Lt8GE7mqRAOiWSVFaVewmz6sdGOGz5y3RFGYDTXlrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JmClL8V1yzOm1NiPOiRt3AbPAmmwS/zsVSQUlk77juViLMw3UAtIXX7MXO00MAwm8 vLeQVyWLKOo8hlJkFmP+xwzjmOk8y1TswwpAQ0SKPj2x5w7T+klz75gA62UJ+RSUmv LidnlD3AcVFwKpjHIs/6TJc/qh3P3wqlowbun6aQ= From: Laurent Pinchart To: Daniel Vetter Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Date: Tue, 15 Jan 2019 16:30:29 +0200 Message-ID: <5798967.qfukvHqhlx@avalon> Organization: Ideas on Board Oy In-Reply-To: <20190115104137.25695-1-daniel.vetter@ffwll.ch> References: <20190115104137.25695-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190115_062930_281835_53378566 X-CRM114-Status: GOOD ( 28.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, DRI Development , virtualization@lists.linux-foundation.org, Benjamin Gaignard , Daniel Vetter , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Intel Graphics Development , etnaviv@lists.freedesktop.org, Jani Nikula , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, Thank you for the patch. On Tuesday, 15 January 2019 12:41:37 EET Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > = > To make sure I actually achieved the goal here I went through all > drivers. And indeed, all atomic drivers are now free of > drm_crtc_helper.h includes. > = > v2: Make it compile. There was so much compile fail on arm drivers > that I figured I'll better not include any of the acks on v1. > = > v3: Massive rebase because i915 has lost a lot of drmP.h includes, but > not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h > there was still one, which this patch largely removes. Which means > rolling out lots more includes all over. > = > This will also conflict with ongoing drmP.h cleanup by others I > expect. > = > v3: Rebase on top of atomic bochs. > = > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Laurent Pinchart > Acked-by: Rodrigo Vivi (v2) > Acked-by: Benjamin Gaignard (v2) > Signed-off-by: Daniel Vetter > Cc: linux-arm-kernel@lists.infradead.org > Cc: virtualization@lists.linux-foundation.org > Cc: etnaviv@lists.freedesktop.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: intel-gfx@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: spice-devel@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-tegra@vger.kernel.org > Cc: xen-devel@lists.xen.org > --- > Merging this is going to be a bit a mess due to all the ongoing drmP.h > cleanups. I think the following should work: > - Apply Sam's prep patches for removing drmP.h from > drm_modeset_helper.h > - Get the i915 drmP.h cleanup backmerged into drm-misc-next > - Apply this patch. > - Apply Sam's patch to remove drmP.h from drm_modeset_helper.h > - All through drm-misc-next, which has some potential for trivial > conflicts around #includes with other drivers unfortunately. > = > I hope there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? There's a drmP.h cleanup in the R-Car DU driver, but it doesn't conflict wi= th = this patch, the combination of both compiles fine. > Jani, ack on this? > -Daniel > --- [snip] > drivers/gpu/drm/bridge/adv7511/adv7511.h | 5 +- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 2 +- > drivers/gpu/drm/bridge/dumb-vga-dac.c | 2 +- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- > drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- > drivers/gpu/drm/drm_atomic_helper.c | 1 - > drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- > drivers/gpu/drm/drm_modeset_helper.c | 2 +- > drivers/gpu/drm/drm_probe_helper.c | 2 +- > drivers/gpu/drm/drm_simple_kms_helper.c | 2 +- > drivers/gpu/drm/omapdrm/omap_connector.c | 2 +- > drivers/gpu/drm/omapdrm/omap_crtc.c | 2 +- > drivers/gpu/drm/omapdrm/omap_drv.c | 2 +- > drivers/gpu/drm/omapdrm/omap_drv.h | 2 +- > drivers/gpu/drm/omapdrm/omap_encoder.c | 2 +- > drivers/gpu/drm/omapdrm/omap_fb.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +- > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 1 + > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 + > drivers/gpu/drm/shmobile/shmob_drm_kms.c | 1 + > include/drm/drm_crtc_helper.h | 16 ------ > include/drm/drm_probe_helper.h | 50 +++++++++++++++++++ For the above files, with the comments below addressed, Reviewed-by: Laurent Pinchart > 227 files changed, 289 insertions(+), 200 deletions(-) > create mode 100644 include/drm/drm_probe_helper.h [snip] > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h > b/drivers/gpu/drm/bridge/adv7511/adv7511.h index 73d8ccb97742..d52ffab41e= b4 > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h > @@ -14,8 +14,11 @@ > #include > #include > = > -#include > +#include The probe helpers are needed in adv7511_drv.c only, I would move the includ= e = there. > #include > +#include > +#include > +#include Please keep the headers alphabetically sorted, here and in all other driver= s. > #define ADV7511_REG_CHIP_REVISION 0x00 > #define ADV7511_REG_N0 0x01 [snip] > diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c > b/drivers/gpu/drm/omapdrm/omap_crtc.c index 40acf4ce7c9f..9beb0edd5ffa > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_crtc.c > +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c > @@ -18,7 +18,7 @@ > #include > #include > #include > -#include > +#include This file doesn't use the probe helpers, you can drop this. > #include > #include > #include [snip] > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h > b/drivers/gpu/drm/omapdrm/omap_drv.h index bd7f2c227a25..513ae8ab5e64 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.h > +++ b/drivers/gpu/drm/omapdrm/omap_drv.h > @@ -23,7 +23,7 @@ > #include > = > #include > -#include > +#include This isn't needed globally in the driver either. > #include > #include > = > diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c > b/drivers/gpu/drm/omapdrm/omap_encoder.c index 148b6b20274f..cd2328fa4ba6 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_encoder.c > +++ b/drivers/gpu/drm/omapdrm/omap_encoder.c > @@ -18,7 +18,7 @@ > #include > = > #include > -#include > +#include As far as I can tell this is only used to include = drm_modeset_helper_vtables.h. Should we include that file instead ? > #include > = > #include "omap_drv.h" [snip] > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 90dacab67be5..b15d2b3a07f1 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include Not needed either. > #include > #include > #include [snip] > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c index > 1877764bd6d9..0b440f554aed 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > @@ -11,7 +11,7 @@ > = > #include > #include > -#include > +#include As far as I can tell this is only used to include = drm_modeset_helper_vtables.h. Should we include that file instead ? > #include > = > #include "rcar_du_drv.h" [snip] > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c index 39d5ae3fdf72..b7fa278ca745 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -11,7 +11,7 @@ > #include > #include > #include > -#include > +#include Not needed. > #include > #include > #include > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 4576119e7777..35b2a4d3ae74 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > @@ -10,7 +10,7 @@ > #include > #include > #include > -#include > +#include Not needed. > #include > #include > #include [snip] > diff --git a/include/drm/drm_probe_helper.h b/include/drm/drm_probe_helpe= r.h > new file mode 100644 > index 000000000000..96c060c16a1e > --- /dev/null > +++ b/include/drm/drm_probe_helper.h > @@ -0,0 +1,50 @@ > +/* > + * Copyright =A9 2006 Keith Packard > + * Copyright =A9 2007-2008 Dave Airlie > + * Copyright =A9 2007-2008 Intel Corporation > + * Jesse Barnes > + * > + * Permission is hereby granted, free of charge, to any person obtaining= a > + * copy of this software and associated documentation files (the > "Software"), + * to deal in the Software without restriction, including > without limitation + * the rights to use, copy, modify, merge, publish, > distribute, sublicense, + * and/or sell copies of the Software, and to > permit persons to whom the + * Software is furnished to do so, subject to > the following conditions: + * > + * The above copyright notice and this permission notice shall be includ= ed > in + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS > OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT= . = > IN NO EVENT SHALL + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR > ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF > CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WI= TH > THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. Let's use an SPDX tag instead. > + */ > + > +#ifndef __DRM_PROBE_HELPER_H__ > +#define __DRM_PROBE_HELPER_H__ > + > +#include > + > +struct drm_connector; > +struct drm_device; > +struct drm_modeset_acquire_ctx; > + > +int drm_helper_probe_single_connector_modes(struct drm_connector > + *connector, uint32_t maxX, > + uint32_t maxY); > +int drm_helper_probe_detect(struct drm_connector *connector, > + struct drm_modeset_acquire_ctx *ctx, > + bool force); > +void drm_kms_helper_poll_init(struct drm_device *dev); > +void drm_kms_helper_poll_fini(struct drm_device *dev); > +bool drm_helper_hpd_irq_event(struct drm_device *dev); > +void drm_kms_helper_hotplug_event(struct drm_device *dev); > + > +void drm_kms_helper_poll_disable(struct drm_device *dev); > +void drm_kms_helper_poll_enable(struct drm_device *dev); > +bool drm_kms_helper_is_poll_worker(void); > + > +#endif -- = Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A4FC43387 for ; Tue, 15 Jan 2019 14:29:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3077A2063F for ; Tue, 15 Jan 2019 14:29:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D1gc9eK2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JmClL8V1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3077A2063F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ig+312WNY7Vfg/SzRR1Co+dzTZVM8ias/yAjJXewnNs=; b=D1gc9eK2CregxV tRC4nshoYGUGWmyGMLhQktRAN/jrMCaDIYeOgYCSdjhDB02ThWTmNUqT1xgNWwXMj7SabMPpFxrZA FK/SbE9Xqi0gQZ/qs7Du1vJydcyN39FUYS8WP1OunjBfSPaY5CFeklA86Z0GBzUaEUVvBsoXOSxXi xBFhp87hX2pExR5z9WrCSZf6my/suExY6yl6O3uIylJhMObj5vNGIUErFD2Skq0y8KG1hJjn3TFzn A4Es3C+1Yaznc4dAYjv5AO/AXM6iB/Kj0rDS+QR1v5v2Z+dSbKJa7dRsuuwFutzm1kdmsTvK2vM9r Rv1J7l3x5pG921lfyG+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjPif-0007AE-JI; Tue, 15 Jan 2019 14:29:33 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gjPib-00079J-PV; Tue, 15 Jan 2019 14:29:32 +0000 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 104374F8; Tue, 15 Jan 2019 15:29:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1547562554; bh=6Lt8GE7mqRAOiWSVFaVewmz6sdGOGz5y3RFGYDTXlrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JmClL8V1yzOm1NiPOiRt3AbPAmmwS/zsVSQUlk77juViLMw3UAtIXX7MXO00MAwm8 vLeQVyWLKOo8hlJkFmP+xwzjmOk8y1TswwpAQ0SKPj2x5w7T+klz75gA62UJ+RSUmv LidnlD3AcVFwKpjHIs/6TJc/qh3P3wqlowbun6aQ= From: Laurent Pinchart To: Daniel Vetter Subject: Re: [PATCH] drm: Split out drm_probe_helper.h Date: Tue, 15 Jan 2019 16:30:29 +0200 Message-ID: <5798967.qfukvHqhlx@avalon> Organization: Ideas on Board Oy In-Reply-To: <20190115104137.25695-1-daniel.vetter@ffwll.ch> References: <20190115104137.25695-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190115_062930_281835_53378566 X-CRM114-Status: GOOD ( 28.39 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, DRI Development , virtualization@lists.linux-foundation.org, Benjamin Gaignard , Daniel Vetter , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, linux-samsung-soc@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-rockchip@lists.infradead.org, spice-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Intel Graphics Development , etnaviv@lists.freedesktop.org, Jani Nikula , linux-mediatek@lists.infradead.org, Rodrigo Vivi , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xen.org, linux-renesas-soc@vger.kernel.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Daniel, Thank you for the patch. On Tuesday, 15 January 2019 12:41:37 EET Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > = > To make sure I actually achieved the goal here I went through all > drivers. And indeed, all atomic drivers are now free of > drm_crtc_helper.h includes. > = > v2: Make it compile. There was so much compile fail on arm drivers > that I figured I'll better not include any of the acks on v1. > = > v3: Massive rebase because i915 has lost a lot of drmP.h includes, but > not all: Through drm_crtc_helper.h > drm_modeset_helper.h -> drmP.h > there was still one, which this patch largely removes. Which means > rolling out lots more includes all over. > = > This will also conflict with ongoing drmP.h cleanup by others I > expect. > = > v3: Rebase on top of atomic bochs. > = > Cc: Sam Ravnborg > Cc: Jani Nikula > Cc: Laurent Pinchart > Acked-by: Rodrigo Vivi (v2) > Acked-by: Benjamin Gaignard (v2) > Signed-off-by: Daniel Vetter > Cc: linux-arm-kernel@lists.infradead.org > Cc: virtualization@lists.linux-foundation.org > Cc: etnaviv@lists.freedesktop.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: intel-gfx@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Cc: nouveau@lists.freedesktop.org > Cc: spice-devel@lists.freedesktop.org > Cc: amd-gfx@lists.freedesktop.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-tegra@vger.kernel.org > Cc: xen-devel@lists.xen.org > --- > Merging this is going to be a bit a mess due to all the ongoing drmP.h > cleanups. I think the following should work: > - Apply Sam's prep patches for removing drmP.h from > drm_modeset_helper.h > - Get the i915 drmP.h cleanup backmerged into drm-misc-next > - Apply this patch. > - Apply Sam's patch to remove drmP.h from drm_modeset_helper.h > - All through drm-misc-next, which has some potential for trivial > conflicts around #includes with other drivers unfortunately. > = > I hope there's no other driver who'll blow up accidentally because > someone else is doing a drmP.h cleanup. Laurent maybe? There's a drmP.h cleanup in the R-Car DU driver, but it doesn't conflict wi= th = this patch, the combination of both compiles fine. > Jani, ack on this? > -Daniel > --- [snip] > drivers/gpu/drm/bridge/adv7511/adv7511.h | 5 +- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 2 +- > drivers/gpu/drm/bridge/dumb-vga-dac.c | 2 +- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- > drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- > drivers/gpu/drm/drm_atomic_helper.c | 1 - > drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- > drivers/gpu/drm/drm_modeset_helper.c | 2 +- > drivers/gpu/drm/drm_probe_helper.c | 2 +- > drivers/gpu/drm/drm_simple_kms_helper.c | 2 +- > drivers/gpu/drm/omapdrm/omap_connector.c | 2 +- > drivers/gpu/drm/omapdrm/omap_crtc.c | 2 +- > drivers/gpu/drm/omapdrm/omap_drv.c | 2 +- > drivers/gpu/drm/omapdrm/omap_drv.h | 2 +- > drivers/gpu/drm/omapdrm/omap_encoder.c | 2 +- > drivers/gpu/drm/omapdrm/omap_fb.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +- > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 1 + > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 + > drivers/gpu/drm/shmobile/shmob_drm_kms.c | 1 + > include/drm/drm_crtc_helper.h | 16 ------ > include/drm/drm_probe_helper.h | 50 +++++++++++++++++++ For the above files, with the comments below addressed, Reviewed-by: Laurent Pinchart > 227 files changed, 289 insertions(+), 200 deletions(-) > create mode 100644 include/drm/drm_probe_helper.h [snip] > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h > b/drivers/gpu/drm/bridge/adv7511/adv7511.h index 73d8ccb97742..d52ffab41e= b4 > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h > @@ -14,8 +14,11 @@ > #include > #include > = > -#include > +#include The probe helpers are needed in adv7511_drv.c only, I would move the includ= e = there. > #include > +#include > +#include > +#include Please keep the headers alphabetically sorted, here and in all other driver= s. > #define ADV7511_REG_CHIP_REVISION 0x00 > #define ADV7511_REG_N0 0x01 [snip] > diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c > b/drivers/gpu/drm/omapdrm/omap_crtc.c index 40acf4ce7c9f..9beb0edd5ffa > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_crtc.c > +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c > @@ -18,7 +18,7 @@ > #include > #include > #include > -#include > +#include This file doesn't use the probe helpers, you can drop this. > #include > #include > #include [snip] > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h > b/drivers/gpu/drm/omapdrm/omap_drv.h index bd7f2c227a25..513ae8ab5e64 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.h > +++ b/drivers/gpu/drm/omapdrm/omap_drv.h > @@ -23,7 +23,7 @@ > #include > = > #include > -#include > +#include This isn't needed globally in the driver either. > #include > #include > = > diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c > b/drivers/gpu/drm/omapdrm/omap_encoder.c index 148b6b20274f..cd2328fa4ba6 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_encoder.c > +++ b/drivers/gpu/drm/omapdrm/omap_encoder.c > @@ -18,7 +18,7 @@ > #include > = > #include > -#include > +#include As far as I can tell this is only used to include = drm_modeset_helper_vtables.h. Should we include that file instead ? > #include > = > #include "omap_drv.h" [snip] > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 90dacab67be5..b15d2b3a07f1 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include Not needed either. > #include > #include > #include [snip] > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c index > 1877764bd6d9..0b440f554aed 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > @@ -11,7 +11,7 @@ > = > #include > #include > -#include > +#include As far as I can tell this is only used to include = drm_modeset_helper_vtables.h. Should we include that file instead ? > #include > = > #include "rcar_du_drv.h" [snip] > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c index 39d5ae3fdf72..b7fa278ca745 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -11,7 +11,7 @@ > #include > #include > #include > -#include > +#include Not needed. > #include > #include > #include > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 4576119e7777..35b2a4d3ae74 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > @@ -10,7 +10,7 @@ > #include > #include > #include > -#include > +#include Not needed. > #include > #include > #include [snip] > diff --git a/include/drm/drm_probe_helper.h b/include/drm/drm_probe_helpe= r.h > new file mode 100644 > index 000000000000..96c060c16a1e > --- /dev/null > +++ b/include/drm/drm_probe_helper.h > @@ -0,0 +1,50 @@ > +/* > + * Copyright =A9 2006 Keith Packard > + * Copyright =A9 2007-2008 Dave Airlie > + * Copyright =A9 2007-2008 Intel Corporation > + * Jesse Barnes > + * > + * Permission is hereby granted, free of charge, to any person obtaining= a > + * copy of this software and associated documentation files (the > "Software"), + * to deal in the Software without restriction, including > without limitation + * the rights to use, copy, modify, merge, publish, > distribute, sublicense, + * and/or sell copies of the Software, and to > permit persons to whom the + * Software is furnished to do so, subject to > the following conditions: + * > + * The above copyright notice and this permission notice shall be includ= ed > in + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS > OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT= . = > IN NO EVENT SHALL + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR > ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF > CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WI= TH > THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. Let's use an SPDX tag instead. > + */ > + > +#ifndef __DRM_PROBE_HELPER_H__ > +#define __DRM_PROBE_HELPER_H__ > + > +#include > + > +struct drm_connector; > +struct drm_device; > +struct drm_modeset_acquire_ctx; > + > +int drm_helper_probe_single_connector_modes(struct drm_connector > + *connector, uint32_t maxX, > + uint32_t maxY); > +int drm_helper_probe_detect(struct drm_connector *connector, > + struct drm_modeset_acquire_ctx *ctx, > + bool force); > +void drm_kms_helper_poll_init(struct drm_device *dev); > +void drm_kms_helper_poll_fini(struct drm_device *dev); > +bool drm_helper_hpd_irq_event(struct drm_device *dev); > +void drm_kms_helper_hotplug_event(struct drm_device *dev); > + > +void drm_kms_helper_poll_disable(struct drm_device *dev); > +void drm_kms_helper_poll_enable(struct drm_device *dev); > +bool drm_kms_helper_is_poll_worker(void); > + > +#endif -- = Regards, Laurent Pinchart _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic