On 07/28/2016 08:37 AM, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > qga/guest-agent-command-state.c | 7 +++++++ > qga/guest-agent-core.h | 1 + > qga/main.c | 6 ++++++ > 3 files changed, 14 insertions(+) > > diff --git a/qga/guest-agent-command-state.c b/qga/guest-agent-command-state.c > index 4de229c..56e63b1 100644 > --- a/qga/guest-agent-command-state.c > +++ b/qga/guest-agent-command-state.c > @@ -71,3 +71,10 @@ GACommandState *ga_command_state_new(void) > cs->groups = NULL; > return cs; > } > + > +void ga_command_state_free(GACommandState *cs) > +{ > + g_slist_foreach(cs->groups, (GFunc)g_free, NULL); Here, the ugly cast is because we don't have a static forwarder function with the correct signature handy. Hmm, I wonder if it is worth adding a static inline forwarder function in one of our headers that ALL files can use, when they want to use a 2-arg callback that merely calls g_free() on its first argument and ignores the second, since we have now proved it is a commonly-used forwarder. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org