From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754799AbcHASrZ (ORCPT ); Mon, 1 Aug 2016 14:47:25 -0400 Received: from mail-by2nam01on0063.outbound.protection.outlook.com ([104.47.34.63]:3136 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754697AbcHASrN (ORCPT ); Mon, 1 Aug 2016 14:47:13 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Message-ID: <579F958F.9020508@caviumnetworks.com> Date: Mon, 1 Aug 2016 11:31:43 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Mark Brown CC: Jan Glauber , , , David Daney , "Steven J . Hill" Subject: Re: [PATCH v2 2/2] spi: octeon: Add thunderx driver References: <20160728083144.16625-1-jglauber@cavium.com> <20160728083144.16625-3-jglauber@cavium.com> <20160801172838.GW10376@sirena.org.uk> In-Reply-To: <20160801172838.GW10376@sirena.org.uk> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: BN1PR07CA0056.namprd07.prod.outlook.com (10.255.193.31) To BN4PR07MB2129.namprd07.prod.outlook.com (10.164.63.11) X-MS-Office365-Filtering-Correlation-Id: c9a6f367-f561-45e5-8143-08d3ba3a1890 X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;2:65vnuqof3NFGeXWEeg/EjJPkTuv+7fXki3qXDQKSJTg9LXe/f5kdWX7mtYmHMsvQdtW+67atlW70Rt6lGhEv5fIQidN5jgPeh4sVI+RYGQMwSjK678zlm74ySm4n6pQHCqiB/IdI0vof93allVN6BCRXiZHKdmVzq7Qnyyw3SVMEy/TsbRPDNooZHlxy5H4I;3:WHExcEqNPvP0XIM56+bykpodDoeNwDHQbIbSwzWb0yEzp7IWhf4waiP+ih02zBu95nrtSEm/t0ZCpmk3SB2EupkzVnLBRMTiGqpCdoucCdW5ASx4+EqSBuIfp51YzDSe;25:Y+hTiKpftwePC4MF9DfLqmyQWXZv0ljY1zbBLkSiLTuXU+lMl9giK5/uwc6GLYR3s3dPbLu+TXA4hkqeau3UwDjwqP47rWNp/o/tymXs/TdmTBwynDaJBaIRivIXxCZjpLUvQtQsVouebTIH4Ns6CHjDiL9Wc0YCq8GjwK582ek7VQs2ty1EdD9JheKyv8OR1USTXZaEgaLo1YdTLPa6pY7r1ZBmm2d6gDOYbbOUQn4mbHXFD6qHAY3VS/qj+G4cgu/EQ3MnW6ypL1Znkh0TcTrSRYIJv0ZHEbJ6ytvDiuLqK6RugaJOboj/mG1Jc828qTw5z2JZp5CGYzEOhbTkvsRbyrXhk7XReW+VIxuLVmz/BBzzXBmrDE8XmV34jcJs+qsvvIlHkMMkY72ls0xIIK7pko/4RpUfVpZZ4X1xpqQ=;31:I4i0CtAuTZjPdNjt+lamUDCGwulQOz+DwQS9egtomOxH+729+55ZP1j14bCQOZiEyuJrMyuO76TDpdLw09CZOdUm4AiY6mOH1kAW42nm6Fdz1rsUOfQtFzEr5boXUloXyuE0HbelcczgTTQxJ/f16hsSLae+fonilmI2lPOXvh071x3QfsGDKMJ5DkgCDWWUz8PeXRlMNFmxN+85fdejZA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2129; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;20:4/+w0xYHC6q6i8reX+FAJIFvcn96cTS/S7FMZJR20W3HdgcdYdml4PXcxI92l8lz2JawOL5mkp63mePW1G6vkIQGjFyYzaA3ciUtUYt0oBtw7MGNnOPBr460XmxlmlyB63Toh+9jyeCItu/lpC7oz7PgkOW8hzv1SlUWP+ZX82pQikYSTGJSJw6FGtLSaG7RrPaSNvfAa+HHBgIU68dl/oMnrYbMkP0PYfTVjA5e91UcohF5Vc92oKWJ2v43Wx38VyDxwgWELTCg4A+zz895Pdb+eIF6Jg2asc46Kvmhl5sQQsoFh2NSqWISWiLHMymKvV53NnEycCGh9+CQ8uUjPNd3a1ZJXvKnW3nIwVCOVUGt/EwjxlJjMVpRIPSNDl05pOSRIlR3NN0nSp8HbEQQ8Ti+kW1ZR8TILsuiHAOuzcp2Y3sbQXgr7uPbAutP4Mz2n09h7UNfvwYcgJkLdBP3YhsxgxLq984lzWOestTRjPt8SNLGapSnh3ogHNgK7qWVvT8r6qrnJvEVEGp4QYypXOYPpbx2TL9SYibP4gp6eZspDIqBPjJihRsUww3W35YdnW+VWbyFUizGXkGtaACSUVXyVdkXaegLLr8x8f9Vr+I= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN4PR07MB2129;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2129; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;4:YNDH4tHfL72WRU3RIeL/lCb7pvjtyNaP3qr5F1Obmt3XoQUe2sO6fkgx4SkG07hQ5X8eXOZk1Ta9tS4Hpp5EjAfuu+UO7zfZBKcXtjk4VZahurueeehryl2uV/UgStTVj591iwB+LaTqkJQIxW2ol9Pbhj5GJDXr2ZAVO5dMp9Orf3t+2zWEU+Eb8OL9mU8P1IwiCgAb7I8JKitxYQIcOXylfd/WNwXLxW/4GD4aDd1xXycaXPb9JRhLZCWMunRcxp6D5XEssH1CY7kcuQ/lrgMpu6dafX8XvO0SscyPJXgahe2trP8YxFDmMTH4C/OYbjCjEA6ZkbZn/UBYrtajGiJzCiu8w4DFIhFAJJUaJ14MT0kCUmUpcQ7OuxfHgTau X-Forefront-PRVS: 0021920B5A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(377454003)(24454002)(189002)(199003)(97736004)(69596002)(6116002)(77096005)(107886002)(4001350100001)(110136002)(47776003)(65806001)(65956001)(66066001)(189998001)(59896002)(83506001)(105586002)(33656002)(586003)(23756003)(92566002)(64126003)(36756003)(2906002)(50466002)(2950100001)(4326007)(3846002)(101416001)(42186005)(8676002)(305945005)(4001430100002)(230700001)(53416004)(81156014)(54356999)(7736002)(7846002)(106356001)(81166006)(76176999)(68736007)(87266999)(65816999)(80316001)(50986999)(3076002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2129;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN4PR07MB2129;23:qmMeGxYTpERCHJZojoD9+wHw8B6K7bUU8Msj2oj?= =?iso-8859-1?Q?WzT+JcIEH84iKbm7LHTfL6xJWZdbkROBTCRTgorEdPt4+gmGdFODKhpCqM?= =?iso-8859-1?Q?sZ3T9fUmhWFTobAeaNtMS+0wVnQWTBzA4M7CzhuSUlc14JlAuWz1FDons6?= =?iso-8859-1?Q?VBqgxKaqZiWKVdHoSbv3SoeSTl9WK+J6WFj6bCsv3kx4ai6JYvdTKa6485?= =?iso-8859-1?Q?QkdwtKMCHArO9FRKBzsg4UwMPMNdndvmxyXL8Cz0dn14aFFhIjG8H/GlH3?= =?iso-8859-1?Q?NOywKLDLlAKLfiawYn9fbVMG6VTp8o66QXhqrSmGNUdYO4lD8f2kCMoi9Z?= =?iso-8859-1?Q?gdV6O5BJf4VkIoFIQsnn1wZZQnIEB/IsPX+qSW5+g8epG8NUT1wHq+w7Jv?= =?iso-8859-1?Q?YdbKFke6iAih/4iph1h+kd46Vh01/60cjwR9F8iyAp4foCcFSfUZhw2eGv?= =?iso-8859-1?Q?5fLjEiPtiKV6qUxGgMUaFosN68z64IarBf/VPCMXR2NkUsItr8Wnoq8d6v?= =?iso-8859-1?Q?Zc6GEnANLvBFPZ7U4FQg/IVLF8Oo9VZgHqH7u+JbYfkdlV9eNF5d8pwZTO?= =?iso-8859-1?Q?w2cnHM8llLnqLdg/k3pLrinHu9iS4wEnPIkrw9DIUtPO9An13Ftaxs0bOC?= =?iso-8859-1?Q?58cyPHFrOV4CZDI2ahu/fknAF2wcCQiInOyXXeCe5yMCzzCNLgGiDWIix5?= =?iso-8859-1?Q?/1E4qXj4oPdUFmg80nGZR6KB3N67s7mpJo8vuIhGgKZ4ULSltxq20Cz8Fk?= =?iso-8859-1?Q?mLiLPwqmShp3oU6OUuy+lRUv6PQ9vbRaMDXltJ96SYp5qKuJkAJqDPPwYc?= =?iso-8859-1?Q?jDcjeBLEazn1fZhJcXB6FeRjoIKp5jxSuPRzVaRKcTvOrYyw9zBvZZ5y2V?= =?iso-8859-1?Q?kFafrsaNEKH5KdwAG9MgUvAscXmYPK9FnaqVcYTKtF0H5nlDvhQLFwJ5At?= =?iso-8859-1?Q?S0ZiZFDUpLKQ/AVLF/Bke4QnYLZgIIDJrt/smc7pfhKlF82tmys0ad2+LG?= =?iso-8859-1?Q?45Tj8/0iGN/MHW77VhaWK+563bEeooqdmkEN8qANg89eNal3/zXQB7ggOR?= =?iso-8859-1?Q?uSUzm5KsNP1dqm3g09i9l3mPnaD0IFxNHDYlZ30inxtUSw1sDUzCTpNPJ7?= =?iso-8859-1?Q?ukH8WHJqENV7HqeEtlDp22AxG7/BMsxjOBW1gtsKB27LXYuuiTE7UK3QsK?= =?iso-8859-1?Q?uA2G7l/WJBunGKn3beDY3GuU/8F3wx5KR4dj0sJXcg1eiaNlrb/TZ2qtHI?= =?iso-8859-1?Q?gbBxvD6r0Com3wRc3GBnYV9plgjbYAPxBiRnSJJ4Mi5MhWKSjEnpKZf+4L?= =?iso-8859-1?Q?TS7koI0pPSPh6fR91cABzuICaZHI6vBdjw7LJ5K7/l0BFKxr5sOm5haX1i?= =?iso-8859-1?Q?A27Jl1cI=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;6:lgbTCpvgSPkyFOsPws1Ocbl14oFRY2cvBb33fK0ubjGe3aZPRdLf8bCzSzJsbLSCpw2SV0vCWzsP1Twbo6/NuLvLsQgC1hjJZ/p66YmSKEo49iPwjeZNanJ9jItx8dmVoz/gvrYIg42uvC+lUhKmcyxuU4oTzH7zDkjzGBWukqAGKdWWgKIPVxXJIq5nTXpzWdNJHG45Akm1aGmrfJp95/E6dd1BzVZu79P/84v6RTF6u78rn5ihzE5G2HR+AyjEmSNOGlpSALebM4xC2UGD0O3GHfqatM+Hpv/51JS/Jro=;5:NIV7sdvtxB50V977ojAhHCNOJ9DL0KPFkQs7SW9ZCAM/W6gfTZSCHJhFryh/ViVx9wTMXXgqasdpO0z2Ib9WXp0c1okpjWOM0PZBCgFojz38W+dOpyqIA4+AS8UOVFGl4+FgAXEwLlccJ12tK5y9IA==;24:B4xoZHv9Bz9hgoatr2zkYbp6IMNPzW+OqoXOAgD47wPQsOcLXbsvTWcpz8hjw7ipIbTHcdI8MBK/WNDn9AeZuk5q9HqGHgdJ81xnfC1ILZ0=;7:n2ngIg1Kkh4igUiiyH6ZWZS89oa8JDLIGzD4B5M8GCw7e+GnHV2vO4yg/GO0P+XeIfJpeksFX2SFlxSscw9HaHlJ4wSpUt3kcdaBQUyOAODhwF5LbaoNuYS9DmI9upKPSCAhk7MHf5I7Q5yhaZBw3DrPJPMFbzOOsvH+k8bR522ggsMVD3r8RNoTBQYAWwsOeYyGitYSl4GfkOJhtfeULCt9oNv/+SfS2Vqk9Z/iS8w6WvFGyy1SNO1WYm5s6ZFX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 18:31:46.5339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2129 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/2016 10:28 AM, Mark Brown wrote: > On Thu, Jul 28, 2016 at 10:31:44AM +0200, Jan Glauber wrote: > >> +config SPI_THUNDERX >> + tristate "Cavium ThunderX SPI controller" >> + depends on (ARM64 || CONFIG_TEST) && 64BIT && PCI > > You mean COMPILE_TEST. Yes, we will fix that typo. > >> + p->clk = devm_clk_get(dev, NULL); >> + if (IS_ERR(p->clk)) >> + goto out_unmap; > > We're now just using the normal clock API which is good but I'm now > unclear what is going to ensure that the clock is there - is there some > other change elsewhere that I'm not aware of? The clock is an integral part of the SoC and is always running, so it will always be there. All we want to know is the frequency, which is supplied by the device tree clock-bindings framework > We're also not passing > the resulting error code back to the caller which will break deferred > probe. > Yes, we should do that. >> +out_clock: >> + clk_disable_unprepare(p->clk); >> +out_clock_devm: >> + devm_clk_put(dev, p->clk); > > There's no point in using managed allocations if you're going to manually > free things... Yes, we should let the automatic cleanup do its work here. Probably we should consider using pcim_iomap(...) as well >