From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: [patch 056/101] mm, vmscan: remove redundant check in shrink_zones() Date: Thu, 28 Jul 2016 15:47:20 -0700 Message-ID: <579a8b78.L6XUEuhOTBJsNA1o%akpm@linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:57060 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbcG1WrV (ORCPT ); Thu, 28 Jul 2016 18:47:21 -0400 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: torvalds@linux-foundation.org, mm-commits@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, hannes@cmpxchg.org, minchan@kernel.org, vbabka@suse.cz From: Mel Gorman Subject: mm, vmscan: remove redundant check in shrink_zones() As pointed out by Minchan Kim, shrink_zones() checks for populated zones in a zonelist but a zonelist can never contain unpopulated zones. While it's not related to the node-lru series, it can be cleaned up now. Link: http://lkml.kernel.org/r/1468853426-12858-2-git-send-email-mgorman@techsingularity.net Signed-off-by: Mel Gorman Suggested-by: Minchan Kim Acked-by: Minchan Kim Acked-by: Johannes Weiner Cc: Vlastimil Babka Signed-off-by: Andrew Morton --- mm/vmscan.c | 3 --- 1 file changed, 3 deletions(-) diff -puN mm/vmscan.c~mm-vmscan-remove-redundant-check-in-shrink_zones mm/vmscan.c --- a/mm/vmscan.c~mm-vmscan-remove-redundant-check-in-shrink_zones +++ a/mm/vmscan.c @@ -2605,9 +2605,6 @@ static void shrink_zones(struct zonelist for_each_zone_zonelist_nodemask(zone, z, zonelist, sc->reclaim_idx, sc->nodemask) { - if (!populated_zone(zone)) - continue;