From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC8EC2BA83 for ; Wed, 12 Feb 2020 10:00:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEFC020714 for ; Wed, 12 Feb 2020 09:59:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vNmQgvcB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728846AbgBLJ77 (ORCPT ); Wed, 12 Feb 2020 04:59:59 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:41714 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728715AbgBLJ77 (ORCPT ); Wed, 12 Feb 2020 04:59:59 -0500 Received: by mail-wr1-f67.google.com with SMTP id c9so1419585wrw.8 for ; Wed, 12 Feb 2020 01:59:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TgdHUqu43QugB+XJry+tdyUlOnTQbDHzldNID7DKlTY=; b=vNmQgvcBd+artf/9LPE/bD4l5LGoyC7mcQ8eWEnPD2c9BJ+S0YBX6l6t6NQUVqekRD d9eJvrgCNzevsgfSw1LSeTea18i9CBlJTtw+tBATGKp0V3lgO2xdn7YGBdzbQAgMKnhC zhHNqxJTFZLTFivI+lAZU6IKyoD6BKFZ/3P0TVsW7WhfahXuS68v+iFlA9BMlNupGZWm 28B+5W8qtN+alZHPotZySvmBg3gBx6+jAMHZ3ogJXXqCwrTTLfQjGtpbjhrAxaToIxOF nHKuTg6/srC6vAcUDSVrFz7wYvbLXCQ3UApDKKEVAeWK+rz70hr7fPyoS3uHqZ8QlRHZ fgsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TgdHUqu43QugB+XJry+tdyUlOnTQbDHzldNID7DKlTY=; b=bs1ZQz09VWANvz54hFYIsc09Q2jXIzYhaAczNtRyz31cr0u+eLMBgeOG2upDdi9jik ANwlT/CzXuKU+KMJneR4h3bXBZPrjKWV9FJKZA0cwgDT8aheZsDVghQP1Svvfm35lVxc UNEKRNFdCuWlEMeJszbKLyPz+yYe/Sz8UKayCR4PDuBXEfggDH0p8q1e725myZhYKOX3 bGtf8CfGjzalSlJj3WyUwVeonEnKBTKuE4ZljxyKTVtbfe1s0/6v3yuoBxni5xs3m3R1 k+URGhtnK938DtLZnqPmnjwRWUL+6JWyomJSoQHhHwcbVnFZt4bE9ZaFofm6F7hDAPI8 pcPg== X-Gm-Message-State: APjAAAVZyWV5a3usiwTgPWWzXCV+AW5l+SLZ4wmxMQdpVB8vdaftMJoN SytgkhWOBGgw5HUsE9ITZ1X+MQ== X-Google-Smtp-Source: APXvYqwWhJvMF+JERj9lJ5S96xuxaaQT7YqaxjBM5IG5LhDeP1ZB8cANLTbQQGoG5DVj5KHNGWum3g== X-Received: by 2002:adf:a389:: with SMTP id l9mr14229912wrb.411.1581501597101; Wed, 12 Feb 2020 01:59:57 -0800 (PST) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id t128sm38157wmf.28.2020.02.12.01.59.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Feb 2020 01:59:56 -0800 (PST) Subject: Re: [PATCH v3 6/6] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding documentation To: Adam Serbinski , Mark Brown , Rob Herring , Bjorn Andersson Cc: Andy Gross , Mark Rutland , Liam Girdwood , Patrick Lai , Banajit Goswami , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200212015222.8229-1-adam@serbinski.com> <20200212015222.8229-7-adam@serbinski.com> From: Srinivas Kandagatla Message-ID: <579e0ae1-f257-7af3-eac9-c8e3ab3b52c7@linaro.org> Date: Wed, 12 Feb 2020 09:59:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200212015222.8229-7-adam@serbinski.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 12/02/2020 01:52, Adam Serbinski wrote: > This patch adds documentation of bindings required for PCM ports on AFE. > > Signed-off-by: Adam Serbinski > CC: Andy Gross > CC: Mark Rutland > CC: Liam Girdwood > CC: Patrick Lai > CC: Banajit Goswami > CC: Jaroslav Kysela > CC: Takashi Iwai > CC: alsa-devel@alsa-project.org > CC: linux-arm-msm@vger.kernel.org > CC: devicetree@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > .../devicetree/bindings/sound/qcom,q6afe.txt | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt > index d74888b9f1bb..6b1b17d31a2a 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt > +++ b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt > @@ -51,6 +51,24 @@ configuration of each dai. Must contain the following properties. > Definition: Must be list of serial data lines used by this dai. > should be one or more of the 0-3 sd lines. > > + - qcom,pcm-quantype > + Usage: required for pcm interface > + Value type: > + Definition: PCM quantization type > + 0 - ALAW, no padding > + 1 - MULAW, no padding > + 2 - Linear, no padding > + 3 - ALAW, padding > + 4 - MULAW, padding > + 5 - Linear, padding > + > + - qcom,pcm-slot-mapping > + Usage: required for pcm interface Are these not specific to 8k and 16k mode ? We should probably list values for both modes here. --srini > + Value type: > + Definition: Slot mapping for audio channels. Array size is the number > + of slots, minimum 1, maximum 4. The value is 0 for no mapping > + to the slot, or the channel number from 1 to 32. > + > - qcom,tdm-sync-mode: > Usage: required for tdm interface > Value type: > @@ -174,5 +192,29 @@ q6afe@4 { > reg = <23>; > qcom,sd-lines = <1>; > }; > + > + pri-pcm-rx@105 { > + reg = <105>; > + qcom,pcm-quantype = <2>; > + qcom,pcm-slot-mapping = <1>; > + }; > + > + pri-pcm-tx@106 { > + reg = <106>; > + qcom,pcm-quantype = <2>; > + qcom,pcm-slot-mapping = <1>; > + }; > + > + quat-pcm-rx@111 { > + reg = <111>; > + qcom,pcm-quantype = <5>; > + qcom,pcm-slot-mapping = <0 0 1>; > + }; > + > + quat-pcm-tx@112 { > + reg = <112>; > + qcom,pcm-quantype = <5>; > + qcom,pcm-slot-mapping = <0 0 1>; > + }; > }; > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5249FC2BA83 for ; Wed, 12 Feb 2020 10:00:58 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4E3520675 for ; Wed, 12 Feb 2020 10:00:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="I7FNUxVx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vNmQgvcB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4E3520675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3850B166C; Wed, 12 Feb 2020 11:00:06 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3850B166C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581501656; bh=CICgCkOhoTJWkHGRqN/+9LwDR8Iljyo1LdOMKlrUw/E=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=I7FNUxVx09W2jLfBKkVSEVSrOZCJHoJmlbvl0abosOZ/PN/406qPbgDU7pU+/bO1C 3BpNFz8Z16lNNDZjkgh6p3sRxYBjvGIvqW6s7Xl2kUiQzdKmwObop5Cos/TTt5el5O dyBK5h+CrCXlVOrhtyj37RD3h0dwFtkzjeTsV3Qs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AF2A1F800E7; Wed, 12 Feb 2020 11:00:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3F4DFF80157; Wed, 12 Feb 2020 11:00:03 +0100 (CET) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1BF54F800E7 for ; Wed, 12 Feb 2020 10:59:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1BF54F800E7 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vNmQgvcB" Received: by mail-wr1-x442.google.com with SMTP id g3so1404360wrs.12 for ; Wed, 12 Feb 2020 01:59:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TgdHUqu43QugB+XJry+tdyUlOnTQbDHzldNID7DKlTY=; b=vNmQgvcBd+artf/9LPE/bD4l5LGoyC7mcQ8eWEnPD2c9BJ+S0YBX6l6t6NQUVqekRD d9eJvrgCNzevsgfSw1LSeTea18i9CBlJTtw+tBATGKp0V3lgO2xdn7YGBdzbQAgMKnhC zhHNqxJTFZLTFivI+lAZU6IKyoD6BKFZ/3P0TVsW7WhfahXuS68v+iFlA9BMlNupGZWm 28B+5W8qtN+alZHPotZySvmBg3gBx6+jAMHZ3ogJXXqCwrTTLfQjGtpbjhrAxaToIxOF nHKuTg6/srC6vAcUDSVrFz7wYvbLXCQ3UApDKKEVAeWK+rz70hr7fPyoS3uHqZ8QlRHZ fgsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TgdHUqu43QugB+XJry+tdyUlOnTQbDHzldNID7DKlTY=; b=UrOV2Sf1D8txjg+mOH/7RlLOtUHfpVFsftU7V19uzRL8uebPVtELfARaHxXrCn5FjV z94/noB2XHTL0nMF+kxZ7rSG+XWnd2WQ4wATlazQrrliMwapUKykLw3PjqNsry8nB1bs Tu7Ke7vILe1SKXCa/2uU7jr6ljc/+fkOKPdJbPsxDL4xLxyyfn59kqiR5y8xQRJUHNqF VsJ0hKRbkcfBFo9lCj76CAHOMDx1IpTCxlNWSDTtS+C3YdJqsDGXjL0mMqEULanj8Nxc y7nyY/OLoLRqLZ/ejIzmobXQy38vJbWH6WBNcj5xlbcTgHX7/55uphDkBKCZhDOd83CV VPxQ== X-Gm-Message-State: APjAAAWwggAJbRxi1Wqk7zj9QMEDhzao1DPM6tk/1XXAswYBfJtEfE3D Vw9kyQD8GBigg3v+fCBJAi3srYyXP08= X-Google-Smtp-Source: APXvYqwWhJvMF+JERj9lJ5S96xuxaaQT7YqaxjBM5IG5LhDeP1ZB8cANLTbQQGoG5DVj5KHNGWum3g== X-Received: by 2002:adf:a389:: with SMTP id l9mr14229912wrb.411.1581501597101; Wed, 12 Feb 2020 01:59:57 -0800 (PST) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id t128sm38157wmf.28.2020.02.12.01.59.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Feb 2020 01:59:56 -0800 (PST) To: Adam Serbinski , Mark Brown , Rob Herring , Bjorn Andersson References: <20200212015222.8229-1-adam@serbinski.com> <20200212015222.8229-7-adam@serbinski.com> From: Srinivas Kandagatla Message-ID: <579e0ae1-f257-7af3-eac9-c8e3ab3b52c7@linaro.org> Date: Wed, 12 Feb 2020 09:59:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200212015222.8229-7-adam@serbinski.com> Content-Language: en-US Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Banajit Goswami , linux-arm-msm@vger.kernel.org, Patrick Lai , Takashi Iwai , Liam Girdwood , Andy Gross , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v3 6/6] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding documentation X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/02/2020 01:52, Adam Serbinski wrote: > This patch adds documentation of bindings required for PCM ports on AFE. > > Signed-off-by: Adam Serbinski > CC: Andy Gross > CC: Mark Rutland > CC: Liam Girdwood > CC: Patrick Lai > CC: Banajit Goswami > CC: Jaroslav Kysela > CC: Takashi Iwai > CC: alsa-devel@alsa-project.org > CC: linux-arm-msm@vger.kernel.org > CC: devicetree@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > .../devicetree/bindings/sound/qcom,q6afe.txt | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt > index d74888b9f1bb..6b1b17d31a2a 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt > +++ b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt > @@ -51,6 +51,24 @@ configuration of each dai. Must contain the following properties. > Definition: Must be list of serial data lines used by this dai. > should be one or more of the 0-3 sd lines. > > + - qcom,pcm-quantype > + Usage: required for pcm interface > + Value type: > + Definition: PCM quantization type > + 0 - ALAW, no padding > + 1 - MULAW, no padding > + 2 - Linear, no padding > + 3 - ALAW, padding > + 4 - MULAW, padding > + 5 - Linear, padding > + > + - qcom,pcm-slot-mapping > + Usage: required for pcm interface Are these not specific to 8k and 16k mode ? We should probably list values for both modes here. --srini > + Value type: > + Definition: Slot mapping for audio channels. Array size is the number > + of slots, minimum 1, maximum 4. The value is 0 for no mapping > + to the slot, or the channel number from 1 to 32. > + > - qcom,tdm-sync-mode: > Usage: required for tdm interface > Value type: > @@ -174,5 +192,29 @@ q6afe@4 { > reg = <23>; > qcom,sd-lines = <1>; > }; > + > + pri-pcm-rx@105 { > + reg = <105>; > + qcom,pcm-quantype = <2>; > + qcom,pcm-slot-mapping = <1>; > + }; > + > + pri-pcm-tx@106 { > + reg = <106>; > + qcom,pcm-quantype = <2>; > + qcom,pcm-slot-mapping = <1>; > + }; > + > + quat-pcm-rx@111 { > + reg = <111>; > + qcom,pcm-quantype = <5>; > + qcom,pcm-slot-mapping = <0 0 1>; > + }; > + > + quat-pcm-tx@112 { > + reg = <112>; > + qcom,pcm-quantype = <5>; > + qcom,pcm-slot-mapping = <0 0 1>; > + }; > }; > }; > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel