From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755656AbcHBIOc (ORCPT ); Tue, 2 Aug 2016 04:14:32 -0400 Received: from prv-mh.provo.novell.com ([137.65.248.74]:54350 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbcHBIOS convert rfc822-to-8bit (ORCPT ); Tue, 2 Aug 2016 04:14:18 -0400 Message-Id: <57A0636A0200007800101998@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.1 Date: Tue, 02 Aug 2016 01:10:02 -0600 From: "Jan Beulich" To: "Juergen Gross" Cc: , , , Subject: Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look less scary References: <1470120213-16683-1-git-send-email-jgross@suse.com> In-Reply-To: <1470120213-16683-1-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 02.08.16 at 08:43, wrote: > --- a/arch/x86/xen/pmu.c > +++ b/arch/x86/xen/pmu.c > @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu) > return; > > fail: > - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n", > - cpu, err); > + if (err == -EOPNOTSUPP) > + pr_info_once("VPMU disabled by hypervisor.\n"); > + else > + pr_info_once("Could not initialize VPMU for cpu %d, error %d\n", > + cpu, err); I'm sorry for not already having thought about this for v1, but what about older hypervisors, where the hypercall would return -ENOSYS? Jan From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v2] xen: Make VPMU init message look less scary Date: Tue, 02 Aug 2016 01:10:02 -0600 Message-ID: <57A0636A0200007800101998@prv-mh.provo.novell.com> References: <1470120213-16683-1-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUTq4-0004Xm-P8 for xen-devel@lists.xenproject.org; Tue, 02 Aug 2016 07:10:08 +0000 In-Reply-To: <1470120213-16683-1-git-send-email-jgross@suse.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross Cc: xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org Pj4+IE9uIDAyLjA4LjE2IGF0IDA4OjQzLCA8Skdyb3NzQHN1c2UuY29tPiB3cm90ZToKPiAtLS0g YS9hcmNoL3g4Ni94ZW4vcG11LmMKPiArKysgYi9hcmNoL3g4Ni94ZW4vcG11LmMKPiBAQCAtNTQ3 LDggKzU0NywxMSBAQCB2b2lkIHhlbl9wbXVfaW5pdChpbnQgY3B1KQo+ICAJcmV0dXJuOwo+ICAK PiAgZmFpbDoKPiAtCXByX2luZm9fb25jZSgiQ291bGQgbm90IGluaXRpYWxpemUgVlBNVSBmb3Ig Y3B1ICVkLCBlcnJvciAlZFxuIiwKPiAtCQljcHUsIGVycik7Cj4gKwlpZiAoZXJyID09IC1FT1BO T1RTVVBQKQo+ICsJCXByX2luZm9fb25jZSgiVlBNVSBkaXNhYmxlZCBieSBoeXBlcnZpc29yLlxu Iik7Cj4gKwllbHNlCj4gKwkJcHJfaW5mb19vbmNlKCJDb3VsZCBub3QgaW5pdGlhbGl6ZSBWUE1V IGZvciBjcHUgJWQsIGVycm9yICVkXG4iLAo+ICsJCQljcHUsIGVycik7CgpJJ20gc29ycnkgZm9y IG5vdCBhbHJlYWR5IGhhdmluZyB0aG91Z2h0IGFib3V0IHRoaXMgZm9yIHYxLCBidXQKd2hhdCBh Ym91dCBvbGRlciBoeXBlcnZpc29ycywgd2hlcmUgdGhlIGh5cGVyY2FsbCB3b3VsZCByZXR1cm4K LUVOT1NZUz8KCkphbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0 cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=