From: Andrzej Hajda <a.hajda@samsung.com>
To: Thierry Reding <treding@nvidia.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: Why drm-mipi-dsi is built-in only?
Date: Tue, 02 Aug 2016 12:47:06 +0200 [thread overview]
Message-ID: <57A07A2A.7010500@samsung.com> (raw)
In-Reply-To: <20160802083623.GA4726@ulmo.ba.sec>
On 08/02/2016 10:36 AM, Thierry Reding wrote:
> On Mon, Aug 01, 2016 at 08:04:55PM +0200, Andrzej Hajda wrote:
>> On 08/01/2016 03:59 PM, Jani Nikula wrote:
>>> Cc Andrzej, Thierry
>>>
>>> On Fri, 22 Jul 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
>>>> On Fri, Jul 22, 2016 at 04:30:24PM +0200, Takashi Iwai wrote:
>>>>> Hi,
>>>>>
>>>>> is there any reason drm-mipi-dsi can't be a module? It's fixed as a
>>>>> built-in since its Kconfig is bool.
>>>> Probably none except embedded folks eshew modules ;-) Submit patch, I'll
>>>> apply.
>>> Possibly this?
>>>
>>> postcore_initcall(mipi_dsi_bus_init);
>> If I remember correctly, the only reason for this is to have mipi_dsi bus
>> registered before mipi_dsi drivers, which usually are registered
>> at module initcall. But maybe bus registration can be performed at
>> first mipi_dsi driver registration. This way we could modularize it.
> I think it should work fine if this was built as a module. The purpose
> for having this as postcore_initcall() is simply so that the bus is
> fully initialized before any driver gets registered with it. If this
> code is built as a module, symbol dependencies will make sure that the
> drm_mipi_dsi.ko module will be loaded before any users.
If you change initcall of mipi_dsi to module and then you compile
it as built-in, only link order will guard correct initialization sequence.
As for now panels are linked after mipi-dsi, so it should be OK,
even if little bit hacky.
Regards
Andrzej
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-02 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 14:30 Why drm-mipi-dsi is built-in only? Takashi Iwai
2016-07-22 16:55 ` Daniel Vetter
2016-08-01 13:59 ` Jani Nikula
2016-08-01 18:04 ` Andrzej Hajda
2016-08-02 8:36 ` Thierry Reding
2016-08-02 10:47 ` Andrzej Hajda [this message]
2016-08-02 11:47 ` Thierry Reding
2016-08-02 11:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A07A2A.7010500@samsung.com \
--to=a.hajda@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.