From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756019AbcHCGyY (ORCPT ); Wed, 3 Aug 2016 02:54:24 -0400 Received: from mail-ve1eur01on0090.outbound.protection.outlook.com ([104.47.1.90]:26880 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753539AbcHCGyQ (ORCPT ); Wed, 3 Aug 2016 02:54:16 -0400 X-Greylist: delayed 66073 seconds by postgrey-1.27 at vger.kernel.org; Wed, 03 Aug 2016 02:54:15 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v2] kasan: avoid overflowing quarantine size on low memory systems To: Alexander Potapenko , , , , , , , , , References: <1470133620-28683-1-git-send-email-glider@google.com> CC: , , From: Andrey Ryabinin Message-ID: <57A0C5C8.4030304@virtuozzo.com> Date: Tue, 2 Aug 2016 19:09:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1470133620-28683-1-git-send-email-glider@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: DB5PR10CA0032.EURPRD10.PROD.OUTLOOK.COM (10.165.4.170) To DB6PR0802MB2551.eurprd08.prod.outlook.com (10.172.251.149) X-MS-Office365-Filtering-Correlation-Id: 1b8ddde3-f71a-4b08-64b0-08d3baef40d9 X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2551;2:C6h+sJLFpizy63gbfbNb9jD8Ei0cWIcM4viWSJYpnEDOJos2P8PGTk6XclFCApeRxFfd3KEHC+D+aKW5WkZYzE7dwQZzEn387MdzL+nDM6eWiSUDLyCj1LJNAG1PjtFYmwaiGOq7lalGWdxYmJCAK3jRvHr4uQp/as0m8BfQexa+VTyMPQvp7xyY/0WQNBAL;3:+2tgGcIsKW5eHkHhv+Y+uO30uDaGJkJiqAzz3tnTgZmSu8iKCmsJreDDJYj/7wdciHmkiBTaqOihCHC8IWnayKBJ76OONWKcwc5UCxdVjNluXWJu8iOCFoVBmqtKIYOS;25:cTYtusF1cYitDcMflYLbJVdfMFC/fTILpvgplWSX4GgjxSwwuYKRwuJ50GNdvzDrRcJ2ZESEzi4IZbf+lMc5XJ3DJWl3wBJDiIIK2HddMTZ8HkTQr5R0UYiFbbzFikpiB+zj1WFYXSW9OxBfqePYlp3JW0/jwGBgmLAohhGuXEAROEA4CAhf0wx1dxDmAzQi0JMlIrLUNWwrtYdaKX/MizNr+Q5GdqpT3B+n/+tbMw8PeGIhuC0zeUYYqINYwDZF6TgGJfRWGxfP4fYkmmxGxN++IMlXHzmXqk9hBCiEF7e6IhjihWC86GktBa6nHmDgMEOkVqGKczZ6FM5V0ywTHZpfjuuZy+AQZ9WfwF2R8aZdui+tnzbEoqcTUN8WBRJ0hL0GKLtWxHGKR7kj0DRAlA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2551; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2551;31:L8NnNfekAj3yvWfVw1/tNIq4y/hJIq8Ae5vWzoCtlVrFQmhfO6leyTjju7ewYfchftywDsAFpDOe7iVtCn2fOj4Fmri8E1KwT+W9/qBX6cMpFAxljwzmfp/Jmya8shLt1WxWx8t199AfZsEIIFp1V0X8PM61WWNZcEn7VvR75natRZrNugvbmbumolrIlvMJ23QdEKHrhbsi4J7I6EXrJyhHXX5AiI+RvnJhjz5ePT4=;4:iqGX/JbK7kGXXaddJvoz/unUu9yoIWbXDUlcWH02WnNx4nF0J4yuB7iDYzlzNxZ3ypFki9ydWEfzMLtweLSiGdrPbXAd3TCj25TvtgYTsn9q3xt/RPpbbnGqtFgXL+9O0mPqn5SGsAoj1ybZGXec8W6DLfEqGi7PJOWahzxc5UXl2Iin4/Gst/yViw0sNgzuo1gNg0xrbfg8owcwsxL4iB0sLtaFzHBpMj0EMN3uSxl00ET7pkelmOdSWVyHufPYlEi0o0R5F6sJwxCYjh/Lbh0f5G3i/7wGYInXi9KX4n4neCwzoLLYiP6UFhqoDfW0vMJ4dkb9QDvAwzcnM26Fcu0Zfk5/NsVwGR555/Kr8euctrh2z1UAg2/AcTrB1cgr7BOkY1J3vmdJjXuEk7945ElpRG26AQN+RX39zfKwmS3Ucc1lRAMG0XN8EVZ2b81Jy6sp0Oxhu4VVqYILtYmTBA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:DB6PR0802MB2551;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2551; X-Forefront-PRVS: 0022134A87 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377454003)(199003)(24454002)(189002)(2201001)(8676002)(68736007)(101416001)(77096005)(92566002)(81166006)(47776003)(50466002)(80316001)(81156014)(66066001)(59896002)(83506001)(86362001)(65956001)(33656002)(97736004)(19580395003)(105586002)(5001770100001)(106356001)(64126003)(19580405001)(23746002)(2950100001)(65806001)(3846002)(586003)(42186005)(7416002)(230700001)(4326007)(4001350100001)(305945005)(7846002)(54356999)(7736002)(36756003)(65816999)(50986999)(2906002)(76176999)(87266999)(189998001)(6116002)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0802MB2551;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0802MB2551;23:nQl2qDjIHmKutTHBVBQtL6x0WJ0s73u4RIB?= =?Windows-1252?Q?HfRwPibTAksp43FFfB7StGmQKXxMbHcFH5807BM2ZGW75gtwW8dV77xI?= =?Windows-1252?Q?dkQAZ7DVqosai5FVCxSbNwZ5sH7pLI55A4EGgnLcoMgf9yraujih5aSw?= =?Windows-1252?Q?EqTkxkCU9aoIUofKe4k4rkvmcRD6in9x21NTQ3VkennCDGFovz13JiPi?= =?Windows-1252?Q?F4ny2X2p7wWnV7AbD9+qT8YBSRaqSvGrxf3/Xs3SDkYTMLQVlW5uvLYq?= =?Windows-1252?Q?5uix3ywlpbSaOhX00thGWYaKCKVf33eGqtoeQYH3lxZcOqKr1R0kOcUU?= =?Windows-1252?Q?fb6vfZvPFhf452CP5rVRQnlYDagyASv+gWy8WaZP9nMpx8g/ipy+h7LM?= =?Windows-1252?Q?KNYLV9Hndvkpna31MoXlJoz9iHKY7WkkRgO5aB9JEx3j4zLepxsQ13UP?= =?Windows-1252?Q?Am3vo/GXr5AGxnkVDdNxKxIuuPTLefEAushE/JS7COqU5OvbPrCq/rS4?= =?Windows-1252?Q?eW8CDdmp25U0sE1BEhCumXjCj3TnW7JYluFtMHOW66kS+1lC0JaaeNbK?= =?Windows-1252?Q?ENvXLuZNE8Ns2HgyZM37ziP9MkmybkFVaBLMx+EGTZKBBgRgMa3r+Hd/?= =?Windows-1252?Q?QZOwFo4jnGBERkFZbebZrDx9NhHcqkqTbBS30eo3Kwf7YXsmnKUpJfOS?= =?Windows-1252?Q?WYdrfO1tJ7unKNtiQej1ZwV48w3McehBRFJN+JKYe1YmqA2LzvkpdpP1?= =?Windows-1252?Q?yW+zvYEDuFrR9J9gdqg7309dV0to13gCiqP7VI5t8uCuKwda1vLXTCmA?= =?Windows-1252?Q?kndXE+VPTfZ+IdHZEbEnKBbujGbwYBaPwQVg1yNuo8KWdv5NUXYDzH3x?= =?Windows-1252?Q?YimKPZlHCIxlU/EqktNrvc9It5TDe6gAuWqxxA1HAQFNDpPQadwCmVkg?= =?Windows-1252?Q?FEfJtyoJgUDdyyV8If8SpD3IxNZr5nscnN9ahWttk7IbFjTizU23DhF+?= =?Windows-1252?Q?Li/4REwOdKoyXwW6MVPwtFWFdIYoFRicNBnjDFi/JESnPd4/Awrfg+vH?= =?Windows-1252?Q?TXOFdvRl0sCw42kBXPCXNe/RZaGbc219SdddTvKmx1UWdZyiBpSzZsuf?= =?Windows-1252?Q?qYVKtWbmAB7aHGeRbhG0IqZdtWKbWeOveoEaq6JZGCjxNXzRBufBfk18?= =?Windows-1252?Q?f2DkUroqB9a9Z7i+1Vi09q3MPvH7EdNpmytzoj3sHR7i2LycPV6KpKNG?= =?Windows-1252?Q?XW9U4JxpEHBdhjVTPFPUrmyrT/lAxQGq//kzQKDuFhvCVAAwvuQmsWBy?= =?Windows-1252?Q?VubYYH9hoid5wPPiETnNsYqgeSnTPxeeJmUx3HIfmeZh9NzC23PzhYbQ?= =?Windows-1252?Q?Lbau+ctbEJdFLJpRJspdD58l67zEh54EAWdprAiAn399LhFmmU7+lEcS?= =?Windows-1252?Q?EYwX2NXYeDvtjjHPIMtyqsmP/DHWoHXaIwlH/xdsuk5RXAITyWRg65dR?= =?Windows-1252?Q?QBpcyElc=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2551;6:U6xm8iW8jh4pLJK9VKBiWkk/E+WvnsDT+5fCFbqry73dJNyAMl3P4+KTQSNSQ8U1L6mLG1lA8wGdsv2toc1Qs1mz+X4315YI+/VWtUciijrVGdr+RsgtyS34ua0KOZVXVDv/lvi3TstDaKhLumUmySICbEKyOqiX/4vsSmZwwY7OoRMOgh00kkTzgAp91xYD0saPnEVsFIDlujfh0oZAOV5256Fimgca3VkcvII+Db1MI0JOejbnFoWlAjTguFpIVxuT2ABoyADahbgijeaZaXvHTSQ+OLSZGeHHb30a8rwpOvU3JJE00sUJUrEJn743;5:xrGue4EXSD6KcUlHQer6UfOTcs2fiUtgjwaAx5M65T4ubK+tNskbloIwiBaccwbyzzCHfacdV4NYg51psZGxviHWyTbUF2glDro00y4/XuwDRMXs/pQYXNYCy28up8kIRWNwzUDyZncB5FoWhXciOA==;24:FjgMJrT/bgH2ufla//UHAyA45r2vP6I29Em5THTRlPJjPnkS1tG2G825sZCYJgCEU4aX+sNs1OirRRuH5JQ/rOVC4KyC8hBEVpsjT+Swkdg=;7:VAiTspVgTRbDNwhV/GiSyLSMCv4s1qkYFfR/BpLIfpgdBsoX65YIyJcKGJjYJjNRX6VOULeL9Y/S1T2uQz4t6CWdmhTgZWVUrWBi5sIdacmrmlu7Bii2curZ8TsA4uk//9V0xVvIZYn9yMKO0e7qEqQc5xF19QiOScnXwxAxNeZTpAhZuVvCIBXfJB0x695nz4QZBRmwsWtkEhVogecHZ6yDrrWVKZ37jWgynci6FIU1WAbIwi90Evft7K/bW05d SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2551;20:rlxV15JnkuSy3CRIY+dFB5aFjQz0HZ77mgdJs/QP4hMWfdipvFvwt4LXt+wXvZZm+BB5A9r9bXdET235ki35FLrWZezumkO4xVNTg7cxlyFWu/TQ2B5pS7QjywjaIHAy+BlcUUywQ9vPcw9ovCml8rOeO6tulQTbKpjxz6A5+tA= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2016 16:08:32.7612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2551 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2016 01:27 PM, Alexander Potapenko wrote: > If the total amount of memory assigned to quarantine is less than the > amount of memory assigned to per-cpu quarantines, |new_quarantine_size| > may overflow. Instead, set it to zero. > > Reported-by: Dmitry Vyukov > Fixes: 55834c59098d ("mm: kasan: initial memory quarantine > implementation") > Signed-off-by: Alexander Potapenko Acked-by: Andrey Ryabinin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f199.google.com (mail-io0-f199.google.com [209.85.223.199]) by kanga.kvack.org (Postfix) with ESMTP id 0DAE46B0005 for ; Tue, 2 Aug 2016 12:08:38 -0400 (EDT) Received: by mail-io0-f199.google.com with SMTP id n69so384525318ion.0 for ; Tue, 02 Aug 2016 09:08:38 -0700 (PDT) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30122.outbound.protection.outlook.com. [40.107.3.122]) by mx.google.com with ESMTPS id i22si1802655otc.179.2016.08.02.09.08.36 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 02 Aug 2016 09:08:37 -0700 (PDT) Subject: Re: [PATCH v2] kasan: avoid overflowing quarantine size on low memory systems References: <1470133620-28683-1-git-send-email-glider@google.com> From: Andrey Ryabinin Message-ID: <57A0C5C8.4030304@virtuozzo.com> Date: Tue, 2 Aug 2016 19:09:44 +0300 MIME-Version: 1.0 In-Reply-To: <1470133620-28683-1-git-send-email-glider@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Alexander Potapenko , dvyukov@google.com, kcc@google.com, adech.fo@gmail.com, cl@linux.com, akpm@linux-foundation.org, rostedt@goodmis.org, js1304@gmail.com, iamjoonsoo.kim@lge.com, kuthonuzo.luruo@hpe.com Cc: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org On 08/02/2016 01:27 PM, Alexander Potapenko wrote: > If the total amount of memory assigned to quarantine is less than the > amount of memory assigned to per-cpu quarantines, |new_quarantine_size| > may overflow. Instead, set it to zero. > > Reported-by: Dmitry Vyukov > Fixes: 55834c59098d ("mm: kasan: initial memory quarantine > implementation") > Signed-off-by: Alexander Potapenko Acked-by: Andrey Ryabinin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org