From: David Vrabel <david.vrabel@citrix.com>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>,
xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
ian.jackson@eu.citrix.com, qemu-devel@nongnu.org,
david.vrabel@citrix.com, anthony.perard@citrix.com,
roger.pau@citrix.com
Subject: Re: [PATCH v4 1/2] Interface for grant copy operation in libs.
Date: Wed, 3 Aug 2016 15:36:02 +0100 [thread overview]
Message-ID: <57A20152.6030607__9601.47767696089$1470235057$gmane$org@citrix.com> (raw)
In-Reply-To: <1470146790-6168-2-git-send-email-paulinaszubarczyk@gmail.com>
On 02/08/16 15:06, Paulina Szubarczyk wrote:
>
> +/**
> + * Copy memory from or to grant references. The information of each operations
> + * are contained in 'xengnttab_grant_copy_segment_t'. The @flag value indicate
> + * the direction of an operation (GNTCOPY_source_gref\GNTCOPY_dest_gref).
> + *
> + * The sum of fields @offset[i] and @len[i] of 'xengnttab_grant_copy_segment_t'
> + * should not exceed XEN_PAGE_SIZE
"For each segment, @virt may cross a page boundary but @offset + @len
must be less than XEN_PAGE_SIZE." might be better.
With or without the above change:
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-03 14:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 14:06 [Qemu-devel] [PATCH v4 0/2] qemu-qdisk: Implementation of grant copy operation Paulina Szubarczyk
2016-08-02 14:06 ` Paulina Szubarczyk
2016-08-02 14:06 ` [Qemu-devel] [PATCH v4 1/2] Interface for grant copy operation in libs Paulina Szubarczyk
2016-08-02 14:06 ` Paulina Szubarczyk
2016-08-03 14:36 ` David Vrabel [this message]
2016-08-03 14:36 ` [Qemu-devel] [Xen-devel] " David Vrabel
2016-08-04 9:42 ` David Vrabel
2016-08-04 9:42 ` David Vrabel
2016-08-04 9:38 ` Wei Liu
2016-08-04 9:38 ` [Qemu-devel] " Wei Liu
2016-08-04 10:27 ` Paulina Szubarczyk
2016-08-04 10:27 ` Paulina Szubarczyk
2016-08-02 14:06 ` [Qemu-devel] [PATCH v4 2/2] qdisk - hw/block/xen_disk: grant copy implementation Paulina Szubarczyk
2016-08-02 14:06 ` Paulina Szubarczyk
2016-08-08 11:11 ` [Qemu-devel] " Roger Pau Monné
2016-08-08 11:11 ` Roger Pau Monné
2016-08-08 11:34 ` [Qemu-devel] " Paulina Szubarczyk
2016-08-08 11:34 ` Paulina Szubarczyk
2016-08-08 11:44 ` Paulina Szubarczyk
2016-08-08 11:44 ` [Qemu-devel] " Paulina Szubarczyk
2016-08-09 16:56 ` Anthony PERARD
2016-08-09 16:56 ` Anthony PERARD
2016-08-09 17:34 ` [Qemu-devel] " Paulina Szubarczyk
2016-08-09 17:34 ` Paulina Szubarczyk
2016-08-10 10:29 ` [Qemu-devel] " Anthony PERARD
2016-08-10 10:29 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='57A20152.6030607__9601.47767696089$1470235057$gmane$org@citrix.com' \
--to=david.vrabel@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=paulinaszubarczyk@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.