From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=017fdc70d=david.vrabel@citrix.com>)
	id 1bVFAa-0005Af-8I
	for qemu-devel@nongnu.org; Thu, 04 Aug 2016 05:42:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=017fdc70d=david.vrabel@citrix.com>)
	id 1bVFAW-0004pI-3H
	for qemu-devel@nongnu.org; Thu, 04 Aug 2016 05:42:27 -0400
Received: from smtp.citrix.com ([66.165.176.89]:1909)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=017fdc70d=david.vrabel@citrix.com>)
	id 1bVFAV-0004oV-Ur
	for qemu-devel@nongnu.org; Thu, 04 Aug 2016 05:42:24 -0400
References: <1470146790-6168-1-git-send-email-paulinaszubarczyk@gmail.com>
	<1470146790-6168-2-git-send-email-paulinaszubarczyk@gmail.com>
	<57A20152.6030607@citrix.com>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <57A30DF6.2020802@citrix.com>
Date: Thu, 4 Aug 2016 10:42:14 +0100
MIME-Version: 1.0
In-Reply-To: <57A20152.6030607@citrix.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v4 1/2] Interface for grant
 copy operation in libs.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>, xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, qemu-devel@nongnu.org, anthony.perard@citrix.com, roger.pau@citrix.com

On 03/08/16 15:36, David Vrabel wrote:
> On 02/08/16 15:06, Paulina Szubarczyk wrote:
>>
>> +/**
>> + * Copy memory from or to grant references. The information of each operations
>> + * are contained in 'xengnttab_grant_copy_segment_t'. The @flag value indicate
>> + * the direction of an operation (GNTCOPY_source_gref\GNTCOPY_dest_gref).
>> + *
>> + * The sum of fields @offset[i] and @len[i] of 'xengnttab_grant_copy_segment_t'
>> + * should not exceed XEN_PAGE_SIZE
> 
> "For each segment, @virt may cross a page boundary but @offset + @len
> must be less than XEN_PAGE_SIZE."  might be better.

This should be:

"For each segment, @virt may cross a page boundary but @offset + @len
must not exceed XEN_PAGE_SIZE."

David