From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bViqM-00059c-Ky for qemu-devel@nongnu.org; Fri, 05 Aug 2016 13:23:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bViqJ-0000Po-9H for qemu-devel@nongnu.org; Fri, 05 Aug 2016 13:23:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bViqJ-0000PX-36 for qemu-devel@nongnu.org; Fri, 05 Aug 2016 13:23:31 -0400 References: <147041636348.2523.2954972609232949598.stgit@fimbulvetr.bsc.es> <147041637969.2523.4570342042982870131.stgit@fimbulvetr.bsc.es> From: Eric Blake Message-ID: <57A4CB91.6050405@redhat.com> Date: Fri, 5 Aug 2016 11:23:29 -0600 MIME-Version: 1.0 In-Reply-To: <147041637969.2523.4570342042982870131.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3xjaqoRelOdmL06bBilXKAJae3SL3joAb" Subject: Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= , qemu-devel@nongnu.org Cc: Riku Voipio , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3xjaqoRelOdmL06bBilXKAJae3SL3joAb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/05/2016 10:59 AM, Llu=C3=ADs Vilanova wrote: > QEMU detects when the guest uses 'mmap' on hypertrace's control channel= > file, and then uses 'mprotect' to detect accesses to it, which are used= > to trigger traceing event "guest_hypertrace". s/traceing/tracing/ I'll probably leave the technical review to others, though > +++ b/bsd-user/mmap.c > @@ -21,6 +21,7 @@ > #include "qemu.h" > #include "qemu-common.h" > #include "bsd-mman.h" > +#include "hypertrace/user.h" > =20 > //#define DEBUG_MMAP > =20 > @@ -407,6 +408,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len= , int prot, > } > } > the_end1: > + hypertrace_guest_mmap(fd, (void *)g2h(start)); Why is the cast to void* needed? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3xjaqoRelOdmL06bBilXKAJae3SL3joAb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXpMuRAAoJEKeha0olJ0NqjPQH/2RCEBWkNwf6RZTQ7NceBFXK leZM3x/4vEhBaxvEzj2rJ141InfEEiuWcC/BACXmUqaNG/SdBlO15NYnTUM5dLSh IW9wB6l4sxTBlA1iouksnTU0ZpwKqaGVNdpmAdW5uZnwdLMGH5rHttoTbm/7MNJB bzc5zb2yTlOTEPc/L9cEKlkNboPZuysDUm4/+XwENd7GcTZ5I93CiUGdSnOWEBdB dNtQkGJY3NPhv/aXbAHjFxv5JDsRhrc7gLNs4rLTny66W3kLl6FUPYL9JrIf6X3O KmQ40ZO+cndo6u+SQ0evCbPDx1+gBH+fHv6tT525pbKXuN0rF2PkXLnTAysoAzc= =o351 -----END PGP SIGNATURE----- --3xjaqoRelOdmL06bBilXKAJae3SL3joAb--