From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from prv-mh.provo.novell.com ([137.65.248.74]:50810 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbcHKMvg convert rfc822-to-8bit (ORCPT ); Thu, 11 Aug 2016 08:51:36 -0400 Message-Id: <57AC90F5020000780010515A@prv-mh.provo.novell.com> Date: Thu, 11 Aug 2016 06:51:33 -0600 From: "Jan Beulich" Subject: Re: [Xen-devel] [PATCH] Xen: remove -fshort-wchar gcc flag References: <1470910580-18458-1-git-send-email-npiggin@gmail.com> <16541778.WMH6K24aDt@wuerfel> In-Reply-To: <16541778.WMH6K24aDt@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Arnd Bergmann Cc: Stephen Rothwell , David Vrabel , Alan Modra , Nicholas Piggin , Segher Boessenkool , Nicolas Pitre , xen-devel@lists.xenproject.org, Boris Ostrovsky , Sam Ravnborg , Juergen Gross , Michal Marek , linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org >>> On 11.08.16 at 14:39, wrote: > A previous patch added the --no-wchar-size-warning to the Makefile to > avoid this harmless warning: > > arm-linux-gnueabi-ld: warning: drivers/xen/efi.o uses 2-byte wchar_t yet the > output is to use 4-byte wchar_t; use of wchar_t values across objects may > fail > > Changing kbuild to use thin archives instead of recursive linking > unfortunately brings the same warning back during the final link. > > This time, we remove the -fshort-wchar flag that originally caused > the warning, hopefully fixing the problem for good. I don't see > any reason for having the flag in the first place, as the Xen code > does not use wchar_t at all. It uses efi_char16_t, and by dropping -fshort-wchar you'd open up a trap for anyone to fall into who were to add wide string literals to that same file. EFI using 16-bit characters requires code interfacing with EFI to do so too. Jan