From: Timur Tabi <timur@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org,
shankerd@codeaurora.org, vikrams@codeaurora.org,
cov@codeaurora.org, gavidov@codeaurora.org, andrew@lunn.ch,
bjorn.andersson@linaro.org, mlangsdo@redhat.com, jcm@redhat.com,
agross@codeaurora.org, davem@davemloft.net, f.fainelli@gmail.com,
LinoSanfilippo@gmx.de, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Al Stone <al.stone@linaro.org>
Subject: Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver
Date: Mon, 15 Aug 2016 15:06:24 -0500 [thread overview]
Message-ID: <57B220C0.3060608@codeaurora.org> (raw)
In-Reply-To: <20160804175541.GA2832@rob-hp-laptop>
+ Rafael and Al, for ACPI help.
Rob Herring wrote:
>> >+Optional properties:
>> >+- phy-version : the version of the integrated emac phy, either 1 or 2.
> Sounds like 2 different h/w. The compatible property should distinguish
> this.
So I implemented this in v8 of my driver, but it is causing problems for
ACPI.
In ACPI, the equivalent to a compatible string is the HID, which is
QCOM8070 for the EMAC. The problem is that it's very difficult, if not
impossible, to create new HIDs for different versions of the same device.
The driver will primarily (if not exclusively) be used on ACPI
platforms, not DT. In Qualcomm, DT is for mobile chips, and ACPI is for
server. To my knowledge, there are no plans to use this driver on an
actual DT-enabled platform, but I want to support DT anyway.
The other problem is that the "internal PHY" of the EMAC is technically
a separate device, and it's interchangeable. Future versions of our
chips will use different internal PHYs, but the EMAC will stay the same.
So I would like a solution that works on DT and ACPI. I suppose I could
use compatible strings on DT, and a "phy-version" DSD (property) on
ACPI. If that's acceptable to everyone, then I can do that. It seems
clunky to me.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-08-15 20:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 20:12 [PATCH] [v7] net: emac: emac gigabit ethernet controller driver Timur Tabi
2016-08-04 17:55 ` Rob Herring
2016-08-04 18:18 ` Timur Tabi
2016-08-05 19:36 ` Timur Tabi
2016-08-15 20:06 ` Timur Tabi [this message]
2016-08-16 13:29 ` Rob Herring
2016-08-16 13:39 ` Timur Tabi
2016-08-16 21:20 ` Al Stone
2016-08-16 21:37 ` Timur Tabi
2016-08-17 19:25 ` Timur Tabi
[not found] ` <57B3878D.1000805-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-17 20:07 ` Florian Fainelli
2016-08-17 20:19 ` Timur Tabi
[not found] ` <57B4C6EE.3080903-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-17 22:32 ` Timur Tabi
[not found] ` <57B4E5F7.9040500-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-17 22:48 ` Florian Fainelli
2016-08-18 3:27 ` Timur Tabi
[not found] ` <57B52B17.1080809-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-18 4:04 ` Florian Fainelli
[not found] ` <5CCEFB33-8F93-40D7-BD32-ACDE1CBA586D-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-18 4:19 ` Timur Tabi
2016-08-18 16:09 ` Florian Fainelli
2016-08-18 17:56 ` Timur Tabi
[not found] ` <1470255143-3979-1-git-send-email-timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-04 23:29 ` Lino Sanfilippo
2016-08-09 18:25 ` Timur Tabi
[not found] ` <57AA2001.2010904-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-09 18:39 ` Rob Herring
2016-08-09 19:34 ` Timur Tabi
2016-08-09 19:17 ` Florian Fainelli
[not found] ` <214dcbb7-0c3b-1e00-3e50-db513d77b10b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-10 1:09 ` Timur Tabi
2016-08-10 1:25 ` Florian Fainelli
2016-08-10 16:38 ` Timur Tabi
2016-08-10 17:49 ` Florian Fainelli
2016-08-11 14:22 ` Timur Tabi
2016-08-11 15:10 ` Timur Tabi
2016-08-11 16:03 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B220C0.3060608@codeaurora.org \
--to=timur@codeaurora.org \
--cc=LinoSanfilippo@gmx.de \
--cc=agross@codeaurora.org \
--cc=al.stone@linaro.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gavidov@codeaurora.org \
--cc=jcm@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mlangsdo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=sdharia@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.