From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baHli-000200-Dt for qemu-devel@nongnu.org; Thu, 18 Aug 2016 03:29:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baHle-0000Ln-8D for qemu-devel@nongnu.org; Thu, 18 Aug 2016 03:29:37 -0400 Received: from [59.151.112.132] (port=46131 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baHld-0000Kr-PN for qemu-devel@nongnu.org; Thu, 18 Aug 2016 03:29:34 -0400 References: <1471444747-6277-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1471444747-6277-5-git-send-email-caoj.fnst@cn.fujitsu.com> <9BED61EB-EBF6-463A-A3D1-2E28C5690B64@daynix.com> From: Cao jin Message-ID: <57B565D8.2030409@cn.fujitsu.com> Date: Thu, 18 Aug 2016 15:38:00 +0800 MIME-Version: 1.0 In-Reply-To: <9BED61EB-EBF6-463A-A3D1-2E28C5690B64@daynix.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] e1000e: drop unnecessary funtions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Fleytman Cc: qemu-devel@nongnu.org, Jason Wang , Markus Armbruster , Marcel Apfelbaum , "Michael S. Tsirkin" On 08/18/2016 01:23 PM, Dmitry Fleytman wrote: > > >> On 17 Aug 2016, at 17:39, Cao jin wrote: >> >> Internal helper function: e1000e_init_msix(), e1000e_cleanup_msix() >> is unnecessary, remove them all. > > Is there any reason to drop these functions? > They exist to improve code readability and modularisation. > previous commit 66bf7d58d removed the corresponding function of msi, so, keep the consistency is the reason -- Yours Sincerely, Cao jin