From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37542)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1baNBU-0001oA-23
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 09:16:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1baNBO-00041y-OL
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 09:16:35 -0400
Received: from [59.151.112.132] (port=51471 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1baNBO-00041h-8y
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 09:16:30 -0400
References: <1471444747-6277-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<1471444747-6277-4-git-send-email-caoj.fnst@cn.fujitsu.com>
	<7b932d72-276c-912a-d1fb-85ed88e67dfa@redhat.com>
	<57B5B3FF.8010003@cn.fujitsu.com>
	<dba58549-ddfd-0270-42c9-42f2df2df182@redhat.com>
From: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-ID: <57B5B72C.8020708@cn.fujitsu.com>
Date: Thu, 18 Aug 2016 21:25:00 +0800
MIME-Version: 1.0
In-Reply-To: <dba58549-ddfd-0270-42c9-42f2df2df182@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Dmitry Fleytman <dmitry@daynix.com>, Marcel Apfelbaum <marcel@redhat.com>, Jason Wang <jasowang@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>



On 08/18/2016 09:04 PM, Paolo Bonzini wrote:
>
>
> On 18/08/2016 15:11, Cao jin wrote:
>>
>>
>> On 08/18/2016 06:47 PM, Paolo Bonzini wrote:
>>>
>>>
>>> On 17/08/2016 16:39, Cao jin wrote:
>>>> commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it
>>>> is used by intr_state which exists in vmstate. Restore it for migration
>>>> to older QEMU versions
>>>>
>>>> CC: Dmitry Fleytman <dmitry@daynix.com>
>>>> CC: Jason Wang <jasowang@redhat.com>
>>>> CC: Markus Armbruster <armbru@redhat.com>
>>>> CC: Marcel Apfelbaum <marcel@redhat.com>
>>>> CC: Michael S. Tsirkin <mst@redhat.com>
>>>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>>>
>>> Not necessary.  No released version of QEMU had e1000e and lacked commit
>>> 66bf7d58.
>>>
>>> Paolo
>>>
>>
>> Ok, then I will make this patch as separated one and send it out asap,
>> so maybe it goes in 2.7
>
> It's not necessary at all; why would it be useful in 2.7?
>
> Paolo
>

commit 66bf7d58I already removed E1000E_USE_MSI, so I think maybe I can 
send a patch to remove E1000E_USE_MSIX & intr_state, so there will be no 
migration compatibility issue