From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932930AbcHXSkQ (ORCPT ); Wed, 24 Aug 2016 14:40:16 -0400 Received: from mail-dm3nam03on0123.outbound.protection.outlook.com ([104.47.41.123]:27136 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754192AbcHXSjz (ORCPT ); Wed, 24 Aug 2016 14:39:55 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=waiman.long@hpe.com; Message-ID: <57BDE9CF.5030801@hpe.com> Date: Wed, 24 Aug 2016 14:39:11 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Davidlohr Bueso CC: Peter Zijlstra , Ingo Molnar , , , , , , , , Jason Low , Dave Chinner , Jonathan Corbet , Scott J Norton , Douglas Hatch Subject: Re: [RFC PATCH-tip v4 10/10] locking/rwsem: Add a boot parameter to reader spinning threshold References: <1471554672-38662-1-git-send-email-Waiman.Long@hpe.com> <1471554672-38662-11-git-send-email-Waiman.Long@hpe.com> <20160824040007.GA17186@linux-80c1.suse> In-Reply-To: <20160824040007.GA17186@linux-80c1.suse> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.96] X-ClientProxiedBy: BLUPR05CA0076.namprd05.prod.outlook.com (10.141.20.46) To CS1PR84MB0309.NAMPRD84.PROD.OUTLOOK.COM (10.162.189.158) X-MS-Office365-Filtering-Correlation-Id: bbc53085-ac39-4024-c2c7-08d3cc4df4cb X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0309;2:7kdz/MRHTMgct/cP4TIgMiVc7r2y/R90SIXMDyV3mK2yMOPyGMy25XOhXL9hzVAsBnV278yYn6YYO5ZetXjs7kEqgZZoVh1Z1JzgED9pAjoh3Pt/OtcOWM1w0xaZsfRf8i1gQWLzplCZk4rrB9L0ws91YQg+L0TPmqeJ0NsQAPLVyuP97gBA+9LmXeFGPDGB;3:vlMJkGEhyw16LZ/zZ/NgXbdlZrjSBXjinHQXaZsW+URf1VJjwQrZvuZwpXskqohKSPFm9+jjcTD8qOvm5B6WqP+9T+F0iKIC0F+gVltB911etPBgcTtwpKLfOPSbt5ZR;25:rNdTDkFxnL5euEzmKYclr2Y5xEUYVXGe+4NMGdCEb4rlQGELi2YNYtQIQVPbOeMW2qkthzXzVZZLQf8AOVfceq2BoyIYP5M90Sy3R2GiZHthyHE8n8W5gWAbudKZRityWZYjjibzJclFsIySzmzkQDGJ0aFTvVedrslUsax6jrfpgYNOs/MhCF75LmjTfHqB/Ls4mL/H+4cKW9X0uR/6x6oYmqd+BQ/VIUyPdnyNPHXdlc4DKD4Ved11UN159y41qbztKnJy9xxQjQ79RSjRd8IzVAqayCfg7ui/mQd2X2kA8AMJEmaFszIM/55Oln7iuANUzyzXNUJNTVJ/w39/3bf/HjUQ1aeYBbykvxqUiKPm+aXeCEdGGTPZarBrfZ0SOohhWKSt0S5O9vVbF8eKzchLWKTL8Ng2a5FWJzoPz0E= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0309; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0309;31:+HkKWiz+ThThftijCu+qPeayUzrFfLs8XVr61pDMZARsm4nwF77mFCiT4dhJkkqLDsrparHE1Tq859Gy+EcRnMNogHmMTWoQXrOMwqZydFgqrc6ng/iDH5Q8nZJLiEPaTFjcoMuKpuy3kCdEDXG+XpVk6ucsR4jPxgFF+t+0xKK1AJDblN1FjJUJEjfmnNMjqrLVlsBxndA/x5jZTzk2DG6S5GhtK7SKq2yNeuzdbzE=;20:aq48cM1tTNzggiHoiefuwZlxlfb2qs+1OI5i3XJRTQoi65DA/wiWwYeh9YABG3nB4Gb+vrMNDjvTnFgGHyWQInmGs6wm6E/E+NftvGyDbZByTQFqjUJ3N+GiGX8K8iACJAxFl8/1G/ZKjsAskgn1ZB7RAN0g0q1w26ARS7oyu5nqUEhFgecqeJdkVwd2l4ze3dg6D/YAzNbCqFugKT+YOVpdyuFJAlJOacrwjEJ6p2zbS4BEa+KQJ8a1WpROShJYCfsSN0EF4YJsaNGR0d9wVcCx7Uzj5yVR84w6dcY0wynIYApL7iNsrwqeFEE99EOWkqj5H9bMEhVDgNz4ii4wzgZkMK+uxLEY2Nvdsh5ntHKbrge+BKKViJKwBGDYDfpzci77TFE8y1kzU6wz6EWsK3MC21rfZN5fg+SxDyxXshda07nekKjnUOgLGdS6y2IIViI1urREBUeU/BWS1CMZ/Qe47qzP+xKIsNjEnQsDQMIIxoCHXZtAMJKyTPO4UMkQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:CS1PR84MB0309;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0309; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0309;4:QvSiomqxcVY57TRsieO2eBFGc5fAP9uYhWWl6CmjD2IYQpNx6lG2cE6y6wJVkVZV1OjAJnDDFnsgniczt2uta8PKzYV+jw8/ZOBM7AybVvdhSvVhAs/LM6lfJ/Bpe9EeJjgd35W/vUjTL6H5ZYGIVcFxtJ0Os/hry3HvhWHMOwNFBkxweHXH0n78u8sS0sgg04a9uuHh/UlnyH51+AlrT3x7pI8/6LPUoYQwaBxMxY4kZrGlZa2NYxcBW8BSBWuYgrdMZum4hnHhxfZeGg8mPc0ewZMmwOJRNuoQ7DtsVKP39hQkiqa0k8zqXtAb0VrZWp3/A67hL+1AG/3ID/GDosHA6NO3SO3shWt8Iu3pmcXuyjhY8p8zxgejmbwwgZ++NKtDNkFGKXHa0VgKDifZ4Q== X-Forefront-PRVS: 0044C17179 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(199003)(24454002)(189002)(377454003)(7736002)(3846002)(101416001)(7846002)(86362001)(8666005)(36756003)(50986999)(80316001)(76176999)(54356999)(87266999)(42186005)(65816999)(33656002)(305945005)(83506001)(6116002)(47776003)(77096005)(4001350100001)(50466002)(66066001)(65806001)(65956001)(2950100001)(117156001)(97736004)(5660300001)(7416002)(68736007)(23756003)(586003)(4326007)(81156014)(81166006)(59896002)(64126003)(2906002)(92566002)(230700001)(8676002)(110136002)(105586002)(189998001)(106356001)(7059030);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0309;H:[192.168.142.191];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CS1PR84MB0309;23:gUSkBBgI1jqOXClWDKlXdH+Mvoq0grto1wTbgXm?= =?iso-8859-1?Q?0Zn2/y0Y6yQnTN/DDoP1o9+u20YyGZ7mImTpbKeuJk7J6CmpwPgKyYrls/?= =?iso-8859-1?Q?QjAPg9TYU0CI0BNtiLx/FcH/xBGuDzhVo3KUMVZ+g0KDSd4DbGq3IVK54E?= =?iso-8859-1?Q?rFoHv7bJ8GCm64QV8Z/NxckPJA1/2w9do5rgNdyegPjv12gxjj3LcwUJiC?= =?iso-8859-1?Q?Papl30rJp8/JPT3PLPkraJmIbiApf2A/57YjjaT1fm3OUxHeMkEIU299Mb?= =?iso-8859-1?Q?IDAkPFdG2oV5cdwmhsBcIGFa2/Bbm2n8QBKgkZe5zAzgB4TZHZEPJcH7lP?= =?iso-8859-1?Q?Gllxa5+UxdUN2NelZwN89JgaYmX2zkrhaO2Ojg7+4+5ptYDTg6GAzP2XKo?= =?iso-8859-1?Q?my5Bvq3giubWEjYitqTi5q0wuE4cS33ESEvgNyng+iJL5NbUkg5Ek3Hoo7?= =?iso-8859-1?Q?NOmzolkIAZWf+npC2Elh5/eRVfnekDiC0M1+pUYg4P9xR+0/GWyJ9MC4+n?= =?iso-8859-1?Q?629ELlLIv0nyFwNQBnw7XQfKX0y9pbvovRO1LMwYiBg5vIU9Z/WTHzpz9a?= =?iso-8859-1?Q?gWdr46YjE7zGpSj1o0pqgcQmqOY8PzSrQ8u3Wjwa6Wy3/sBXeaOSxVhYhs?= =?iso-8859-1?Q?LlQeLMhIh5BP1BcT6WNjTS1NtknUhU3IbkVtGa/Y0Ux5qoMSID7zwJgYRO?= =?iso-8859-1?Q?FfrTdNtzkdFN6/Avv+rhQA3mQ2ErTNHUHD5G+EZ3up4QCN21yMXveu+NMS?= =?iso-8859-1?Q?95/+agNK/M30kcxuVrgQoccaNjmXZZ3orMRJmOSw92cSNpSHXq289hJBg6?= =?iso-8859-1?Q?DqGKw/r26zdeQeGqZ0RKjTHtqOOsFr+czRgYA/b2trKCGrcAfZsvuPFcKb?= =?iso-8859-1?Q?ilAROBAZ0sHHbywGugzhIK3wuao4jdh6AknwB2gh/FxPyvoP80QDQA3RRE?= =?iso-8859-1?Q?voj3YXO+Gbws9HDIfwnKSIIlRYx7WS0INqq+aYcxJ0aQhXcZHrHC2YsuY2?= =?iso-8859-1?Q?TFX/DKNBBzHbRbV6wrkdQ9m/649VhV5hFdNap9ScDS5lxYLW5QPeNDF++N?= =?iso-8859-1?Q?7SKUjED8t7yvemQci8ZWHaVYQZdvzO/mFXPnTcd0On+fClAVmQtU0Vwn11?= =?iso-8859-1?Q?65KE1BYeCUl/D7iP2BETcFL4FPmDJEsk1AabeBC9ZCE1HxwZ/sgK9o1gbU?= =?iso-8859-1?Q?6IB7PybiLN3S9TVKG2wCsebBT5SiyRppTqYwXlBRV6QhJ1cnIpsWHOGc+a?= =?iso-8859-1?Q?VCFRatfKqB/UCJ5dgsgjtum+BAg4oPsxguHfZbeCQS7iqWA/ePVRLJlMzb?= =?iso-8859-1?Q?VR0dqhta8dqdx3FnRMyAZCPPlL2QBi2pvMMB6n7IW6RvuQ1KKv+JVAdv5y?= =?iso-8859-1?Q?vlBgMWGFGfK1f8Fb4wWzR6LRpPU8u?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0309;6:Tf7fyXKXoi/HD4x/VZRTLFh+nyVIcbQCbkgLnt7rUtS+S9C/AiChcWxcyrup6KkAaMOx12W/M/JKQUgHx/NL2wPNUYr5+Zm5fcNRNPW/D1082A77V6kXBRpVugCK5fv2oTnD9GsMYCoeii2Q0ltKVdmETA9ClcTAXF6i0ciIMMS4ztvy2Gb5N6BgOHqNi8+Kp8Q6ftlLrA4zSRC4xg5zqxZMD0mK1KEWltdm2Gb0J4I62Z/9F3iwtYPKd7TN/iXXwxMbLDDLYw9QObdAKBmPlr1zdLslIr5KSDORWlJzSfZD8YkiMc7OabslBKjGDv8C9jEuzDuVJmpkrdrP/IkR8w==;5:F/TBHwXW+ydj3WcRUxCTHbZGKqo/M1UQAclXjKHm1Orc+rRqLnpX6nEKHAObD2cgtewdgv7G6lmeFhNSV4kuEPijegpkdN6LCUJVbLkg3dGeRIr+TNPkCroZ1eFPBmRjQpSK4+K1YTBGOaZdmfYitg==;24:OUkZzikC8a8efRFDudlQT2lU7jJZe8vURknGqHa2yBP8Lfub+TXoqBSrbgRPgpG1hKjQN1l06O6GgCMyXvzrJtj3p2bvT4AwA1Z3qLQAzYE=;7:gIr7DqLOy2fHT/+UsOYLvwK0pH8CrowYTXGUD0vdLUnKI1SxllFUuzbc0mW4ekDkYD9bGmtM0S4l+GdeXtSFR94Z0Wagqlq8U2x4moPtTjBlL/LVRcOkjK1CYW/S3ZBUHgKN3J7zKr1o1C6XkoxlEDeR1/HeP55Xp4a1GGLYsCWi+UfPshm9bF+ysahJllfxb0QANxgN8JmTPlL4XefOzwtQLQZwsTgdvd+I1HddnWLmz92LmoW0kQvgP/4VqYMy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2016 18:39:16.6531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0309 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2016 12:00 AM, Davidlohr Bueso wrote: > On Thu, 18 Aug 2016, Waiman Long wrote: > >> The default reader spining threshold is current set to 4096. However, >> the right reader spinning threshold may vary from one system to >> another and among the different architectures. This patch adds a new >> kernel boot parameter to modify the threshold value. This enables >> better tailoring to the needs of different systems as well as for >> testing purposes. > > It also means that those systems could very easily be incorrectly > tailored. > (and worse case scenario: reboot, is obviously a terrible way to get rid > of any issues). I very much disagree with exposing this sort of core > stuff, > it should work well for everyone out of the box, not relying on users to > properly configure this. > > Thanks, > Davidlohr I also have some concern about exposing this kernel parameter as it will be hard to tune. That is why I put it at the end to gauge the opinion of others. I will leave this out when I send out the next version. Cheers, Longman From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [RFC PATCH-tip v4 10/10] locking/rwsem: Add a boot parameter to reader spinning threshold Date: Wed, 24 Aug 2016 14:39:11 -0400 Message-ID: <57BDE9CF.5030801@hpe.com> References: <1471554672-38662-1-git-send-email-Waiman.Long@hpe.com> <1471554672-38662-11-git-send-email-Waiman.Long@hpe.com> <20160824040007.GA17186@linux-80c1.suse> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160824040007.GA17186@linux-80c1.suse> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Davidlohr Bueso Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, Jason Low , Dave Chinner , Jonathan Corbet , Scott J Norton , Douglas Hatch List-ID: On 08/24/2016 12:00 AM, Davidlohr Bueso wrote: > On Thu, 18 Aug 2016, Waiman Long wrote: > >> The default reader spining threshold is current set to 4096. However, >> the right reader spinning threshold may vary from one system to >> another and among the different architectures. This patch adds a new >> kernel boot parameter to modify the threshold value. This enables >> better tailoring to the needs of different systems as well as for >> testing purposes. > > It also means that those systems could very easily be incorrectly > tailored. > (and worse case scenario: reboot, is obviously a terrible way to get rid > of any issues). I very much disagree with exposing this sort of core > stuff, > it should work well for everyone out of the box, not relying on users to > properly configure this. > > Thanks, > Davidlohr I also have some concern about exposing this kernel parameter as it will be hard to tune. That is why I put it at the end to gauge the opinion of others. I will leave this out when I send out the next version. Cheers, Longman From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Date: Wed, 24 Aug 2016 18:39:11 +0000 Subject: Re: [RFC PATCH-tip v4 10/10] locking/rwsem: Add a boot parameter to reader spinning threshold Message-Id: <57BDE9CF.5030801@hpe.com> List-Id: References: <1471554672-38662-1-git-send-email-Waiman.Long@hpe.com> <1471554672-38662-11-git-send-email-Waiman.Long@hpe.com> <20160824040007.GA17186@linux-80c1.suse> In-Reply-To: <20160824040007.GA17186@linux-80c1.suse> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Davidlohr Bueso Cc: Peter Zijlstra , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, Jason Low , Dave Chinner , Jonathan Corbet , Scott J Norton , Douglas Hatch On 08/24/2016 12:00 AM, Davidlohr Bueso wrote: > On Thu, 18 Aug 2016, Waiman Long wrote: > >> The default reader spining threshold is current set to 4096. However, >> the right reader spinning threshold may vary from one system to >> another and among the different architectures. This patch adds a new >> kernel boot parameter to modify the threshold value. This enables >> better tailoring to the needs of different systems as well as for >> testing purposes. > > It also means that those systems could very easily be incorrectly > tailored. > (and worse case scenario: reboot, is obviously a terrible way to get rid > of any issues). I very much disagree with exposing this sort of core > stuff, > it should work well for everyone out of the box, not relying on users to > properly configure this. > > Thanks, > Davidlohr I also have some concern about exposing this kernel parameter as it will be hard to tune. That is why I put it at the end to gauge the opinion of others. I will leave this out when I send out the next version. Cheers, Longman