From: Yisen Zhuang <Yisen.zhuang@huawei.com>
To: Colin King <colin.king@canonical.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S . Miller" <davem@davemloft.net>,
Lisheng <lisheng011@huawei.com>, <netdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is non-null
Date: Fri, 26 Aug 2016 08:42:05 +0800 [thread overview]
Message-ID: <57BF905D.6050304@huawei.com> (raw)
In-Reply-To: <20160825065110.10104-1-colin.king@canonical.com>
在 2016/8/25 14:51, Colin King 写道:
> From: Colin Ian King <colin.king@canonical.com>
>
> ppe_cb->ppe_common_cb is being dereferenced before a null check is
> being made on it. If ppe_cb->ppe_common_cb is null then we end up
> with a null pointer dereference when assigning dsaf_dev. Fix this
> by moving the initialisation of dsaf_dev once we know
> ppe_cb->ppe_common_cb is OK to dereference.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Yisen Zhuang <yisen.zhuang@huawei.com>
next prev parent reply other threads:[~2016-08-26 0:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 6:51 [PATCH] net: hns: dereference ppe_cb->ppe_common_cb if it is non-null Colin King
2016-08-26 0:42 ` Yisen Zhuang [this message]
2016-08-26 18:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57BF905D.6050304@huawei.com \
--to=yisen.zhuang@huawei.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.