From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755471AbcH1Mhr (ORCPT ); Sun, 28 Aug 2016 08:37:47 -0400 Received: from mx01-fr.bfs.de ([193.174.231.67]:49695 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755271AbcH1Mhp (ORCPT ); Sun, 28 Aug 2016 08:37:45 -0400 Message-ID: <57C2DB15.3050103@bfs.de> Date: Sun, 28 Aug 2016 14:37:41 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Mikko Rapeli CC: linux-kernel@vger.kernel.org, linux-hams@vger.kernel.org Subject: Re: [PATCH v05 69/72] uapi rose.h: glibc netrose/rose.h header file compatibility fixes References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-70-git-send-email-mikko.rapeli@iki.fi> <57C06258.8000807@bfs.de> <20160828055918.GZ5399@lakka.kapsi.fi> In-Reply-To: <20160828055918.GZ5399@lakka.kapsi.fi> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 28.08.2016 07:59, schrieb Mikko Rapeli: > On Fri, Aug 26, 2016 at 05:38:00PM +0200, walter harms wrote: >> perhaps this not tested snipped would make sure that >> you have included linux/rose.h ? >> >> #ifndef ROSE_KERNEL_H >> #include >> #endif >> >> #include > > Sorry, I did not quite get this. > > has conflicting definitions with glibc . > The patches fixes the uapi headers so that it hides > definitions if from glibc was already included. > > -Mikko no problem, so far i understand the conflict arise because you need to include linux/rose.h before netrose/rose.h My suggestion was to add a check for linux/rose.h (ROSE_KERNEL_H) and include it if not already done. (basicly this should work out of the box but it seems a problem here). I have no idea if you need to cover other cases but in my understanding userspace programms should not include kernel headers. re, wh