From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758770AbcHaCsD (ORCPT ); Tue, 30 Aug 2016 22:48:03 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:29386 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757173AbcHaCsB (ORCPT ); Tue, 30 Aug 2016 22:48:01 -0400 Subject: Re: [PATCH v7 14/14] Documentation: remove the constraint on the distances of node pairs To: Will Deacon References: <1472024693-12912-1-git-send-email-thunder.leizhen@huawei.com> <1472024693-12912-15-git-send-email-thunder.leizhen@huawei.com> <20160826153550.GI30302@arm.com> <57C16F17.5070609@huawei.com> <20160830175517.GM24906@arm.com> CC: Catalin Marinas , linux-arm-kernel , linux-kernel , Rob Herring , "Frank Rowand" , devicetree , Zefan Li , Xinwei Hu , Tianhong Ding , Hanjun Guo From: "Leizhen (ThunderTown)" Message-ID: <57C64506.4070605@huawei.com> Date: Wed, 31 Aug 2016 10:46:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160830175517.GM24906@arm.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.23.164] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.57C64511.0162,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 6b5381690cf63aeb17d0009cd124f99f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/8/31 1:55, Will Deacon wrote: > On Sat, Aug 27, 2016 at 06:44:39PM +0800, Leizhen (ThunderTown) wrote: >> >> >> On 2016/8/26 23:35, Will Deacon wrote: >>> On Wed, Aug 24, 2016 at 03:44:53PM +0800, Zhen Lei wrote: >>>> Update documentation. This limit is unneccessary. >>>> >>>> Signed-off-by: Zhen Lei >>>> Acked-by: Rob Herring >>>> --- >>>> Documentation/devicetree/bindings/numa.txt | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt >>>> index 21b3505..c0ea4a7 100644 >>>> --- a/Documentation/devicetree/bindings/numa.txt >>>> +++ b/Documentation/devicetree/bindings/numa.txt >>>> @@ -48,7 +48,6 @@ distance (memory latency) between all numa nodes. >>>> >>>> Note: >>>> 1. Each entry represents distance from first node to second node. >>>> - The distances are equal in either direction. >>> >>> Hmm, so what happens now if firmware provides a description where both >>> distances (in either direction) are supplied, but are different? >> I have not known any hardware that the distances of two direction are >> different yet > > Then let's not add support for this just yet. When we have systems that > actually need it, we'll be in a much better position to assess the > suitability of any patches. At the moment, the whole thing is pretty > questionable and it adds needless complication to the code. How about I changed to: To simplify the configuration, the distance of the opposite direction is the same to it by default. > > Will > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Leizhen (ThunderTown)" Subject: Re: [PATCH v7 14/14] Documentation: remove the constraint on the distances of node pairs Date: Wed, 31 Aug 2016 10:46:30 +0800 Message-ID: <57C64506.4070605@huawei.com> References: <1472024693-12912-1-git-send-email-thunder.leizhen@huawei.com> <1472024693-12912-15-git-send-email-thunder.leizhen@huawei.com> <20160826153550.GI30302@arm.com> <57C16F17.5070609@huawei.com> <20160830175517.GM24906@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160830175517.GM24906-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Will Deacon Cc: Catalin Marinas , linux-arm-kernel , linux-kernel , Rob Herring , Frank Rowand , devicetree , Zefan Li , Xinwei Hu , Tianhong Ding , Hanjun Guo List-Id: devicetree@vger.kernel.org On 2016/8/31 1:55, Will Deacon wrote: > On Sat, Aug 27, 2016 at 06:44:39PM +0800, Leizhen (ThunderTown) wrote: >> >> >> On 2016/8/26 23:35, Will Deacon wrote: >>> On Wed, Aug 24, 2016 at 03:44:53PM +0800, Zhen Lei wrote: >>>> Update documentation. This limit is unneccessary. >>>> >>>> Signed-off-by: Zhen Lei >>>> Acked-by: Rob Herring >>>> --- >>>> Documentation/devicetree/bindings/numa.txt | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt >>>> index 21b3505..c0ea4a7 100644 >>>> --- a/Documentation/devicetree/bindings/numa.txt >>>> +++ b/Documentation/devicetree/bindings/numa.txt >>>> @@ -48,7 +48,6 @@ distance (memory latency) between all numa nodes. >>>> >>>> Note: >>>> 1. Each entry represents distance from first node to second node. >>>> - The distances are equal in either direction. >>> >>> Hmm, so what happens now if firmware provides a description where both >>> distances (in either direction) are supplied, but are different? >> I have not known any hardware that the distances of two direction are >> different yet > > Then let's not add support for this just yet. When we have systems that > actually need it, we'll be in a much better position to assess the > suitability of any patches. At the moment, the whole thing is pretty > questionable and it adds needless complication to the code. How about I changed to: To simplify the configuration, the distance of the opposite direction is the same to it by default. > > Will > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: thunder.leizhen@huawei.com (Leizhen (ThunderTown)) Date: Wed, 31 Aug 2016 10:46:30 +0800 Subject: [PATCH v7 14/14] Documentation: remove the constraint on the distances of node pairs In-Reply-To: <20160830175517.GM24906@arm.com> References: <1472024693-12912-1-git-send-email-thunder.leizhen@huawei.com> <1472024693-12912-15-git-send-email-thunder.leizhen@huawei.com> <20160826153550.GI30302@arm.com> <57C16F17.5070609@huawei.com> <20160830175517.GM24906@arm.com> Message-ID: <57C64506.4070605@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/8/31 1:55, Will Deacon wrote: > On Sat, Aug 27, 2016 at 06:44:39PM +0800, Leizhen (ThunderTown) wrote: >> >> >> On 2016/8/26 23:35, Will Deacon wrote: >>> On Wed, Aug 24, 2016 at 03:44:53PM +0800, Zhen Lei wrote: >>>> Update documentation. This limit is unneccessary. >>>> >>>> Signed-off-by: Zhen Lei >>>> Acked-by: Rob Herring >>>> --- >>>> Documentation/devicetree/bindings/numa.txt | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/numa.txt b/Documentation/devicetree/bindings/numa.txt >>>> index 21b3505..c0ea4a7 100644 >>>> --- a/Documentation/devicetree/bindings/numa.txt >>>> +++ b/Documentation/devicetree/bindings/numa.txt >>>> @@ -48,7 +48,6 @@ distance (memory latency) between all numa nodes. >>>> >>>> Note: >>>> 1. Each entry represents distance from first node to second node. >>>> - The distances are equal in either direction. >>> >>> Hmm, so what happens now if firmware provides a description where both >>> distances (in either direction) are supplied, but are different? >> I have not known any hardware that the distances of two direction are >> different yet > > Then let's not add support for this just yet. When we have systems that > actually need it, we'll be in a much better position to assess the > suitability of any patches. At the moment, the whole thing is pretty > questionable and it adds needless complication to the code. How about I changed to: To simplify the configuration, the distance of the opposite direction is the same to it by default. > > Will > > . >