From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752711AbcIBIvX (ORCPT ); Fri, 2 Sep 2016 04:51:23 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:39366 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752206AbcIBIvR (ORCPT ); Fri, 2 Sep 2016 04:51:17 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79286d000007a9a-52-57c93d6f7f07 Content-transfer-encoding: 8BIT Message-id: <57C93D6E.8090600@samsung.com> Date: Fri, 02 Sep 2016 17:50:54 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lin Huang , heiko@sntech.de Cc: myungjoo.ham@samsung.com, mark.yao@rock-chips.com, airlied@linux.ie, mturquette@baylibre.com, dbasehore@chromium.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, kyungmin.park@samsung.com, linux-arm-kernel@lists.infradead.org, tixy@linaro.org, typ@rock-chips.com, sudeep.holla@arm.com, mark.rutland@arm.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/5] Documentation: bindings: add dt documentation for dfi controller References: <1472769085-20715-1-git-send-email-hl@rock-chips.com> <1472769085-20715-2-git-send-email-hl@rock-chips.com> In-reply-to: <1472769085-20715-2-git-send-email-hl@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAKsWRmVeSWpSXmKPExsWyRsSkUDff9mS4wYKvqha9504yWbzavIfN Yv6Rc6wWZ5cdZLO48vU9m8X/R69ZLX5sOMVscbbpDbvFpsfXWC0u75rDZvG59wijxacH/5kt ll6/yGSxY8oBJouLp1wtbjeuYLP4caabxWL5qR0sFgvn32e3mL26zkHEY828NYwe72+0snvM brjI4nG5r5fJ4861PWwe2789YPW4332cyWPzknqPv7P2s3j0bVnF6LH92jxmj8+b5AJ4orhs UlJzMstSi/TtErgytrbuYy+YwFexbdVp5gbGGdxdjJwcEgImEh9+NbJA2GISF+6tZ+ti5OIQ EljBKPHnzUM2mKI9EyZAJWYxSuyec4MVJMErICjxY/I9oG4ODmYBeYkjl7JBwswC6hKT5i1i hqh/wCjxoOcnC0S9lsTuq7vAelkEVCV6u96zg9hsQPH9L26ALeMXUJS4+uMxI8hMUYEIie4T lSBhEQEjibNf5jOBzGQWuMMsMfvGfkaQhLBAtMTKhnuMEMvOMkrsvT4ZbCingJPEpN8n2UES EgJfOCRap3+C2iwg8W3yIbCrJQRkJTYdYIb4UlLi4IobLBMYxWch+W0Wwm+zkPy2gJF5FaNo akFyQXFSepGhXnFibnFpXrpecn7uJkZgQjn971nvDsbbB6wPMQpwMCrx8D6wOhkuxJpYVlyZ e4jRFOiIicxSosn5wLSVVxJvaGxmZGFqYmpsZG5ppiTOqyj1M1hIID2xJDU7NbUgtSi+qDQn tfgQIxMHp1QD4wn9pFuqC1475/tuUMr+H370aNbZqRsvxLEuienwa15+Z9un9du+nePcwH1m 2bOAKBf9FXavsu0e3ciMNTddm8R+9qKVjvZMtt5p56I+WZwTZVJUsz/icbpLfolU+lrXmOuV O+cFXL6YZCS0tkLv2wOdiFjeBMHT8yPvBBRqsYVOmKfA826upBJLcUaioRZzUXEiAKogIPUj AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLKsWRmVeSWpSXmKPExsVy+t9jQd1825PhBmtnyFn0njvJZPFq8x42 i/lHzrFanF12kM3iytf3bBb/H71mtfix4RSzxdmmN+wWmx5fY7W4vGsOm8Xn3iOMFp8e/Ge2 WHr9IpPFjikHmCwunnK1uN24gs3ix5luFovlp3awWCycf5/dYvbqOgcRjzXz1jB6vL/Ryu4x u+Eii8flvl4mjzvX9rB5bP/2gNXjfvdxJo/NS+o9/s7az+LRt2UVo8f2a/OYPT5vkgvgiWpg tMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBelRJoSwx pxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmLG1dR97wQS+im2rTjM3MM7g7mLk 5JAQMJHYM2ECG4QtJnHh3nogm4tDSGAWo8TuOTdYQRK8AoISPybfY+li5OBgFpCXOHIpGyTM LKAuMWneImaI+geMEg96frJA1GtJ7L66C6yXRUBVorfrPTuIzQYU3//iBtgyfgFFias/HjOC zBQViJDoPlEJEhYRMJI4+2U+E8hMZoE7zBKzb+xnBEkIC0RLrGy4xwix7CyjxN7rk8GGcgo4 SUz6fZJ9AqPgLCS3zkK4dRaSWxcwMq9ilEgtSC4oTkrPNcxLLdcrTswtLs1L10vOz93ECE5a z6R2MB7c5X6IUYCDUYmH94HVyXAh1sSy4srcQ4wSHMxKIry95kAh3pTEyqrUovz4otKc1OJD jKZAz05klhJNzgcm1LySeENjEzMjSyNzQwsjY3Mlcd7H/9eFCQmkJ5akZqemFqQWwfQxcXBK NTD6SCy/KakfGGlqb7l6t0X3KZlZzE4qX5anbJ/kcHuBq5bNfg3X/fOYeJ1lWY7GB736vJZh QXHyzBPiL77c7637Z+L9u+7Muq+v0//8n7+75Y3C0cr39/V9P36U8Pgm5X7iGpvdw4lvqxx3 3epZv2Sx+JltBl+mp8Zr72o3MLXaa2fmyLRvsoSrEktxRqKhFnNRcSIA7BZbu3ADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 09월 02일 07:31, Lin Huang wrote: > This patch adds the documentation for rockchip dfi devfreq-event driver. > > Signed-off-by: Lin Huang > --- > Changes in v8: > - delete a unuse blank line > > Changes in v7: > - None > > Changes in v6: > - None > > Changes in v5: > - None > > Changes in v4: > - None > > Changes in v3: > - None > > Changes in v2: > - None > > Changes in v1: > - None > > .../bindings/devfreq/event/rockchip-dfi.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > new file mode 100644 > index 0000000..d66aca6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > @@ -0,0 +1,19 @@ > + > +* Rockchip rk3399 DFI device > + > +Required properties: > +- compatible: Must be "rockchip,rk3399-dfi". > +- reg: physical base address of each DFI and length of memory mapped region > +- rockchip,pmu: phandle to the syscon managing the "pmu general register files" > +- clocks: phandles for clock specified in "clock-names" property > +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; > + > +Example: > + dfi: dfi@0xff630000 { > + reg = <0x00 0xff630000 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; As I already commented, you need to reorder between compatible and reg property. > + rockchip,pmu = <&pmugrf>; > + clocks = <&cru PCLK_DDR_MON>; > + clock-names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > -- Best Regards, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 1/5] Documentation: bindings: add dt documentation for dfi controller Date: Fri, 02 Sep 2016 17:50:54 +0900 Message-ID: <57C93D6E.8090600@samsung.com> References: <1472769085-20715-1-git-send-email-hl@rock-chips.com> <1472769085-20715-2-git-send-email-hl@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-reply-to: <1472769085-20715-2-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lin Huang , heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org Cc: myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, typ-TNX95d0MmH7DzftRWevZcw@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 2016년 09월 02일 07:31, Lin Huang wrote: > This patch adds the documentation for rockchip dfi devfreq-event driver. > > Signed-off-by: Lin Huang > --- > Changes in v8: > - delete a unuse blank line > > Changes in v7: > - None > > Changes in v6: > - None > > Changes in v5: > - None > > Changes in v4: > - None > > Changes in v3: > - None > > Changes in v2: > - None > > Changes in v1: > - None > > .../bindings/devfreq/event/rockchip-dfi.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > new file mode 100644 > index 0000000..d66aca6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > @@ -0,0 +1,19 @@ > + > +* Rockchip rk3399 DFI device > + > +Required properties: > +- compatible: Must be "rockchip,rk3399-dfi". > +- reg: physical base address of each DFI and length of memory mapped region > +- rockchip,pmu: phandle to the syscon managing the "pmu general register files" > +- clocks: phandles for clock specified in "clock-names" property > +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; > + > +Example: > + dfi: dfi@0xff630000 { > + reg = <0x00 0xff630000 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; As I already commented, you need to reorder between compatible and reg property. > + rockchip,pmu = <&pmugrf>; > + clocks = <&cru PCLK_DDR_MON>; > + clock-names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > -- Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Fri, 02 Sep 2016 17:50:54 +0900 Subject: [PATCH 1/5] Documentation: bindings: add dt documentation for dfi controller In-Reply-To: <1472769085-20715-2-git-send-email-hl@rock-chips.com> References: <1472769085-20715-1-git-send-email-hl@rock-chips.com> <1472769085-20715-2-git-send-email-hl@rock-chips.com> Message-ID: <57C93D6E.8090600@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016? 09? 02? 07:31, Lin Huang wrote: > This patch adds the documentation for rockchip dfi devfreq-event driver. > > Signed-off-by: Lin Huang > --- > Changes in v8: > - delete a unuse blank line > > Changes in v7: > - None > > Changes in v6: > - None > > Changes in v5: > - None > > Changes in v4: > - None > > Changes in v3: > - None > > Changes in v2: > - None > > Changes in v1: > - None > > .../bindings/devfreq/event/rockchip-dfi.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > new file mode 100644 > index 0000000..d66aca6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > @@ -0,0 +1,19 @@ > + > +* Rockchip rk3399 DFI device > + > +Required properties: > +- compatible: Must be "rockchip,rk3399-dfi". > +- reg: physical base address of each DFI and length of memory mapped region > +- rockchip,pmu: phandle to the syscon managing the "pmu general register files" > +- clocks: phandles for clock specified in "clock-names" property > +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; > + > +Example: > + dfi: dfi at 0xff630000 { > + reg = <0x00 0xff630000 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; As I already commented, you need to reorder between compatible and reg property. > + rockchip,pmu = <&pmugrf>; > + clocks = <&cru PCLK_DDR_MON>; > + clock-names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > -- Best Regards, Chanwoo Choi