From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhFhq-0007aM-G5 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 08:42:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhFhn-00047O-Qy for qemu-devel@nongnu.org; Tue, 06 Sep 2016 08:42:26 -0400 Received: from [59.151.112.132] (port=11667 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhFhn-00045t-DI for qemu-devel@nongnu.org; Tue, 06 Sep 2016 08:42:23 -0400 References: <1471944454-13895-1-git-send-email-caoj.fnst@cn.fujitsu.com> From: Cao jin Message-ID: <57CEB9A8.3090508@cn.fujitsu.com> Date: Tue, 6 Sep 2016 20:42:16 +0800 MIME-Version: 1.0 In-Reply-To: <1471944454-13895-1-git-send-email-caoj.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/5] Convert msix_init() to error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jiri Pirko , "Michael S. Tsirkin" , Jason Wang , Markus Armbruster , Marcel Apfelbaum , Alex Williamson , Hannes Reinecke , Dmitry Fleytman , Paolo Bonzini , Gerd Hoffmann ping On 08/23/2016 05:27 PM, Cao jin wrote: > v2 changelog: > 1. Separate one patch out: "e1000e: remove internal interrupt flag" > 2. Separate coding style related code into patch 2 > 3. Add commit message body for patch 1 > 3. Add function comment for msix_init() in patch 3 > 4. Convert msix_init_exclusive_bar() to error > 5. Other minor changes to patch 3, according to Markus's suggestion. > > Cao jin (5): > msix_init: assert programming error > msix: Follow CODING_STYLE > pci: Convert msix_init() to Error and fix callers to check it > megasas: remove unnecessary megasas_use_msix() > megasas: undo the overwrites of user configuration > > CC: Jiri Pirko > CC: Gerd Hoffmann > CC: Dmitry Fleytman > CC: Jason Wang > CC: Michael S. Tsirkin > CC: Hannes Reinecke > CC: Paolo Bonzini > CC: Alex Williamson > CC: Markus Armbruster > CC: Marcel Apfelbaum > > hw/block/nvme.c | 5 +++- > hw/misc/ivshmem.c | 8 +++--- > hw/net/e1000e.c | 2 +- > hw/net/rocker/rocker.c | 4 ++- > hw/net/vmxnet3.c | 42 +++++++++-------------------- > hw/pci/msix.c | 45 ++++++++++++++++++++++++-------- > hw/scsi/megasas.c | 49 +++++++++++++++++++--------------- > hw/usb/hcd-xhci.c | 71 ++++++++++++++++++++++++++++++-------------------- > hw/vfio/pci.c | 7 +++-- > hw/virtio/virtio-pci.c | 8 ++---- > include/hw/pci/msix.h | 5 ++-- > 11 files changed, 140 insertions(+), 106 deletions(-) > -- Yours Sincerely, Cao jin