From: Xishi Qiu <qiuxishi@huawei.com>
To: Li Zhong <zhong@linux.vnet.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
jallen@linux.vnet.ibm.com, iamjoonsoo.kim@lge.com,
vbabka@suse.cz, n-horiguchi@ah.jp.nec.com, rientjes@google.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mem-hotplug: Don't clear the only node in new_node_page()
Date: Tue, 6 Sep 2016 21:16:09 +0800 [thread overview]
Message-ID: <57CEC199.9000501@huawei.com> (raw)
In-Reply-To: <1473044391.4250.19.camel@TP420>
On 2016/9/5 10:59, Li Zhong wrote:
> Commit 394e31d2c introduced new_node_page() for memory hotplug.
>
> In new_node_page(), the nid is cleared before calling __alloc_pages_nodemask().
> But if it is the only node of the system, and the first round allocation fails,
> it will not be able to get memory from an empty nodemask, and trigger oom.
>
Hi,
Yes, I missed this case, thanks for your fix.
Thanks,
Xishi Qiu
> The patch checks whether it is the last node on the system, and if it is, then
> don't clear the nid in the nodemask.
>
> Reported-by: John Allen <jallen@linux.vnet.ibm.com>
> Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-09-06 13:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 2:59 [PATCH] mem-hotplug: Don't clear the only node in new_node_page() Li Zhong
2016-09-05 14:18 ` Vlastimil Babka
2016-09-06 8:13 ` Li Zhong
2016-09-06 14:12 ` Vlastimil Babka
2016-09-07 0:41 ` [PATCH] mm, page_alloc: warn about empty nodemask Li Zhong
2016-09-08 23:26 ` Andrew Morton
2016-09-09 4:03 ` Li Zhong
2016-09-20 8:27 ` Vlastimil Babka
2016-09-12 9:18 ` [PATCH] mem-hotplug: Don't clear the only node in new_node_page() Michal Hocko
2016-09-20 8:31 ` Vlastimil Babka
2016-09-20 21:53 ` David Rientjes
2016-09-21 2:11 ` Li Zhong
2016-09-21 8:38 ` [PATCH] mem-hotplug: Use nodes that contain memory as mask " Li Zhong
2016-09-21 9:34 ` Vlastimil Babka
2016-09-21 18:14 ` Michal Hocko
2016-09-21 18:08 ` [PATCH] mem-hotplug: Don't clear the only node " Michal Hocko
2016-09-06 13:16 ` Xishi Qiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57CEC199.9000501@huawei.com \
--to=qiuxishi@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jallen@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.