From: "Jan Beulich" <JBeulich@suse.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 4/4] xen: make clear gcov support limitation in Kconfig
Date: Tue, 06 Sep 2016 07:37:54 -0600 [thread overview]
Message-ID: <57CEE2D2020000780010C2C6@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1473165667-25707-5-git-send-email-wei.liu2@citrix.com>
>>> On 06.09.16 at 14:41, <wei.liu2@citrix.com> wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
with one possible further request:
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -33,6 +33,12 @@ config GCOV
> ---help---
> Enable gcov (a test coverage program in GCC) support.
>
> + Currently the data structure and hypercall interface are tied
> + to GCC 3.4 gcov format. You need to have a version of GCC
> + that is compatible with that format to make gcov work.
Is it known up to which gcc version that format did get used? I ask
because mentioning 3.4 when our minimum requirement is 4.1 now
is a little odd. If the format had changed by 4.1, we may want to
consider to make GCOV depend on BROKEN.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-06 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 12:41 [PATCH v2 0/4] gcov: more cleanup Wei Liu
2016-09-06 12:41 ` [PATCH v2 1/4] xen: indicate gcov in log messages Wei Liu
2016-09-06 12:47 ` Andrew Cooper
2016-09-06 13:34 ` Jan Beulich
2016-09-06 14:06 ` Wei Liu
2016-09-06 14:16 ` Jan Beulich
2016-09-06 14:17 ` Andrew Cooper
2016-09-06 22:06 ` Stefano Stabellini
2016-09-06 12:41 ` [PATCH v2 2/4] gcov: collect more sections to constructor list Wei Liu
2016-09-06 13:35 ` Jan Beulich
2016-09-06 12:41 ` [PATCH v2 3/4] xen: replace TEST_COVERAGE with CONFIG_GCOV Wei Liu
2016-09-06 12:41 ` [PATCH v2 4/4] xen: make clear gcov support limitation in Kconfig Wei Liu
2016-09-06 13:37 ` Jan Beulich [this message]
2016-09-06 13:42 ` Andrew Cooper
2016-09-07 6:35 ` [PATCH v2 0/4] gcov: more cleanup Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57CEE2D2020000780010C2C6@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.