All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregor Boirie <gregor.boirie@parrot.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Jonathan Cameron <jic23@kernel.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Alexander Kurz <akurz@blala.de>, Tejun Heo <tj@kernel.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Akinobu Mita <akinobu.mita@gmail.com>,
	Daniel Baluta <daniel.baluta@intel.com>,
	Ludovic Tancerel <ludovic.tancerel@maplehightech.com>,
	Vlad Dogaru <vlad.dogaru@intel.com>, Marek Vasut <marex@denx.de>,
	Crestez Dan Leonard <leonard.crestez@intel.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3 3/3] iio:pressure: initial zpa2326 barometer support
Date: Wed, 7 Sep 2016 10:33:15 +0200	[thread overview]
Message-ID: <57CFD0CB.2070508@parrot.com> (raw)
In-Reply-To: <CACRpkdbHm8Shd_ZqFuciUna8g7vi+s9d9pURqL4SCV1NDg3WuA@mail.gmail.com>



On 09/07/2016 09:54 AM, Linus Walleij wrote:
> On Sun, Sep 4, 2016 at 6:22 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>
>> The nasty here is that we need to validate that the trigger is associate
>> with this device 'before' allowing others to associate.  Could be done I
>> think in a slightly more than average complexity validate call.
>>
>> * If another trigger is used then pollfunc would have to initialize a oneshot
>> read as you already have it doing.
> I guess the new function iio_trigger_using_own() would be pretty helpful
> for this driver too.
Yes! I was just looking at your patch :) It would allow me to get rid of
pointer to own trigger stored in iio device's private state.
Good point.
>
> Do you think we can merge patch 1+2 of that series (adding the function
> and using it with the ST sensors) and I will squash patch
> 3 into my pending MPU-3050 driver and then this driver can rely on it
> as well?
>
> The way I see it is that when handling triggers we should always handle
> our own as well as any external trigger (e.g. HRTimer, or even a trigger
> from a different sensor...)
>
> Yours,
> Linus Walleij


  reply	other threads:[~2016-09-07  8:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 18:47 [PATCH v3 0/3] iio: devm helpers and Murata zpa2326 barometer support Gregor Boirie
2016-09-02 18:47 ` [PATCH v3 1/3] iio:trigger: add resource managed (un)register Gregor Boirie
2016-09-04 14:40   ` Jonathan Cameron
2016-09-02 18:47 ` [PATCH v3 2/3] iio: add resource managed triggered buffer init helpers Gregor Boirie
2016-09-04 14:42   ` Jonathan Cameron
2016-09-02 18:47 ` [PATCH v3 3/3] iio:pressure: initial zpa2326 barometer support Gregor Boirie
2016-09-04 16:22   ` Jonathan Cameron
2016-09-06 13:36     ` Gregor Boirie
2016-09-07  7:54     ` Linus Walleij
2016-09-07  8:33       ` Gregor Boirie [this message]
2016-09-10 15:50         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57CFD0CB.2070508@parrot.com \
    --to=gregor.boirie@parrot.com \
    --cc=akinobu.mita@gmail.com \
    --cc=akurz@blala.de \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=daniel.baluta@intel.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=ldewangan@nvidia.com \
    --cc=leonard.crestez@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=ludovic.tancerel@maplehightech.com \
    --cc=marex@denx.de \
    --cc=mark.rutland@arm.com \
    --cc=narmstrong@baylibre.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=tj@kernel.org \
    --cc=vlad.dogaru@intel.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.