From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757475AbcIGPi2 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 11:38:28 -0400
Received: from out1134-202.mail.aliyun.com ([42.120.134.202]:33688 "EHLO
        out1134-202.mail.aliyun.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1757267AbcIGPi0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 11:38:26 -0400
X-Greylist: delayed 337 seconds by postgrey-1.27 at vger.kernel.org; Wed, 07 Sep 2016 11:38:25 EDT
X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07445891|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03305;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=48;RT=48;SR=0;TI=SMTPD_----5Fackcs_1473262311;
Message-ID: <57D0349F.1080706@emindsoft.com.cn>
Date: Wed, 07 Sep 2016 23:39:11 +0800
From: Chen Gang <chengang@emindsoft.com.cn>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Fengguang Wu <lkp@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>
CC: chengang@emindsoft.com.cn, kbuild-all@01.org, minchan@kernel.org,
        vbabka@suse.cz, gi-oh.kim@profitbricks.com, iamjoonsoo.kim@lge.com,
        hillf.zj@alibaba-inc.com, mgorman@techsingularity.net, mhocko@suse.com,
        rientjes@google.com, linux-kernel@vger.kernel.org, rth@twiddle.net,
        ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@synopsys.com,
        linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com,
        hskinnemoen@gmail.com, egtvedt@samfundet.no, realmz6@gmail.com,
        ysato@users.sourceforge.jp, rkuo@codeaurora.org, tony.luck@intel.com,
        fenghua.yu@intel.com, geert@linux-m68k.org, james.hogan@imgtec.com,
        ralf@linux-mips.org, dhowells@redhat.com, deller@gmx.de,
        benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
        schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, dalias@libc.org,
        davem@davemloft.net, cmetcalf@mellanox.com, chris@zankel.net,
        jcmvbkbc@gmail.com, arnd@arndb.de, noamc@ezchip.com,
        brueckner@linux.vnet.ibm.com, mingo@kernel.org, peterz@infradead.org,
        linux-arch@vger.kernel.org
Subject: Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead
 of int for all bit test functions
References: <1472396129-28665-1-git-send-email-chengang@emindsoft.com.cn> <201609040802.ueL85Ttu%fengguang.wu@intel.com> <20160906122732.2086f1bcb1c3daa378e21d3b@linux-foundation.org> <20160907015219.4bk5ptcfyrosowwi@wfg-t540p.sh.intel.com>
In-Reply-To: <20160907015219.4bk5ptcfyrosowwi@wfg-t540p.sh.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Thank you all for your work. Commonly, I should send patch v3 for it.

And very sorry for replying too late. During these days I have no
enough time on it (working, buying house, and catching a cold, but I am
lucky enough that my father's health is OK).

Thanks.

On 9/7/16 09:52, Fengguang Wu wrote:
> Hi Andrew,
> 
> On Tue, Sep 06, 2016 at 12:27:32PM -0700, Andrew Morton wrote:
>> On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot <lkp@intel.com> wrote:
>>
>>> [auto build test ERROR on linus/master]
>>> [also build test ERROR on v4.8-rc4 next-20160825]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
>>> [Check https://git-scm.com/docs/git-format-patch for more information]
>>>
>>> url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
>>> config: s390-default_defconfig (attached as .config)
>>> compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
>>> reproduce:
>>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>>         chmod +x ~/bin/make.cross
>>>         # save the attached .config to linux build tree
>>>         make.cross ARCH=s390
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>    In file included from include/linux/bitops.h:36:0,
>>>                     from fs/btrfs/extent_io.c:1:
>>> >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
>>>     static inline bool
>>>                   ^
>>>    arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
>>>     static inline bool
>>
>> My s390 cross compiler doesn't like that config.  Can someone test this?
> 
> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> It works fine with Debian's gcc-6-s390x-linux-gnu and crosstool gcc:
> 
> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_s390x-linux.tar.xz
> 
>> --- a/arch/s390/include/asm/bitops.h~a
>> +++ a/arch/s390/include/asm/bitops.h
>> @@ -40,6 +40,7 @@
>> #error only <linux/bitops.h> can be included directly
>> #endif
>>
>> +#include <linux/types.h>
>> #include <linux/typecheck.h>
>> #include <linux/compiler.h>
>> #include <asm/barrier.h>
> 
> Regards,
> Fengguang

-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.

-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chen Gang <chengang@emindsoft.com.cn>
Subject: Re: [PATCH v2] arch: all: include: asm: bitops: Use bool instead
 of int for all bit test functions
Date: Wed, 07 Sep 2016 23:39:11 +0800
Message-ID: <57D0349F.1080706@emindsoft.com.cn>
References: <1472396129-28665-1-git-send-email-chengang@emindsoft.com.cn> <201609040802.ueL85Ttu%fengguang.wu@intel.com> <20160906122732.2086f1bcb1c3daa378e21d3b@linux-foundation.org> <20160907015219.4bk5ptcfyrosowwi@wfg-t540p.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Return-path: <linux-arch-owner@vger.kernel.org>
Received: from out1134-202.mail.aliyun.com ([42.120.134.202]:33688 "EHLO
        out1134-202.mail.aliyun.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1757267AbcIGPi0 (ORCPT
        <rfc822;linux-arch@vger.kernel.org>); Wed, 7 Sep 2016 11:38:26 -0400
In-Reply-To: <20160907015219.4bk5ptcfyrosowwi@wfg-t540p.sh.intel.com>
Sender: linux-arch-owner@vger.kernel.org
List-ID: <linux-arch.vger.kernel.org>
To: Fengguang Wu <lkp@intel.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: chengang@emindsoft.com.cn, kbuild-all@01.org, minchan@kernel.org, vbabka@suse.cz, gi-oh.kim@profitbricks.com, iamjoonsoo.kim@lge.com, hillf.zj@alibaba-inc.com, mgorman@techsingularity.net, mhocko@suse.com, rientjes@google.com, linux-kernel@vger.kernel.org, rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@synopsys.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, hskinnemoen@gmail.com, egtvedt@samfundet.no, realmz6@gmail.com, ysato@users.sourceforge.jp, rkuo@codeaurora.org, tony.luck@intel.com, fenghua.yu@intel.com, geert@linux-m68k.org, james.hogan@imgtec.com, ralf@linux-mips.org, dhowells@redhat.com, deller@gmx.de, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, dalias@l


Thank you all for your work. Commonly, I should send patch v3 for it.

And very sorry for replying too late. During these days I have no
enough time on it (working, buying house, and catching a cold, but I am
lucky enough that my father's health is OK).

Thanks.

On 9/7/16 09:52, Fengguang Wu wrote:
> Hi Andrew,
> 
> On Tue, Sep 06, 2016 at 12:27:32PM -0700, Andrew Morton wrote:
>> On Sun, 4 Sep 2016 08:27:36 +0800 kbuild test robot <lkp@intel.com> wrote:
>>
>>> [auto build test ERROR on linus/master]
>>> [also build test ERROR on v4.8-rc4 next-20160825]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
>>> [Check https://git-scm.com/docs/git-format-patch for more information]
>>>
>>> url:    https://github.com/0day-ci/linux/commits/chengang-emindsoft-com-cn/arch-all-include-asm-bitops-Use-bool-instead-of-int-for-all-bit-test-functions/20160828-230301
>>> config: s390-default_defconfig (attached as .config)
>>> compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
>>> reproduce:
>>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>>         chmod +x ~/bin/make.cross
>>>         # save the attached .config to linux build tree
>>>         make.cross ARCH=s390
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>    In file included from include/linux/bitops.h:36:0,
>>>                     from fs/btrfs/extent_io.c:1:
>>> >> arch/s390/include/asm/bitops.h:176:15: error: unknown type name 'bool'
>>>     static inline bool
>>>                   ^
>>>    arch/s390/include/asm/bitops.h:187:15: error: unknown type name 'bool'
>>>     static inline bool
>>
>> My s390 cross compiler doesn't like that config.  Can someone test this?
> 
> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> It works fine with Debian's gcc-6-s390x-linux-gnu and crosstool gcc:
> 
> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/x86_64-gcc-4.9.0-nolibc_s390x-linux.tar.xz
> 
>> --- a/arch/s390/include/asm/bitops.h~a
>> +++ a/arch/s390/include/asm/bitops.h
>> @@ -40,6 +40,7 @@
>> #error only <linux/bitops.h> can be included directly
>> #endif
>>
>> +#include <linux/types.h>
>> #include <linux/typecheck.h>
>> #include <linux/compiler.h>
>> #include <asm/barrier.h>
> 
> Regards,
> Fengguang

-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.

-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.