From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965340AbcIHJA4 (ORCPT ); Thu, 8 Sep 2016 05:00:56 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41244 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S941032AbcIHJAl (ORCPT ); Thu, 8 Sep 2016 05:00:41 -0400 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: khandual@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Thu, 08 Sep 2016 14:30:25 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Huang, Ying" , Andrew Morton CC: tim.c.chen@intel.com, dave.hansen@intel.com, andi.kleen@intel.com, aaron.lu@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Shaohua Li , Minchan Kim , Rik van Riel , Andrea Arcangeli , "Kirill A . Shutemov" Subject: Re: [PATCH -v3 07/10] mm, THP, swap: Support to add/delete THP to/from swap cache References: <1473266769-2155-1-git-send-email-ying.huang@intel.com> <1473266769-2155-8-git-send-email-ying.huang@intel.com> In-Reply-To: <1473266769-2155-8-git-send-email-ying.huang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16090809-0016-0000-0000-000001CA5AB5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16090809-0017-0000-0000-00000563491D Message-Id: <57D128A9.3030306@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-08_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1609080130 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/2016 10:16 PM, Huang, Ying wrote: > From: Huang Ying > > With this patch, a THP (Transparent Huge Page) can be added/deleted > to/from the swap cache as a set of sub-pages (512 on x86_64). > > This will be used for the THP (Transparent Huge Page) swap support. > Where one THP may be added/delted to/from the swap cache. This will > batch the swap cache operations to reduce the lock acquire/release times > for the THP swap too. > > Cc: Hugh Dickins > Cc: Shaohua Li > Cc: Minchan Kim > Cc: Rik van Riel > Cc: Andrea Arcangeli > Cc: Kirill A. Shutemov > Signed-off-by: "Huang, Ying" > --- > include/linux/page-flags.h | 2 +- > mm/swap_state.c | 57 +++++++++++++++++++++++++++++++--------------- > 2 files changed, 40 insertions(+), 19 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 74e4dda..f5bcbea 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -314,7 +314,7 @@ PAGEFLAG_FALSE(HighMem) > #endif > > #ifdef CONFIG_SWAP > -PAGEFLAG(SwapCache, swapcache, PF_NO_COMPOUND) > +PAGEFLAG(SwapCache, swapcache, PF_NO_TAIL) What is the reason for this change ? The commit message does not seem to explain. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 560826B0038 for ; Thu, 8 Sep 2016 05:00:38 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id l65so30993969wmf.1 for ; Thu, 08 Sep 2016 02:00:38 -0700 (PDT) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com. [148.163.158.5]) by mx.google.com with ESMTPS id l11si7740872wmg.37.2016.09.08.02.00.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Sep 2016 02:00:36 -0700 (PDT) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u888wZgF042107 for ; Thu, 8 Sep 2016 05:00:35 -0400 Received: from e23smtp03.au.ibm.com (e23smtp03.au.ibm.com [202.81.31.145]) by mx0b-001b2d01.pphosted.com with ESMTP id 25ataxxe53-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 08 Sep 2016 05:00:35 -0400 Received: from localhost by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Sep 2016 19:00:32 +1000 Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id ADB392CE8057 for ; Thu, 8 Sep 2016 19:00:29 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8890TNj42270790 for ; Thu, 8 Sep 2016 19:00:29 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8890ThF009711 for ; Thu, 8 Sep 2016 19:00:29 +1000 Date: Thu, 08 Sep 2016 14:30:25 +0530 From: Anshuman Khandual MIME-Version: 1.0 Subject: Re: [PATCH -v3 07/10] mm, THP, swap: Support to add/delete THP to/from swap cache References: <1473266769-2155-1-git-send-email-ying.huang@intel.com> <1473266769-2155-8-git-send-email-ying.huang@intel.com> In-Reply-To: <1473266769-2155-8-git-send-email-ying.huang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: <57D128A9.3030306@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Huang, Ying" , Andrew Morton Cc: tim.c.chen@intel.com, dave.hansen@intel.com, andi.kleen@intel.com, aaron.lu@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Shaohua Li , Minchan Kim , Rik van Riel , Andrea Arcangeli , "Kirill A . Shutemov" On 09/07/2016 10:16 PM, Huang, Ying wrote: > From: Huang Ying > > With this patch, a THP (Transparent Huge Page) can be added/deleted > to/from the swap cache as a set of sub-pages (512 on x86_64). > > This will be used for the THP (Transparent Huge Page) swap support. > Where one THP may be added/delted to/from the swap cache. This will > batch the swap cache operations to reduce the lock acquire/release times > for the THP swap too. > > Cc: Hugh Dickins > Cc: Shaohua Li > Cc: Minchan Kim > Cc: Rik van Riel > Cc: Andrea Arcangeli > Cc: Kirill A. Shutemov > Signed-off-by: "Huang, Ying" > --- > include/linux/page-flags.h | 2 +- > mm/swap_state.c | 57 +++++++++++++++++++++++++++++++--------------- > 2 files changed, 40 insertions(+), 19 deletions(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 74e4dda..f5bcbea 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -314,7 +314,7 @@ PAGEFLAG_FALSE(HighMem) > #endif > > #ifdef CONFIG_SWAP > -PAGEFLAG(SwapCache, swapcache, PF_NO_COMPOUND) > +PAGEFLAG(SwapCache, swapcache, PF_NO_TAIL) What is the reason for this change ? The commit message does not seem to explain. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org