From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from foss.arm.com ([217.140.101.70]:44616 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbcIHKsR (ORCPT ); Thu, 8 Sep 2016 06:48:17 -0400 Message-ID: <57D141DF.2010603@arm.com> Date: Thu, 08 Sep 2016 11:47:59 +0100 From: James Morse MIME-Version: 1.0 To: Arnd Bergmann , Guenter Roeck CC: Hoan Tran , Jean Delvare , Jonathan Corbet , Rob Herring , Jassi Brar , Ashwin Chaugule , Duc Dang , lho@apm.com, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Catalin Marinas , AKASHI Takahiro , Will Deacon Subject: Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver References: <1469134557-26869-1-git-send-email-hotran@apm.com> <13081573.BbD3TmEU5Y@wuerfel> <20160907223705.GA31582@roeck-us.net> <2992356.ULGoZEEDZp@wuerfel> In-Reply-To: <2992356.ULGoZEEDZp@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org Hi, On 08/09/16 09:14, Arnd Bergmann wrote: > On Wednesday, September 7, 2016 3:37:05 PM CEST Guenter Roeck wrote: >> On Wed, Sep 07, 2016 at 11:41:44PM +0200, Arnd Bergmann wrote: >>> On Thursday, July 21, 2016 1:55:56 PM CEST Hoan Tran wrote: >>>> + ctx->comm_base_addr = cppc_ss->base_address; >>>> + if (ctx->comm_base_addr) { >>>> + ctx->pcc_comm_addr = >>>> + acpi_os_ioremap(ctx->comm_base_addr, >>>> + cppc_ss->length); >>>> >>> >>> This causes the arm64 allmodconfig build to fail now, according to >>> kernelci: >>> >>> 1 ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined! >>> >>> Should this perhaps call ioremap() or memremap() instead? >>> >> Hmmm ... almost sounds to me like blaming the messenger. e7cd190385d1 ("arm64: >> mark reserved memblock regions explicitly in iomem") starts using a function >> in acpi_os_ioremap() which is not exported. On top of that, memblock_is_memory() >> is declared as __init_memblock, which makes me really uncomfortable. >> If acpi_os_ioremap() must not be used by modules, and possibly only during >> early (?) initialization, maybe its declaration should state those limitations ? > > Ah, I didn't notice that. I guess both patches were correct individually and > got added to linux-next around the same time but caused allmodconfig to blow up > when used together. > > Adding everyone who was involved in the memblock patch to Cc here, maybe one > of them has an idea what the correct fix is. There are only two other drivers > using acpi_os_ioremap() and one of them is x86-specific, so it's still likely > that drivers are not actually supposed to use this symbol. Making > acpi_os_ioremap() an exported function in arm64 would also work. You could use acpi_os_map_iomem()/acpi_os_unmap_iomem() from acpi/acpi_io.h. If there isn't an existing mapping these end up in acpi_os_ioremap(), and are already EXPORT_SYMBOL_GPL(). (I'm still waiting for allmodconfig on linux-next to finish building) Thanks, James From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morse Subject: Re: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver Date: Thu, 08 Sep 2016 11:47:59 +0100 Message-ID: <57D141DF.2010603@arm.com> References: <1469134557-26869-1-git-send-email-hotran@apm.com> <13081573.BbD3TmEU5Y@wuerfel> <20160907223705.GA31582@roeck-us.net> <2992356.ULGoZEEDZp@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2992356.ULGoZEEDZp@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann , Guenter Roeck Cc: Hoan Tran , Jean Delvare , Jonathan Corbet , Rob Herring , Jassi Brar , Ashwin Chaugule , Duc Dang , lho-qTEPVZfXA3Y@public.gmane.org, linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Catalin Marinas , AKASHI Takahiro , Will Deacon List-Id: devicetree@vger.kernel.org Hi, On 08/09/16 09:14, Arnd Bergmann wrote: > On Wednesday, September 7, 2016 3:37:05 PM CEST Guenter Roeck wrote: >> On Wed, Sep 07, 2016 at 11:41:44PM +0200, Arnd Bergmann wrote: >>> On Thursday, July 21, 2016 1:55:56 PM CEST Hoan Tran wrote: >>>> + ctx->comm_base_addr = cppc_ss->base_address; >>>> + if (ctx->comm_base_addr) { >>>> + ctx->pcc_comm_addr = >>>> + acpi_os_ioremap(ctx->comm_base_addr, >>>> + cppc_ss->length); >>>> >>> >>> This causes the arm64 allmodconfig build to fail now, according to >>> kernelci: >>> >>> 1 ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined! >>> >>> Should this perhaps call ioremap() or memremap() instead? >>> >> Hmmm ... almost sounds to me like blaming the messenger. e7cd190385d1 ("arm64: >> mark reserved memblock regions explicitly in iomem") starts using a function >> in acpi_os_ioremap() which is not exported. On top of that, memblock_is_memory() >> is declared as __init_memblock, which makes me really uncomfortable. >> If acpi_os_ioremap() must not be used by modules, and possibly only during >> early (?) initialization, maybe its declaration should state those limitations ? > > Ah, I didn't notice that. I guess both patches were correct individually and > got added to linux-next around the same time but caused allmodconfig to blow up > when used together. > > Adding everyone who was involved in the memblock patch to Cc here, maybe one > of them has an idea what the correct fix is. There are only two other drivers > using acpi_os_ioremap() and one of them is x86-specific, so it's still likely > that drivers are not actually supposed to use this symbol. Making > acpi_os_ioremap() an exported function in arm64 would also work. You could use acpi_os_map_iomem()/acpi_os_unmap_iomem() from acpi/acpi_io.h. If there isn't an existing mapping these end up in acpi_os_ioremap(), and are already EXPORT_SYMBOL_GPL(). (I'm still waiting for allmodconfig on linux-next to finish building) Thanks, James -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: james.morse@arm.com (James Morse) Date: Thu, 08 Sep 2016 11:47:59 +0100 Subject: [PATCH v3 2/3] hwmon: xgene: Add hwmon driver In-Reply-To: <2992356.ULGoZEEDZp@wuerfel> References: <1469134557-26869-1-git-send-email-hotran@apm.com> <13081573.BbD3TmEU5Y@wuerfel> <20160907223705.GA31582@roeck-us.net> <2992356.ULGoZEEDZp@wuerfel> Message-ID: <57D141DF.2010603@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 08/09/16 09:14, Arnd Bergmann wrote: > On Wednesday, September 7, 2016 3:37:05 PM CEST Guenter Roeck wrote: >> On Wed, Sep 07, 2016 at 11:41:44PM +0200, Arnd Bergmann wrote: >>> On Thursday, July 21, 2016 1:55:56 PM CEST Hoan Tran wrote: >>>> + ctx->comm_base_addr = cppc_ss->base_address; >>>> + if (ctx->comm_base_addr) { >>>> + ctx->pcc_comm_addr = >>>> + acpi_os_ioremap(ctx->comm_base_addr, >>>> + cppc_ss->length); >>>> >>> >>> This causes the arm64 allmodconfig build to fail now, according to >>> kernelci: >>> >>> 1 ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined! >>> >>> Should this perhaps call ioremap() or memremap() instead? >>> >> Hmmm ... almost sounds to me like blaming the messenger. e7cd190385d1 ("arm64: >> mark reserved memblock regions explicitly in iomem") starts using a function >> in acpi_os_ioremap() which is not exported. On top of that, memblock_is_memory() >> is declared as __init_memblock, which makes me really uncomfortable. >> If acpi_os_ioremap() must not be used by modules, and possibly only during >> early (?) initialization, maybe its declaration should state those limitations ? > > Ah, I didn't notice that. I guess both patches were correct individually and > got added to linux-next around the same time but caused allmodconfig to blow up > when used together. > > Adding everyone who was involved in the memblock patch to Cc here, maybe one > of them has an idea what the correct fix is. There are only two other drivers > using acpi_os_ioremap() and one of them is x86-specific, so it's still likely > that drivers are not actually supposed to use this symbol. Making > acpi_os_ioremap() an exported function in arm64 would also work. You could use acpi_os_map_iomem()/acpi_os_unmap_iomem() from acpi/acpi_io.h. If there isn't an existing mapping these end up in acpi_os_ioremap(), and are already EXPORT_SYMBOL_GPL(). (I'm still waiting for allmodconfig on linux-next to finish building) Thanks, James