From: "Jan Beulich" <JBeulich@suse.com>
To: Derek Straka <derek@asterius.io>
Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART
Date: Wed, 14 Sep 2016 04:39:30 -0600 [thread overview]
Message-ID: <57D94502020000780010EBC4@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1473788144-12113-1-git-send-email-derek@asterius.io>
>>> On 13.09.16 at 19:35, <derek@asterius.io> wrote:
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -1,6 +1,6 @@
> config HAS_NS16550
> - bool
> - default y
> + bool "NS16550 UART" if EXPERT = "y"
This need more adjustment: HAS_* options should never have
prompts. I.e. you need to rename the config variable at once.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-09-14 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 17:35 [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART Derek Straka
2016-09-13 17:35 ` [PATCH 2/2] x86: add a user configurable Kconfig option for the EHCI UART Derek Straka
2016-09-13 17:43 ` Andrew Cooper
2016-09-14 9:43 ` Julien Grall
2016-09-14 10:41 ` Jan Beulich
2016-09-13 17:43 ` [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART Andrew Cooper
2016-09-14 9:42 ` Julien Grall
2016-09-14 10:39 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D94502020000780010EBC4@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=derek@asterius.io \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.