* [RESEND PATCH v4] thermal: tango: add resume support
@ 2016-09-07 8:30 ` Marc Gonzalez
0 siblings, 0 replies; 10+ messages in thread
From: Marc Gonzalez @ 2016-09-07 8:30 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin
Cc: linux-pm, Linux ARM, Kevin Hilman, Arnd Bergmann, Mason
When this platform is suspended, firmware powers the entire SoC down,
except a few hardware blocks waiting for wakeup events. There is no
context to save for this particular block.
Therefore, there is nothing useful for the driver to do on suspend;
so we define a NULL suspend hook. On resume, the driver initializes
the block exactly as is done in the probe callback.
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
Add Kevin's Reviewed-by tag.
Earlier versions of this patch were reviewed by Kevin and Thierry.
The current form is preferred by Arnd.
Rui, could you take this patch before the next merge window opens?
---
drivers/thermal/tango_thermal.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c
index 70e0d9f406e9..201304aeafeb 100644
--- a/drivers/thermal/tango_thermal.c
+++ b/drivers/thermal/tango_thermal.c
@@ -64,6 +64,12 @@ static const struct thermal_zone_of_device_ops ops = {
.get_temp = tango_get_temp,
};
+static void tango_thermal_init(struct tango_thermal_priv *priv)
+{
+ writel(0, priv->base + TEMPSI_CFG);
+ writel(CMD_ON, priv->base + TEMPSI_CMD);
+}
+
static int tango_thermal_probe(struct platform_device *pdev)
{
struct resource *res;
@@ -79,14 +85,22 @@ static int tango_thermal_probe(struct platform_device *pdev)
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
+ platform_set_drvdata(pdev, priv);
priv->thresh_idx = IDX_MIN;
- writel(0, priv->base + TEMPSI_CFG);
- writel(CMD_ON, priv->base + TEMPSI_CMD);
+ tango_thermal_init(priv);
tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, priv, &ops);
return PTR_ERR_OR_ZERO(tzdev);
}
+static int __maybe_unused tango_thermal_resume(struct device *dev)
+{
+ tango_thermal_init(dev_get_drvdata(dev));
+ return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(tango_thermal_pm, NULL, tango_thermal_resume);
+
static const struct of_device_id tango_sensor_ids[] = {
{
.compatible = "sigma,smp8758-thermal",
@@ -99,6 +113,7 @@ static struct platform_driver tango_thermal_driver = {
.driver = {
.name = "tango-thermal",
.of_match_table = tango_sensor_ids,
+ .pm = &tango_thermal_pm,
},
};
--
2.9.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RESEND PATCH v4] thermal: tango: add resume support
@ 2016-09-07 8:30 ` Marc Gonzalez
0 siblings, 0 replies; 10+ messages in thread
From: Marc Gonzalez @ 2016-09-07 8:30 UTC (permalink / raw)
To: linux-arm-kernel
When this platform is suspended, firmware powers the entire SoC down,
except a few hardware blocks waiting for wakeup events. There is no
context to save for this particular block.
Therefore, there is nothing useful for the driver to do on suspend;
so we define a NULL suspend hook. On resume, the driver initializes
the block exactly as is done in the probe callback.
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
Add Kevin's Reviewed-by tag.
Earlier versions of this patch were reviewed by Kevin and Thierry.
The current form is preferred by Arnd.
Rui, could you take this patch before the next merge window opens?
---
drivers/thermal/tango_thermal.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c
index 70e0d9f406e9..201304aeafeb 100644
--- a/drivers/thermal/tango_thermal.c
+++ b/drivers/thermal/tango_thermal.c
@@ -64,6 +64,12 @@ static const struct thermal_zone_of_device_ops ops = {
.get_temp = tango_get_temp,
};
+static void tango_thermal_init(struct tango_thermal_priv *priv)
+{
+ writel(0, priv->base + TEMPSI_CFG);
+ writel(CMD_ON, priv->base + TEMPSI_CMD);
+}
+
static int tango_thermal_probe(struct platform_device *pdev)
{
struct resource *res;
@@ -79,14 +85,22 @@ static int tango_thermal_probe(struct platform_device *pdev)
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
+ platform_set_drvdata(pdev, priv);
priv->thresh_idx = IDX_MIN;
- writel(0, priv->base + TEMPSI_CFG);
- writel(CMD_ON, priv->base + TEMPSI_CMD);
+ tango_thermal_init(priv);
tzdev = devm_thermal_zone_of_sensor_register(&pdev->dev, 0, priv, &ops);
return PTR_ERR_OR_ZERO(tzdev);
}
+static int __maybe_unused tango_thermal_resume(struct device *dev)
+{
+ tango_thermal_init(dev_get_drvdata(dev));
+ return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(tango_thermal_pm, NULL, tango_thermal_resume);
+
static const struct of_device_id tango_sensor_ids[] = {
{
.compatible = "sigma,smp8758-thermal",
@@ -99,6 +113,7 @@ static struct platform_driver tango_thermal_driver = {
.driver = {
.name = "tango-thermal",
.of_match_table = tango_sensor_ids,
+ .pm = &tango_thermal_pm,
},
};
--
2.9.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [RESEND PATCH v4] thermal: tango: add resume support
2016-09-07 8:30 ` Marc Gonzalez
@ 2016-09-07 8:55 ` Arnd Bergmann
-1 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2016-09-07 8:55 UTC (permalink / raw)
To: Marc Gonzalez
Cc: Kevin Hilman, linux-pm, Mason, Eduardo Valentin, Zhang Rui, Linux ARM
On Wednesday, September 7, 2016 10:30:41 AM CEST Marc Gonzalez wrote:
> When this platform is suspended, firmware powers the entire SoC down,
> except a few hardware blocks waiting for wakeup events. There is no
> context to save for this particular block.
>
> Therefore, there is nothing useful for the driver to do on suspend;
> so we define a NULL suspend hook. On resume, the driver initializes
> the block exactly as is done in the probe callback.
>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH v4] thermal: tango: add resume support
@ 2016-09-07 8:55 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2016-09-07 8:55 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday, September 7, 2016 10:30:41 AM CEST Marc Gonzalez wrote:
> When this platform is suspended, firmware powers the entire SoC down,
> except a few hardware blocks waiting for wakeup events. There is no
> context to save for this particular block.
>
> Therefore, there is nothing useful for the driver to do on suspend;
> so we define a NULL suspend hook. On resume, the driver initializes
> the block exactly as is done in the probe callback.
>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RESEND PATCH v4] thermal: tango: add resume support
2016-09-07 8:55 ` Arnd Bergmann
@ 2016-09-14 15:35 ` Marc Gonzalez
-1 siblings, 0 replies; 10+ messages in thread
From: Marc Gonzalez @ 2016-09-14 15:35 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin, linux-pm
Cc: Linux ARM, Kevin Hilman, Arnd Bergmann, Mason
On 07/09/2016 10:55, Arnd Bergmann wrote:
> On Wednesday, September 7, 2016 10:30:41 AM CEST Marc Gonzalez wrote:
>
>> When this platform is suspended, firmware powers the entire SoC down,
>> except a few hardware blocks waiting for wakeup events. There is no
>> context to save for this particular block.
>>
>> Therefore, there is nothing useful for the driver to do on suspend;
>> so we define a NULL suspend hook. On resume, the driver initializes
>> the block exactly as is done in the probe callback.
>>
>> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Hello Rui, Eduardo,
The present patch has been reviewed by both Kevin Hilman and Arnd Bergmann,
two arm-soc maintainers. Can you pick it up in time for inclusion in v4.9?
Regards.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH v4] thermal: tango: add resume support
@ 2016-09-14 15:35 ` Marc Gonzalez
0 siblings, 0 replies; 10+ messages in thread
From: Marc Gonzalez @ 2016-09-14 15:35 UTC (permalink / raw)
To: linux-arm-kernel
On 07/09/2016 10:55, Arnd Bergmann wrote:
> On Wednesday, September 7, 2016 10:30:41 AM CEST Marc Gonzalez wrote:
>
>> When this platform is suspended, firmware powers the entire SoC down,
>> except a few hardware blocks waiting for wakeup events. There is no
>> context to save for this particular block.
>>
>> Therefore, there is nothing useful for the driver to do on suspend;
>> so we define a NULL suspend hook. On resume, the driver initializes
>> the block exactly as is done in the probe callback.
>>
>> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Hello Rui, Eduardo,
The present patch has been reviewed by both Kevin Hilman and Arnd Bergmann,
two arm-soc maintainers. Can you pick it up in time for inclusion in v4.9?
Regards.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RESEND PATCH v4] thermal: tango: add resume support
2016-09-14 15:35 ` Marc Gonzalez
@ 2016-09-18 1:58 ` Zhang Rui
-1 siblings, 0 replies; 10+ messages in thread
From: Zhang Rui @ 2016-09-18 1:58 UTC (permalink / raw)
To: Marc Gonzalez, Eduardo Valentin, linux-pm
Cc: Linux ARM, Kevin Hilman, Arnd Bergmann, Mason
On 三, 2016-09-14 at 17:35 +0200, Marc Gonzalez wrote:
> On 07/09/2016 10:55, Arnd Bergmann wrote:
>
> >
> > On Wednesday, September 7, 2016 10:30:41 AM CEST Marc Gonzalez
> > wrote:
> >
> > >
> > > When this platform is suspended, firmware powers the entire SoC
> > > down,
> > > except a few hardware blocks waiting for wakeup events. There is
> > > no
> > > context to save for this particular block.
> > >
> > > Therefore, there is nothing useful for the driver to do on
> > > suspend;
> > > so we define a NULL suspend hook. On resume, the driver
> > > initializes
> > > the block exactly as is done in the probe callback.
> > >
> > > Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> > > Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Hello Rui, Eduardo,
>
> The present patch has been reviewed by both Kevin Hilman and Arnd
> Bergmann,
> two arm-soc maintainers. Can you pick it up in time for inclusion in
> v4.9?
It has already been in thermal -release branch for a while, and queued
for 4.9.
thanks,
rui
>
> Regards.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH v4] thermal: tango: add resume support
@ 2016-09-18 1:58 ` Zhang Rui
0 siblings, 0 replies; 10+ messages in thread
From: Zhang Rui @ 2016-09-18 1:58 UTC (permalink / raw)
To: linux-arm-kernel
On ?, 2016-09-14 at 17:35 +0200, Marc Gonzalez wrote:
> On 07/09/2016 10:55, Arnd Bergmann wrote:
>
> >
> > On Wednesday, September 7, 2016 10:30:41 AM CEST Marc Gonzalez
> > wrote:
> >
> > >
> > > When this platform is suspended, firmware powers the entire SoC
> > > down,
> > > except a few hardware blocks waiting for wakeup events. There is
> > > no
> > > context to save for this particular block.
> > >
> > > Therefore, there is nothing useful for the driver to do on
> > > suspend;
> > > so we define a NULL suspend hook. On resume, the driver
> > > initializes
> > > the block exactly as is done in the probe callback.
> > >
> > > Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> > > Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Hello Rui, Eduardo,
>
> The present patch has been reviewed by both Kevin Hilman and Arnd
> Bergmann,
> two arm-soc maintainers. Can you pick it up in time for inclusion in
> v4.9?
It has already been in thermal -release branch for a while, and queued
for 4.9.
thanks,
rui
>
> Regards.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at??http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RESEND PATCH v4] thermal: tango: add resume support
2016-09-18 1:58 ` Zhang Rui
@ 2016-09-19 13:33 ` Marc Gonzalez
-1 siblings, 0 replies; 10+ messages in thread
From: Marc Gonzalez @ 2016-09-19 13:33 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin
Cc: linux-pm, Linux ARM, Kevin Hilman, Arnd Bergmann, Mason
On 18/09/2016 03:58, Zhang Rui wrote:
> On 2016-09-14 at 17:35 +0200, Marc Gonzalez wrote:
>
>> Hello Rui, Eduardo,
>>
>> The present patch has been reviewed by both Kevin Hilman and Arnd Bergmann,
>> two arm-soc maintainers. Can you pick it up in time for inclusion in v4.9?
>
> It has already been in thermal -release branch for a while, and queued
> for 4.9.
Sorry, I was expecting an ACK on the list. It never occurred to me
to check your tree. Thanks for taking the patch.
https://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/commit/?h=release&id=186e2aa3954c3201583e5ec3149faa6caa67d2b9
Regards.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RESEND PATCH v4] thermal: tango: add resume support
@ 2016-09-19 13:33 ` Marc Gonzalez
0 siblings, 0 replies; 10+ messages in thread
From: Marc Gonzalez @ 2016-09-19 13:33 UTC (permalink / raw)
To: linux-arm-kernel
On 18/09/2016 03:58, Zhang Rui wrote:
> On 2016-09-14 at 17:35 +0200, Marc Gonzalez wrote:
>
>> Hello Rui, Eduardo,
>>
>> The present patch has been reviewed by both Kevin Hilman and Arnd Bergmann,
>> two arm-soc maintainers. Can you pick it up in time for inclusion in v4.9?
>
> It has already been in thermal -release branch for a while, and queued
> for 4.9.
Sorry, I was expecting an ACK on the list. It never occurred to me
to check your tree. Thanks for taking the patch.
https://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/commit/?h=release&id=186e2aa3954c3201583e5ec3149faa6caa67d2b9
Regards.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-09-19 13:33 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-07 8:30 [RESEND PATCH v4] thermal: tango: add resume support Marc Gonzalez
2016-09-07 8:30 ` Marc Gonzalez
2016-09-07 8:55 ` Arnd Bergmann
2016-09-07 8:55 ` Arnd Bergmann
2016-09-14 15:35 ` Marc Gonzalez
2016-09-14 15:35 ` Marc Gonzalez
2016-09-18 1:58 ` Zhang Rui
2016-09-18 1:58 ` Zhang Rui
2016-09-19 13:33 ` Marc Gonzalez
2016-09-19 13:33 ` Marc Gonzalez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.