All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timothy Pearson <tpearson@raptorengineering.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] Initial driver for the MAX31785 intelligent fan controller
Date: Mon, 19 Sep 2016 13:14:49 -0500	[thread overview]
Message-ID: <57E02B19.6010709@raptorengineeringinc.com> (raw)
In-Reply-To: <20160919014104.GA30840@roeck-us.net>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/18/2016 08:41 PM, Guenter Roeck wrote:
> On Sun, Sep 18, 2016 at 07:50:55PM -0500, Timothy Pearson wrote:
>> Add a basic driver for the MAX31785, focusing on the fan control
>> features but ignoring the temperature and voltage monitoring
>> features of the device.
>>
>> This driver supports all fan control modes and tachometer / PWM
>> readback where applicable.
>>
> Could you try using hwmon_device_register_with_info() as available in
> linux-next ? Hopefully that should reduce driver size (and give the new API
> some test coverage).

Ordinarily I'd be willing to try this, but in this case I wouldn't be
able to test the module on real hardware; it's an embedded system and
uses the 4.7 kernel at the moment.  Would you be OK with merging a fixed
version of this patch and I can throw together an untested variant using
hwmon_device_register_with_info() for future work?

> Please run the patch through checkpatch --strict. I don't expect you to
> fix all the problems is reports, but the following should be addressed.
> 
> CHECK: Prefer kernel type 'u8' over 'uint8_t'
> CHECK: Prefer kernel type 'u16' over 'uint16_t'
> CHECK: Alignment should match open parenthesis
> CHECK: Logical continuations should be on the previous line
> WARNING: quoted string split across lines

My fault, I completely forgot to run checkpatch.  I'll get a V2 together
shortly including addressing the inline comments.

- -- 
Timothy Pearson
Raptor Engineering
+1 (415) 727-8645 (direct line)
+1 (512) 690-0200 (switchboard)
https://www.raptorengineering.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJX4CsUAAoJEK+E3vEXDOFb++AH/i1FxEmOJmNVlSowpV5EHsgQ
xcquFnmeF/pK6Oh00LbcI3WvTCgVRBkUl32WG7m5ktKXLDn5fU9DFEQYQVVhzRFU
jz83JyD8HvDhOKubk9G9mqE518ZBIEnYiREHFI9fVuOnUTVemrZtYdKdoA7ez3wi
5t7B7HJ4Gdcyi1FkNwLu+0/N7eLGyR9WfQAFqM0F64qRfQGOxWtwoi4lYgmbxHCg
NFs7LAoJsj00K4DEPiK/3jjy5usfBpcIgkECAYK7+A/sUtDTq+TrBr1ADZY0mbV3
zqDo85alN5XQEvLTjACWXmauMhCUsV4OqzurtlBAVMJQDW6ZKeCnhxv+iUaDxh8=
=Rr2j
-----END PGP SIGNATURE-----

  reply	other threads:[~2016-09-19 18:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19  1:41 [PATCH] Initial driver for the MAX31785 intelligent fan controller Guenter Roeck
2016-09-19 18:14 ` Timothy Pearson [this message]
2016-09-19 20:05   ` Guenter Roeck
2016-09-19 18:40 ` Timothy Pearson
2016-09-19 20:04   ` Guenter Roeck
2016-09-19 20:31     ` Timothy Pearson
2016-09-20  0:54       ` Guenter Roeck
2016-09-20  1:41         ` Timothy Pearson
2016-09-20 19:41           ` Timothy Pearson
2016-09-20 19:59             ` Guenter Roeck
2016-09-20 20:01               ` Timothy Pearson
2016-09-21  3:04                 ` Guenter Roeck
2016-09-21  3:09                   ` Timothy Pearson
2016-10-11 14:39                   ` Timothy Pearson
  -- strict thread matches above, loose matches on Subject: below --
2016-09-20  1:52 [PATCH] Add hwmon driver for MAX31875 Timothy Pearson
2016-09-20  1:52 ` [PATCH] Initial driver for the MAX31785 intelligent fan controller Timothy Pearson
2016-09-23  7:41   ` Joel Stanley
2016-09-23 15:04     ` Timothy Pearson
2016-12-09 15:55       ` Matt Spinler
2016-12-11 23:36         ` Joel Stanley
2016-12-12 16:32           ` Timothy Pearson
2016-12-12 18:17             ` Matt Spinler
2016-12-12 19:56               ` Timothy Pearson
2016-09-19  0:50 Timothy Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57E02B19.6010709@raptorengineeringinc.com \
    --to=tpearson@raptorengineering.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.