From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init Date: Tue, 20 Sep 2016 10:43:10 +0800 Message-ID: <57E0A23E.2090609@huawei.com> References: <1473862879-7769-1-git-send-email-guohanjun@huawei.com> <1473862879-7769-12-git-send-email-guohanjun@huawei.com> <57DABD2F.1030606@arm.com> <3f9b5a3e-13f4-75a4-15bc-f55e26740205@linaro.org> <57DFBA0D.7040801@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from szxga03-in.huawei.com ([119.145.14.66]:35777 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124AbcITCnd (ORCPT ); Mon, 19 Sep 2016 22:43:33 -0400 In-Reply-To: <57DFBA0D.7040801@arm.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Marc Zyngier , Hanjun Guo , "Rafael J. Wysocki" , Lorenzo Pieralisi Cc: linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Bjorn Helgaas , Greg KH , Tomasz Nowicki , Ma Jun , Kefeng Wang , Charles Garcia-Tobin , linuxarm@huawei.com On 2016/9/19 18:12, Marc Zyngier wrote: > On 19/09/16 10:49, Hanjun Guo wrote: >> On 2016/9/15 23:24, Marc Zyngier wrote: >>> On 14/09/16 15:21, Hanjun Guo wrote: >>>> From: Hanjun Guo >>>> >>>> mbigen is an irqchip and it needs to be probed before >>>> devices, same logic is used for SMMU and etc., let's >>>> use arch_initcall instead of platform init for mbigen. >>>> >>>> Cc: Marc Zyngier >>>> Cc: Thomas Gleixner >>>> Cc: Ma Jun >>>> Signed-off-by: Hanjun Guo >>>> --- >>>> drivers/irqchip/irq-mbigen.c | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c >>>> index ca6add1..3a33de6 100644 >>>> --- a/drivers/irqchip/irq-mbigen.c >>>> +++ b/drivers/irqchip/irq-mbigen.c >>>> @@ -374,7 +374,11 @@ static struct platform_driver mbigen_platform_driver = { >>>> .probe = mbigen_device_probe, >>>> }; >>>> >>>> -module_platform_driver(mbigen_platform_driver); >>>> +static __init int mbigen_init(void) >>>> +{ >>>> + return platform_driver_register(&mbigen_platform_driver); >>>> +} >>>> +arch_initcall(mbigen_init); >>>> >>>> MODULE_AUTHOR("Jun Ma "); >>>> MODULE_AUTHOR("Yun Wu "); >>>> >>> I've already NACKed such a patch in the past, and I will carry on >>> NACKing it until all the other avenues (like properly tracking device >>> dependencies) have been explored and have been proven not to be fit for >>> purpose. >> I'd happy to work on this to make progress. >> >>> Rafael had proposed something around this subject last year, and I've >> Sorry, obviously I missed something, could you give me the link about >> Rafael's patches? I will pull back and test it on our hardware. > Please see this discussion from almost a year ago: > > https://patchwork.kernel.org/patch/7407401/ > > in which I give the existing pointers and explain why I'm pushing back > on things like this patch. We (Majun and me ) will look into it, thanks! Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753589AbcITCnf (ORCPT ); Mon, 19 Sep 2016 22:43:35 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:35777 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124AbcITCnd (ORCPT ); Mon, 19 Sep 2016 22:43:33 -0400 Subject: Re: [RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init To: Marc Zyngier , Hanjun Guo , "Rafael J. Wysocki" , Lorenzo Pieralisi References: <1473862879-7769-1-git-send-email-guohanjun@huawei.com> <1473862879-7769-12-git-send-email-guohanjun@huawei.com> <57DABD2F.1030606@arm.com> <3f9b5a3e-13f4-75a4-15bc-f55e26740205@linaro.org> <57DFBA0D.7040801@arm.com> CC: , , , Thomas Gleixner , "Bjorn Helgaas" , Greg KH , "Tomasz Nowicki" , Ma Jun , Kefeng Wang , Charles Garcia-Tobin , From: Hanjun Guo Message-ID: <57E0A23E.2090609@huawei.com> Date: Tue, 20 Sep 2016 10:43:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <57DFBA0D.7040801@arm.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.17.188] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.57E0A24F.0020,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 43d1ac07902a98fd3ad147be11cdfcce Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/19 18:12, Marc Zyngier wrote: > On 19/09/16 10:49, Hanjun Guo wrote: >> On 2016/9/15 23:24, Marc Zyngier wrote: >>> On 14/09/16 15:21, Hanjun Guo wrote: >>>> From: Hanjun Guo >>>> >>>> mbigen is an irqchip and it needs to be probed before >>>> devices, same logic is used for SMMU and etc., let's >>>> use arch_initcall instead of platform init for mbigen. >>>> >>>> Cc: Marc Zyngier >>>> Cc: Thomas Gleixner >>>> Cc: Ma Jun >>>> Signed-off-by: Hanjun Guo >>>> --- >>>> drivers/irqchip/irq-mbigen.c | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c >>>> index ca6add1..3a33de6 100644 >>>> --- a/drivers/irqchip/irq-mbigen.c >>>> +++ b/drivers/irqchip/irq-mbigen.c >>>> @@ -374,7 +374,11 @@ static struct platform_driver mbigen_platform_driver = { >>>> .probe = mbigen_device_probe, >>>> }; >>>> >>>> -module_platform_driver(mbigen_platform_driver); >>>> +static __init int mbigen_init(void) >>>> +{ >>>> + return platform_driver_register(&mbigen_platform_driver); >>>> +} >>>> +arch_initcall(mbigen_init); >>>> >>>> MODULE_AUTHOR("Jun Ma "); >>>> MODULE_AUTHOR("Yun Wu "); >>>> >>> I've already NACKed such a patch in the past, and I will carry on >>> NACKing it until all the other avenues (like properly tracking device >>> dependencies) have been explored and have been proven not to be fit for >>> purpose. >> I'd happy to work on this to make progress. >> >>> Rafael had proposed something around this subject last year, and I've >> Sorry, obviously I missed something, could you give me the link about >> Rafael's patches? I will pull back and test it on our hardware. > Please see this discussion from almost a year ago: > > https://patchwork.kernel.org/patch/7407401/ > > in which I give the existing pointers and explain why I'm pushing back > on things like this patch. We (Majun and me ) will look into it, thanks! Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 From: guohanjun@huawei.com (Hanjun Guo) Date: Tue, 20 Sep 2016 10:43:10 +0800 Subject: [RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init In-Reply-To: <57DFBA0D.7040801@arm.com> References: <1473862879-7769-1-git-send-email-guohanjun@huawei.com> <1473862879-7769-12-git-send-email-guohanjun@huawei.com> <57DABD2F.1030606@arm.com> <3f9b5a3e-13f4-75a4-15bc-f55e26740205@linaro.org> <57DFBA0D.7040801@arm.com> Message-ID: <57E0A23E.2090609@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/9/19 18:12, Marc Zyngier wrote: > On 19/09/16 10:49, Hanjun Guo wrote: >> On 2016/9/15 23:24, Marc Zyngier wrote: >>> On 14/09/16 15:21, Hanjun Guo wrote: >>>> From: Hanjun Guo >>>> >>>> mbigen is an irqchip and it needs to be probed before >>>> devices, same logic is used for SMMU and etc., let's >>>> use arch_initcall instead of platform init for mbigen. >>>> >>>> Cc: Marc Zyngier >>>> Cc: Thomas Gleixner >>>> Cc: Ma Jun >>>> Signed-off-by: Hanjun Guo >>>> --- >>>> drivers/irqchip/irq-mbigen.c | 6 +++++- >>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c >>>> index ca6add1..3a33de6 100644 >>>> --- a/drivers/irqchip/irq-mbigen.c >>>> +++ b/drivers/irqchip/irq-mbigen.c >>>> @@ -374,7 +374,11 @@ static struct platform_driver mbigen_platform_driver = { >>>> .probe = mbigen_device_probe, >>>> }; >>>> >>>> -module_platform_driver(mbigen_platform_driver); >>>> +static __init int mbigen_init(void) >>>> +{ >>>> + return platform_driver_register(&mbigen_platform_driver); >>>> +} >>>> +arch_initcall(mbigen_init); >>>> >>>> MODULE_AUTHOR("Jun Ma "); >>>> MODULE_AUTHOR("Yun Wu "); >>>> >>> I've already NACKed such a patch in the past, and I will carry on >>> NACKing it until all the other avenues (like properly tracking device >>> dependencies) have been explored and have been proven not to be fit for >>> purpose. >> I'd happy to work on this to make progress. >> >>> Rafael had proposed something around this subject last year, and I've >> Sorry, obviously I missed something, could you give me the link about >> Rafael's patches? I will pull back and test it on our hardware. > Please see this discussion from almost a year ago: > > https://patchwork.kernel.org/patch/7407401/ > > in which I give the existing pointers and explain why I'm pushing back > on things like this patch. We (Majun and me ) will look into it, thanks! Hanjun