All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Tim Deegan <tim@xen.org>, Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Question about VPID during MOV-TO-CR3
Date: Tue, 04 Oct 2016 08:29:34 -0600	[thread overview]
Message-ID: <57F3D8EE0200007800114F1C@prv-mh.provo.novell.com> (raw)
In-Reply-To: <CAErYnsjW-E9RaDqgpmrczJbZYnEpJUaFE-CTbPvXLeZAt8Og_Q@mail.gmail.com>

>>> On 04.10.16 at 16:12, <tamas.lengyel@zentific.com> wrote:
> yes, I understand that is the case when you do need to flush a guest.
> And yes, there seem to be paths that require to bump the tag of a
> specific guest for certain events (mov-to-cr4 with paging mode changes
> for example). What I'm poking at it here is that we invalidate the
> guest TLBs for _all_ guests very frequently. I can't find an
> explanation for why _that_ is required. AFAIK having the TLB tag
> guarantees that no other guest or Xen will have a chance to bump into
> stale entries given no guests or Xen share a TLB tag with each other.
> So the only time I see that we would have to flush all guest TLBs is
> when the tag overflows and we start from 1 again. What am I missing
> here?

Oh, I see - this indeed looks to be quite a bit more flushing than is
desirable. So the question, as you did put it already, is why it got
done that way in the first place. At the very least it would look like
more control would need to be given to the callers of both
write_cr3() and flush_area_local(). Tim?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-10-04 14:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20 17:29 Question about VPID during MOV-TO-CR3 Tamas K Lengyel
2016-09-21 10:23 ` Jan Beulich
2016-09-21 14:18   ` Tamas K Lengyel
2016-09-21 14:44     ` Jan Beulich
2016-09-21 15:09       ` Tamas K Lengyel
2016-09-21 15:16         ` Tamas K Lengyel
2016-09-21 15:23           ` Jan Beulich
2016-09-21 15:30             ` Tamas K Lengyel
2016-09-21 18:26               ` Tamas K Lengyel
2016-09-22  9:00                 ` Jan Beulich
2016-09-22 10:39                   ` Tamas K Lengyel
2016-09-22 11:35                     ` Jan Beulich
2016-09-22  8:56               ` Jan Beulich
2016-09-22 10:35                 ` Tamas K Lengyel
2016-09-22 11:27                   ` Jan Beulich
2016-09-22 11:37                     ` Tamas K Lengyel
2016-09-22 17:18                       ` Tamas K Lengyel
2016-09-23  8:24                         ` Jan Beulich
2016-09-23  8:35                           ` Razvan Cojocaru
2016-09-23 15:26                           ` Tamas K Lengyel
2016-09-23 15:39                             ` Jan Beulich
2016-09-23 15:50                               ` Tamas K Lengyel
2016-09-23 20:45                                 ` Tamas K Lengyel
2016-09-26  6:24                                   ` Jan Beulich
2016-09-26 16:12                                     ` Tamas K Lengyel
2016-09-27 13:49                                       ` Jan Beulich
2016-10-01 19:05                                         ` Tamas K Lengyel
2016-10-04  7:41                                           ` Jan Beulich
2016-10-04 14:12                                             ` Tamas K Lengyel
2016-10-04 14:29                                               ` Jan Beulich [this message]
2016-10-04 15:06                                                 ` Tim Deegan
2016-10-07 15:32                                                   ` Jan Beulich
2016-10-07 15:41                                                     ` Tamas K Lengyel
2016-10-07 16:00                                                       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57F3D8EE0200007800114F1C@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=tamas.lengyel@zentific.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.