From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bs2eA-0000rK-6M for qemu-devel@nongnu.org; Thu, 06 Oct 2016 02:59:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bs2e6-0003Jq-2Y for qemu-devel@nongnu.org; Thu, 06 Oct 2016 02:59:13 -0400 Received: from [59.151.112.132] (port=44055 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bs2e4-0003Gf-OM for qemu-devel@nongnu.org; Thu, 06 Oct 2016 02:59:09 -0400 References: <1471944454-13895-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1471944454-13895-2-git-send-email-caoj.fnst@cn.fujitsu.com> <87y42xw8jk.fsf@dusky.pond.sub.org> <57D769C7.4000503@cn.fujitsu.com> <87fup4iatn.fsf@dusky.pond.sub.org> <20160913084911.5fd310ee@t450s.home> <87oa3697gg.fsf@dusky.pond.sub.org> <20160929101003.701a51d1@t450s.home> <87oa35scrp.fsf@dusky.pond.sub.org> From: Cao jin Message-ID: <57F5F67A.5080100@cn.fujitsu.com> Date: Thu, 6 Oct 2016 15:00:10 +0800 MIME-Version: 1.0 In-Reply-To: <87oa35scrp.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Alex Williamson Cc: Marcel Apfelbaum , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 09/30/2016 10:06 PM, Markus Armbruster wrote: > Alex Williamson writes: > > > Once there's a need to handle a certain condition as an error, we should > do that, no argument. This also provides a way to test the error path. > > However, I wouldn't buy an argument that preconditions should be made as > weak as possible in leaf functions (let alone always) regardless of the > cost in complexity, and non-testability of error paths. I'm strictly a > pay as you go person. > > Back to the problem at hand. Cao jin, would you be willing to fix > msi_init()? > > Sorry for the holiday delay. Sure, will fix it, and add it as a new patch in this series. -- Yours Sincerely, Cao jin