From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752987AbcJMUKP (ORCPT ); Thu, 13 Oct 2016 16:10:15 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43543 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751765AbcJMUJ7 (ORCPT ); Thu, 13 Oct 2016 16:09:59 -0400 Date: Thu, 13 Oct 2016 20:08:03 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Rientjes , Anshuman Khandual CC: Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH V4] mm: Add sysfs interface to dump each node's zonelist information References: <1473150666-3875-1-git-send-email-khandual@linux.vnet.ibm.com> <1473302818-23974-1-git-send-email-khandual@linux.vnet.ibm.com> <57D1C914.9090403@intel.com> <57D63CB2.8070003@linux.vnet.ibm.com> <57DCC605.10305@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16101314-0040-0000-0000-000001EC8002 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16101314-0041-0000-0000-00000AADCE4E Message-Id: <57FF9C4B.5040004@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-13_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610130251 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/20/2016 06:24 AM, David Rientjes wrote: > On Sat, 17 Sep 2016, Anshuman Khandual wrote: > >>> > > I'm questioning if this information can be inferred from information >>> > > already in /proc/zoneinfo and sysfs. We know the no-fallback zonelist is >>> > > going to include the local node, and we know the other zonelists are >>> > > either node ordered or zone ordered (or do we need to extend >>> > > vm.numa_zonelist_order for default?). I may have missed what new >>> > > knowledge this interface is imparting on us. >> > >> > IIUC /proc/zoneinfo lists down zone internal state and statistics for >> > all zones on the system at any given point of time. The no-fallback >> > list contains the zones from the local node and fallback (which gets >> > used more often than the no-fallback) list contains all zones either >> > in node-ordered or zone-ordered manner. In most of the platforms the >> > default being the node order but the sequence of present nodes in >> > that order is determined by various factors like NUMA distance, load, >> > presence of CPUs on the node etc. This order of nodes in the fallback >> > list is the most important information derived out of this interface. >> > > The point is that all of this can be inferred with information already > provided, so the additional interface seems unnecessary. The only > extension I think that is needed is to determine if the order is node or > zone when vm.numa_zonelist_order == default and we shouldn't parse this > from dmesg. Okay. Seems like the general view is that this interface is not necessary. Hence wont be posting the debugfs version for now. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f200.google.com (mail-pf0-f200.google.com [209.85.192.200]) by kanga.kvack.org (Postfix) with ESMTP id 0FC4B6B025E for ; Thu, 13 Oct 2016 10:38:14 -0400 (EDT) Received: by mail-pf0-f200.google.com with SMTP id t25so77710519pfg.3 for ; Thu, 13 Oct 2016 07:38:14 -0700 (PDT) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id r1si12305809pax.317.2016.10.13.07.38.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Oct 2016 07:38:11 -0700 (PDT) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9DEY5gn056016 for ; Thu, 13 Oct 2016 10:38:10 -0400 Received: from e23smtp05.au.ibm.com (e23smtp05.au.ibm.com [202.81.31.147]) by mx0a-001b2d01.pphosted.com with ESMTP id 262bwss9nr-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 13 Oct 2016 10:38:10 -0400 Received: from localhost by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Oct 2016 00:38:07 +1000 Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id C0C402CE8059 for ; Fri, 14 Oct 2016 01:38:05 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9DEc5ij62980328 for ; Fri, 14 Oct 2016 01:38:05 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9DEc5pg025442 for ; Fri, 14 Oct 2016 01:38:05 +1100 Date: Thu, 13 Oct 2016 20:08:03 +0530 From: Anshuman Khandual MIME-Version: 1.0 Subject: Re: [PATCH V4] mm: Add sysfs interface to dump each node's zonelist information References: <1473150666-3875-1-git-send-email-khandual@linux.vnet.ibm.com> <1473302818-23974-1-git-send-email-khandual@linux.vnet.ibm.com> <57D1C914.9090403@intel.com> <57D63CB2.8070003@linux.vnet.ibm.com> <57DCC605.10305@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Message-Id: <57FF9C4B.5040004@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes , Anshuman Khandual Cc: Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org On 09/20/2016 06:24 AM, David Rientjes wrote: > On Sat, 17 Sep 2016, Anshuman Khandual wrote: > >>> > > I'm questioning if this information can be inferred from information >>> > > already in /proc/zoneinfo and sysfs. We know the no-fallback zonelist is >>> > > going to include the local node, and we know the other zonelists are >>> > > either node ordered or zone ordered (or do we need to extend >>> > > vm.numa_zonelist_order for default?). I may have missed what new >>> > > knowledge this interface is imparting on us. >> > >> > IIUC /proc/zoneinfo lists down zone internal state and statistics for >> > all zones on the system at any given point of time. The no-fallback >> > list contains the zones from the local node and fallback (which gets >> > used more often than the no-fallback) list contains all zones either >> > in node-ordered or zone-ordered manner. In most of the platforms the >> > default being the node order but the sequence of present nodes in >> > that order is determined by various factors like NUMA distance, load, >> > presence of CPUs on the node etc. This order of nodes in the fallback >> > list is the most important information derived out of this interface. >> > > The point is that all of this can be inferred with information already > provided, so the additional interface seems unnecessary. The only > extension I think that is needed is to determine if the order is node or > zone when vm.numa_zonelist_order == default and we shouldn't parse this > from dmesg. Okay. Seems like the general view is that this interface is not necessary. Hence wont be posting the debugfs version for now. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org