From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8DCC433B4 for ; Fri, 30 Apr 2021 03:06:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F4776143A for ; Fri, 30 Apr 2021 03:06:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229577AbhD3DGh (ORCPT ); Thu, 29 Apr 2021 23:06:37 -0400 Received: from mail-pl1-f175.google.com ([209.85.214.175]:35643 "EHLO mail-pl1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbhD3DGg (ORCPT ); Thu, 29 Apr 2021 23:06:36 -0400 Received: by mail-pl1-f175.google.com with SMTP id t21so4757217plo.2 for ; Thu, 29 Apr 2021 20:05:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FUbWrbAUFMQKu6236LhZho6/j3gJNZ7P8lNGT3czIBE=; b=lYhrlkHAjjK81YczqGBjxvGrKBsEerQgVBpJBZ/TnvR50CuVjaQzA0zO9ASrza0YAX uSbqy9IG07VJ3RcRHfzmoxq0Xzp2n7tPejwVlH9QyLF1G1D3WFcIfpR9FowTAvErv1ze S8vqSS5B0iu1FGTfppQNRFDsfwSrN3FaGbiydLcMchUF/a59SGOunIiSFZoQG2YdIrjk WhotVCDAJCnGKQx129sdyiaPdPgIv84IObCj+QmbUe807lP47n4erlzsEsuAAnoYZGcM TANqaXqwAFYqvwD3T9maekpukE2qb+eosW6XZa+eJY78CsO3H1hUO6wuuYhKwq6T+5pE 6fPQ== X-Gm-Message-State: AOAM5330Q9wikejBe9ma9W5CukJkDUeNAMyn6myGDJZV1knUoEq7Vz2b M6ZggW+lNK+JlE+opYb7INM= X-Google-Smtp-Source: ABdhPJzO6eoeOoXmiOJ218cvaw3YI3lwZAp2T+zHWd0aesaKc0DO67nRvb2qOJuIsparALGeoqupcw== X-Received: by 2002:a17:90a:e558:: with SMTP id ei24mr3067422pjb.43.1619751949044; Thu, 29 Apr 2021 20:05:49 -0700 (PDT) Received: from [192.168.3.219] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id h20sm420181pfv.6.2021.04.29.20.05.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 20:05:48 -0700 (PDT) Subject: Re: [PATCH V4 4/4] blk-mq: clearing flush request reference in tags->rqs[] To: Ming Lei , Jens Axboe Cc: linux-block@vger.kernel.org, Khazhy Kumykov , Shin'ichiro Kawasaki , Hannes Reinecke , John Garry , David Jeffery References: <20210429023458.3044317-1-ming.lei@redhat.com> <20210429023458.3044317-5-ming.lei@redhat.com> From: Bart Van Assche Message-ID: <57ac930a-3da3-eb91-2800-96fb395de44d@acm.org> Date: Thu, 29 Apr 2021 20:05:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210429023458.3044317-5-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 4/28/21 7:34 PM, Ming Lei wrote: > Before we free request queue, clearing flush request reference in > tags->rqs[], so that potential UAF can be avoided. Reviewed-by: Bart Van Assche