From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8558CCA47B for ; Tue, 5 Jul 2022 12:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235815AbiGEMUX (ORCPT ); Tue, 5 Jul 2022 08:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237493AbiGEMTR (ORCPT ); Tue, 5 Jul 2022 08:19:17 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A36D21D0F0 for ; Tue, 5 Jul 2022 05:14:51 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id t25so20202844lfg.7 for ; Tue, 05 Jul 2022 05:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=eL+08v8Oi5zgvZaTmHJaJqmfpDb3pg+GRYdgzapfaeA=; b=IlbN2EKy4yQqYZ6TvuHxuB4Brfc58jz2COGInOXdqWYrxosn56LD8j38tIpCLG+ifF O4hd4lyK4J+FilFcGOge/0dt6N2OQ/8ClL09bZ1CTBK5jhppv/EUnvSV8jitc1OMFVqh 0V3GML79t3b42q12UUevZQ30e/m4KFt2PwjMWBMNJQhYow/6/kD4dmrRovGPowydnBdo CsRijzBCJLV0+witJNk/3iPbzuM7Px2532fhidb2oljMhB2bwptWF+dafPlMb9jt08M9 F04VWDAC2OdUnbcNOuzOr6Y2UaKVUYwPCjBZht6u6QvbU/+zKAr45qwH0yH/XyAnDS0U 42MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=eL+08v8Oi5zgvZaTmHJaJqmfpDb3pg+GRYdgzapfaeA=; b=aQcb8Aij2f7wXvchgwFbuLpdxb1QhIY82FI/0AdehasLU1Vv2VrexQxWtzW4S1cI0K HeIk6vxh0+yAoYjP9oeMSamk7JE3uRbnS6bwUJmPWstWbXGGIOHeX4LGPAYzsYqSSrj1 whH9qzi4F//yL0a25IWAPDWPwumMtl6fFVtSPlHylSi5B4apNUeFVT6ER0f3Cv7dRwSl Ct3OmH3H212D89is9xXUK8zZh3YA0AqpJRiXJqlpL2kHCciAW+cwRDF+W3T2igMZzpHk kHHGWE+BTdS8UEERAYMkGzTrSS9IC3hyfx1oN9nauyAeKDwdf1U+3SPtyZz6B6c61Jt7 2VsQ== X-Gm-Message-State: AJIora+sGVtpEqgVM7zyOYrTj4TNjb0kyiCMqhgfUCdtxjpZmMAiB3Hc +3nlVNsjvZInGLSH0pdJuLS2kQ== X-Google-Smtp-Source: AGRyM1s/yOEIUzQU+X3pSlzpw0EltRXDz7KCK5C05eZnuBOHpHDEuKwOWuFuqLLMSl7dgCD4X8Ap2w== X-Received: by 2002:ac2:4c19:0:b0:47f:9f39:768c with SMTP id t25-20020ac24c19000000b0047f9f39768cmr21990330lfq.285.1657023290040; Tue, 05 Jul 2022 05:14:50 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id t15-20020ac243af000000b0048295a41b0asm1990198lfl.302.2022.07.05.05.14.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 05:14:49 -0700 (PDT) Message-ID: <57aca768-18f4-6b79-9490-c57123d71232@linaro.org> Date: Tue, 5 Jul 2022 14:14:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() Content-Language: en-US From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephen Boyd References: <20220519073330.7187-1-krzysztof.kozlowski@linaro.org> <640d2a3d-4c38-b921-45c1-048c255b5a9d@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 20/06/2022 20:37, Krzysztof Kozlowski wrote: > On 09/06/2022 10:56, Krzysztof Kozlowski wrote: >> On 19/05/2022 09:33, Krzysztof Kozlowski wrote: >>> The use of strncpy() is considered deprecated for NUL-terminated >>> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing >>> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg: >>> glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning: >>> >>> In function ‘qcom_glink_rx_close’, >>> inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4: >>> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] >>> 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name)); >>> >>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings >>> >>> Signed-off-by: Krzysztof Kozlowski >>> >>> --- >>> >>> Changes since v1: >>> 1. Split series per subsystem. >> >> Any comments on these? > > I sent first iteration in May, then on 19th of May. There is review from > Stephen. > > On 9th of June I pinged but the patchset is still waiting. Anyone minds > me taking these? Hmmm... These are all fixes but wait for quite a long time. Shall we make the rpmsg subsystem orphaned? Best regards, Krzysztof