From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05DA1C07E95 for ; Tue, 20 Jul 2021 18:04:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5E496101B for ; Tue, 20 Jul 2021 18:04:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5E496101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5u6E-0004pf-PE for qemu-devel@archiver.kernel.org; Tue, 20 Jul 2021 14:04:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5u55-0002nH-KW for qemu-devel@nongnu.org; Tue, 20 Jul 2021 14:02:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34938) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5u52-0007ub-03 for qemu-devel@nongnu.org; Tue, 20 Jul 2021 14:02:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626804175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XzxOiDcBkPOJqQOCoTMG+ciAfcJPoyfZbYFz0r0CV0A=; b=M0X6hOYS8octxP1HuQj7RI1OBdaMSEJjH9Mp3hWuRfI1vkOJuMxJFlTW2ZmaIqMRmBif5g kVvKntV8ru+T/EoUBnBu0F5cpxHaYH+iyaA+FHzW5tcgblLN5Rk0wMM/R+u7xWnpgXFm0V EqlUBBe/0ICkUTKU/C27WlI7D2r0kCI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-varYYfH5Pi-xW9fR3lPSeg-1; Tue, 20 Jul 2021 14:02:53 -0400 X-MC-Unique: varYYfH5Pi-xW9fR3lPSeg-1 Received: by mail-wr1-f72.google.com with SMTP id r18-20020adff1120000b029013e2b4ee624so10671525wro.1 for ; Tue, 20 Jul 2021 11:02:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XzxOiDcBkPOJqQOCoTMG+ciAfcJPoyfZbYFz0r0CV0A=; b=hIE/KxQFdwGMMODTvP3UeUUnUJYoZfh7XrXp8Hoo1bbCo2N1qIaMKkQyNcp7BVWpmY DayEIVK8XGKMiraqyw4pC5riNbN6nhKd1vjn8oIpVMI3ICP/kcTYrf1DAgcuWZ0z53Om 24hwVxMWOtPVBzQt4KH8I0IDOebSIt7H/1R6kNSkdPsW8MOZpQHTV+Of6DywoHZmFmXf 1IgWShtWz5gds+Q8fyA0QKheZIFpJ2Xe5f0ra/nWr0dS30Z/gZ+0h3aW/9Ud/NeeLG89 zW0qIGGc56alPZeLZ+oVo/eovaWKD3A/l0zgJazT9OprWDuyOEusjJvX5T6MiNojrPzv XMXA== X-Gm-Message-State: AOAM530NOMGjgt6W7+ROFaGu9SnJHOXgli6FEKArUfSnuPIQZTREYZ8Q QRMAUOeEbYszhi8P3u0YfQmZIsJDeCP4RTad3ffHDW+G8eh1c7H02K1pii6zsny/GiZtVBgOlzO FuG7H4Ue9LiXFEIw= X-Received: by 2002:adf:ea0f:: with SMTP id q15mr37615366wrm.145.1626804172901; Tue, 20 Jul 2021 11:02:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUmTAGikjDdL1as5Tpf5Jj0q5ygmzHOWO0RIn4fYklJGeLY7SCAE7O7o1UOE0Kv6m9xjdxaQ== X-Received: by 2002:adf:ea0f:: with SMTP id q15mr37615337wrm.145.1626804172687; Tue, 20 Jul 2021 11:02:52 -0700 (PDT) Received: from [192.168.1.36] (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id o6sm23970861wry.91.2021.07.20.11.02.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jul 2021 11:02:52 -0700 (PDT) Subject: Re: [PATCH 04/16] multi-process: Fix pci_proxy_dev_realize() error handling To: Markus Armbruster , qemu-devel@nongnu.org References: <20210720125408.387910-1-armbru@redhat.com> <20210720125408.387910-5-armbru@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <57b51182-3988-a9cc-10b6-ed2eac10937d@redhat.com> Date: Tue, 20 Jul 2021 20:02:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210720125408.387910-5-armbru@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.474, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elena Ufimtseva , John G Johnson , Jagannathan Raman , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/20/21 2:53 PM, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer points to NULL for the second > call. > > pci_proxy_dev_realize() is wrong that way: it passes @errp to > qio_channel_new_fd() without checking for failure. If it runs into > another failure, it trips error_setv()'s assertion. > > Fix it to check for failure properly. > > Fixes: 9f8112073aad8e485ac012ee18809457ab7f23a6 > Cc: Elena Ufimtseva > Cc: Jagannathan Raman > Cc: John G Johnson > Cc: Stefan Hajnoczi > Signed-off-by: Markus Armbruster > --- > hw/remote/proxy.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé