From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com. [2a00:1450:4864:20::641]) by gmr-mx.google.com with ESMTPS id q28si523998lfb.10.2020.12.13.03.31.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Dec 2020 03:31:32 -0800 (PST) Received: by mail-ej1-x641.google.com with SMTP id ga15so18611284ejb.4 for ; Sun, 13 Dec 2020 03:31:32 -0800 (PST) Return-Path: Subject: Re: [patch 21/30] net/mlx4: Use effective interrupt affinity References: <20201210192536.118432146@linutronix.de> <20201210194044.672935978@linutronix.de> From: Tariq Toukan Message-ID: <57c3f9d3-7262-9916-626b-c2234de763f0@gmail.com> Date: Sun, 13 Dec 2020 13:31:24 +0200 MIME-Version: 1.0 In-Reply-To: <20201210194044.672935978@linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Thomas Gleixner , LKML Cc: Peter Zijlstra , Marc Zyngier , Tariq Toukan , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , afzal mohammed , linux-parisc@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Mark Rutland , Catalin Marinas , Will Deacon , Christian Borntraeger , Heiko Carstens , linux-s390@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Pankaj Bharadiya , Chris Wilson , Wambui Karuga , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Tvrtko Ursulin , Linus Walleij , linux-gpio@vger.kernel.org, Lee Jones , Jon Mason , Dave Jiang , Allen Hubbe , linux-ntb@googlegroups.com, Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Michal Simek , linux-pci@vger.kernel.org, Karthikeyan Mitran , Hou Zhiqiang , Saeed Mahameed , Leon Romanovsky , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org List-ID: On 12/10/2020 9:25 PM, Thomas Gleixner wrote: > Using the interrupt affinity mask for checking locality is not really > working well on architectures which support effective affinity masks. > > The affinity mask is either the system wide default or set by user space, > but the architecture can or even must reduce the mask to the effective set, > which means that checking the affinity mask itself does not really tell > about the actual target CPUs. > > Signed-off-by: Thomas Gleixner > Cc: Tariq Toukan > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > --- > drivers/net/ethernet/mellanox/mlx4/en_cq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/ethernet/mellanox/mlx4/en_cq.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_cq.c > @@ -117,7 +117,7 @@ int mlx4_en_activate_cq(struct mlx4_en_p > assigned_eq = true; > } > irq = mlx4_eq_get_irq(mdev->dev, cq->vector); > - cq->aff_mask = irq_get_affinity_mask(irq); > + cq->aff_mask = irq_get_effective_affinity_mask(irq); > } else { > /* For TX we use the same irq per > ring we assigned for the RX */ > Reviewed-by: Tariq Toukan Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9314CC4361B for ; Mon, 14 Dec 2020 08:18:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48244207A5 for ; Mon, 14 Dec 2020 08:18:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48244207A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CABCA6E0E7; Mon, 14 Dec 2020 08:17:44 +0000 (UTC) Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by gabe.freedesktop.org (Postfix) with ESMTPS id A087E6E0BE; Sun, 13 Dec 2020 11:31:33 +0000 (UTC) Received: by mail-ej1-x644.google.com with SMTP id q22so877199eja.2; Sun, 13 Dec 2020 03:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TjWjwM1ceLhbF1IYJl3oWPHfyZ88hbVMXIeiKOfmwOM=; b=vPvvh2iQ0r9ZbJoXMCDIftnNA4fETiNQFFFHNFtTvfww3hKWzjIscr3aHAUNvJNsBo Ivf0d9Mvb99JMJV9ehcDPkg7swsKEMl7+Y/hUHya1SLUv75EVwMKcVXA4wQhFYugquwI v+qVZoFUku+Z4S07otlNJUYYZFwuVftQM+5pKMuoRFtJsCSR2/FO/OAFm9dwXHUCnb0g nyevY+rBPRTACXhZ931IzFg7Awoce5sQ06vu7Ya86N9A/av13YTjQRgaXCWsCWUM/pP3 fYNitfafK87nYGzSZSaCif4DP/TVC+LUGSPprBAe6V1QO0w7yMUKiZ5MZM5KRMECQCql 1tPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TjWjwM1ceLhbF1IYJl3oWPHfyZ88hbVMXIeiKOfmwOM=; b=dn9iTBYrLO0ZFZmiD3WkVldPdSWXD+nrzZlSUwezcaQpxjXpEyvwotJTxSjuIKZ4Fk XjqoCDbSeCtzzuEHRLvYdvWHS3BEzMN76JCY/3wHmKvbkx1LJiE4YnAzvMezVNAr0y0j N7lNKgqJ/ZDSemUju6BtW6ALLWBSpxhv2w0sInPskWOLJeVptzGOPNoZd7N20h2qX+cd KVJlX5FS/rDImCyFM31QtuGKcAtCAUlNL45w9hBXsG1pLMKqmtTxu9hNzgpd4nw9nGe4 PvdqdCk+/7jGYQCmaBFHoCWVYL17YngUj6K3ar7xRZoNDMrrF64woOIDgozfhyz/V0Xm Zldw== X-Gm-Message-State: AOAM532DWFTVINPIzfCuU2HxSu9vnZmRJbPiBLMkp7I/cwk7y17P8ops +BsdWb/zccGs7qXxDHDcyfA= X-Google-Smtp-Source: ABdhPJyEr8C9Ogdb1mA5xMC+43Vgspphph1JMIeMGN8re3oj2ZBqnM3siDmfQyHHB65lUudEMrQXmA== X-Received: by 2002:a17:906:4bc5:: with SMTP id x5mr1966810ejv.55.1607859092305; Sun, 13 Dec 2020 03:31:32 -0800 (PST) Received: from [192.168.0.107] ([77.127.34.194]) by smtp.gmail.com with ESMTPSA id d6sm11014971ejy.114.2020.12.13.03.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Dec 2020 03:31:31 -0800 (PST) Subject: Re: [patch 21/30] net/mlx4: Use effective interrupt affinity To: Thomas Gleixner , LKML References: <20201210192536.118432146@linutronix.de> <20201210194044.672935978@linutronix.de> From: Tariq Toukan Message-ID: <57c3f9d3-7262-9916-626b-c2234de763f0@gmail.com> Date: Sun, 13 Dec 2020 13:31:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201210194044.672935978@linutronix.de> Content-Language: en-US X-Mailman-Approved-At: Mon, 14 Dec 2020 08:17:40 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Karthikeyan Mitran , Peter Zijlstra , Catalin Marinas , dri-devel@lists.freedesktop.org, Chris Wilson , "James E.J. Bottomley" , Will Deacon , Michal Simek , linux-s390@vger.kernel.org, afzal mohammed , Lorenzo Pieralisi , Dave Jiang , xen-devel@lists.xenproject.org, Leon Romanovsky , linux-rdma@vger.kernel.org, Marc Zyngier , Helge Deller , Russell King , Christian Borntraeger , linux-pci@vger.kernel.org, Jakub Kicinski , intel-gfx@lists.freedesktop.org, Wambui Karuga , Allen Hubbe , Juergen Gross , Tvrtko Ursulin , Heiko Carstens , Jon Mason , linux-gpio@vger.kernel.org, Stefano Stabellini , Rodrigo Vivi , Bjorn Helgaas , Lee Jones , linux-arm-kernel@lists.infradead.org, Boris Ostrovsky , David Airlie , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Hou Zhiqiang , Tariq Toukan , Pankaj Bharadiya , linux-ntb@googlegroups.com, Saeed Mahameed , "David S. Miller" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 12/10/2020 9:25 PM, Thomas Gleixner wrote: > Using the interrupt affinity mask for checking locality is not really > working well on architectures which support effective affinity masks. > > The affinity mask is either the system wide default or set by user space, > but the architecture can or even must reduce the mask to the effective set, > which means that checking the affinity mask itself does not really tell > about the actual target CPUs. > > Signed-off-by: Thomas Gleixner > Cc: Tariq Toukan > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > --- > drivers/net/ethernet/mellanox/mlx4/en_cq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/ethernet/mellanox/mlx4/en_cq.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_cq.c > @@ -117,7 +117,7 @@ int mlx4_en_activate_cq(struct mlx4_en_p > assigned_eq = true; > } > irq = mlx4_eq_get_irq(mdev->dev, cq->vector); > - cq->aff_mask = irq_get_affinity_mask(irq); > + cq->aff_mask = irq_get_effective_affinity_mask(irq); > } else { > /* For TX we use the same irq per > ring we assigned for the RX */ > Reviewed-by: Tariq Toukan Thanks. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F9FC4361B for ; Mon, 14 Dec 2020 15:16:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61AD922A99 for ; Mon, 14 Dec 2020 15:16:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61AD922A99 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C76696E241; Mon, 14 Dec 2020 15:16:30 +0000 (UTC) Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by gabe.freedesktop.org (Postfix) with ESMTPS id A087E6E0BE; Sun, 13 Dec 2020 11:31:33 +0000 (UTC) Received: by mail-ej1-x644.google.com with SMTP id q22so877199eja.2; Sun, 13 Dec 2020 03:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TjWjwM1ceLhbF1IYJl3oWPHfyZ88hbVMXIeiKOfmwOM=; b=vPvvh2iQ0r9ZbJoXMCDIftnNA4fETiNQFFFHNFtTvfww3hKWzjIscr3aHAUNvJNsBo Ivf0d9Mvb99JMJV9ehcDPkg7swsKEMl7+Y/hUHya1SLUv75EVwMKcVXA4wQhFYugquwI v+qVZoFUku+Z4S07otlNJUYYZFwuVftQM+5pKMuoRFtJsCSR2/FO/OAFm9dwXHUCnb0g nyevY+rBPRTACXhZ931IzFg7Awoce5sQ06vu7Ya86N9A/av13YTjQRgaXCWsCWUM/pP3 fYNitfafK87nYGzSZSaCif4DP/TVC+LUGSPprBAe6V1QO0w7yMUKiZ5MZM5KRMECQCql 1tPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TjWjwM1ceLhbF1IYJl3oWPHfyZ88hbVMXIeiKOfmwOM=; b=dn9iTBYrLO0ZFZmiD3WkVldPdSWXD+nrzZlSUwezcaQpxjXpEyvwotJTxSjuIKZ4Fk XjqoCDbSeCtzzuEHRLvYdvWHS3BEzMN76JCY/3wHmKvbkx1LJiE4YnAzvMezVNAr0y0j N7lNKgqJ/ZDSemUju6BtW6ALLWBSpxhv2w0sInPskWOLJeVptzGOPNoZd7N20h2qX+cd KVJlX5FS/rDImCyFM31QtuGKcAtCAUlNL45w9hBXsG1pLMKqmtTxu9hNzgpd4nw9nGe4 PvdqdCk+/7jGYQCmaBFHoCWVYL17YngUj6K3ar7xRZoNDMrrF64woOIDgozfhyz/V0Xm Zldw== X-Gm-Message-State: AOAM532DWFTVINPIzfCuU2HxSu9vnZmRJbPiBLMkp7I/cwk7y17P8ops +BsdWb/zccGs7qXxDHDcyfA= X-Google-Smtp-Source: ABdhPJyEr8C9Ogdb1mA5xMC+43Vgspphph1JMIeMGN8re3oj2ZBqnM3siDmfQyHHB65lUudEMrQXmA== X-Received: by 2002:a17:906:4bc5:: with SMTP id x5mr1966810ejv.55.1607859092305; Sun, 13 Dec 2020 03:31:32 -0800 (PST) Received: from [192.168.0.107] ([77.127.34.194]) by smtp.gmail.com with ESMTPSA id d6sm11014971ejy.114.2020.12.13.03.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Dec 2020 03:31:31 -0800 (PST) To: Thomas Gleixner , LKML References: <20201210192536.118432146@linutronix.de> <20201210194044.672935978@linutronix.de> From: Tariq Toukan Message-ID: <57c3f9d3-7262-9916-626b-c2234de763f0@gmail.com> Date: Sun, 13 Dec 2020 13:31:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201210194044.672935978@linutronix.de> Content-Language: en-US X-Mailman-Approved-At: Mon, 14 Dec 2020 15:16:10 +0000 Subject: Re: [Intel-gfx] [patch 21/30] net/mlx4: Use effective interrupt affinity X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Karthikeyan Mitran , Peter Zijlstra , Catalin Marinas , Linus Walleij , dri-devel@lists.freedesktop.org, Chris Wilson , "James E.J. Bottomley" , Will Deacon , Michal Simek , Rob Herring , linux-s390@vger.kernel.org, afzal mohammed , Lorenzo Pieralisi , Dave Jiang , xen-devel@lists.xenproject.org, Leon Romanovsky , linux-rdma@vger.kernel.org, Marc Zyngier , Helge Deller , Russell King , Christian Borntraeger , linux-pci@vger.kernel.org, Jakub Kicinski , intel-gfx@lists.freedesktop.org, Wambui Karuga , Allen Hubbe , Juergen Gross , Heiko Carstens , Jon Mason , linux-gpio@vger.kernel.org, Stefano Stabellini , Bjorn Helgaas , Lee Jones , linux-arm-kernel@lists.infradead.org, Boris Ostrovsky , David Airlie , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Hou Zhiqiang , Tariq Toukan , linux-ntb@googlegroups.com, Saeed Mahameed , "David S. Miller" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 12/10/2020 9:25 PM, Thomas Gleixner wrote: > Using the interrupt affinity mask for checking locality is not really > working well on architectures which support effective affinity masks. > > The affinity mask is either the system wide default or set by user space, > but the architecture can or even must reduce the mask to the effective set, > which means that checking the affinity mask itself does not really tell > about the actual target CPUs. > > Signed-off-by: Thomas Gleixner > Cc: Tariq Toukan > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > --- > drivers/net/ethernet/mellanox/mlx4/en_cq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/ethernet/mellanox/mlx4/en_cq.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_cq.c > @@ -117,7 +117,7 @@ int mlx4_en_activate_cq(struct mlx4_en_p > assigned_eq = true; > } > irq = mlx4_eq_get_irq(mdev->dev, cq->vector); > - cq->aff_mask = irq_get_affinity_mask(irq); > + cq->aff_mask = irq_get_effective_affinity_mask(irq); > } else { > /* For TX we use the same irq per > ring we assigned for the RX */ > Reviewed-by: Tariq Toukan Thanks. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx