From: Lars-Peter Clausen <lars@metafoo.de>
To: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ibmebus: Remove legacy suspend/resume support
Date: Mon, 21 Nov 2016 11:09:46 +0100 [thread overview]
Message-ID: <57d7b8c5-1deb-937c-5ad9-23912b38bd60@metafoo.de> (raw)
In-Reply-To: <87polpw45o.fsf@concordia.ellerman.id.au>
On 11/21/2016 10:52 AM, Michael Ellerman wrote:
> Lars-Peter Clausen <lars@metafoo.de> writes:
>
>> There are no ibmebus driver that make use of legacy suspend/resume. This
>> patch removes the support for it from ibmebus framework, new ibmebus driver
>> (as unlikely as they are) wanting to use suspend/resume should use
>> dev_pm_ops.
>>
>> Since there aren't any special bus specific things to do during
>> suspend/resume and since the PM core will automatically fallback directly
>> to using the device's PM ops if no bus PM ops are specified there is no
>> need to have any special ibmebus PM ops at all.
>
> Thanks, this looks like a really nice cleanup.
>
> I don't know the PM code at all, is there any down side to removing all
> of this?
No, dev_pm_op is a full replacement for the legacy suspend/resume callbacks
and dev_pm_ops are supported by the power management core out of the box
without having to have any bus specific code. Which is why we want to get
rid of legacy PM callbacks in general and this is one of the last few buses
that still implements it. But since there are no drivers that use it
removing it is straight forward in this case, for others it takes a bit more
work.
next prev parent reply other threads:[~2016-11-21 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 13:42 [PATCH] ibmebus: Remove legacy suspend/resume support Lars-Peter Clausen
2016-11-21 9:52 ` Michael Ellerman
2016-11-21 10:09 ` Lars-Peter Clausen [this message]
2016-11-21 10:16 ` Michael Ellerman
2016-11-25 0:04 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57d7b8c5-1deb-937c-5ad9-23912b38bd60@metafoo.de \
--to=lars@metafoo.de \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.