All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Biju Das <biju.das.jz@bp.renesas.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Sergey Shtylyov <s.shtylyov@omprussia.ru>,
	Adam Ford <aford173@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
	Yuusuke Ashizuka <ashiduka@fujitsu.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH net-next v2 13/14] ravb: Update EMAC configuration mode comment
Date: Sun, 10 Oct 2021 12:49:16 +0300	[thread overview]
Message-ID: <57dbab90-6f2c-40f5-2b73-43c1ee2c6e06@gmail.com> (raw)
In-Reply-To: <OS0PR01MB5922109B263B7FDBB02E33B986B49@OS0PR01MB5922.jpnprd01.prod.outlook.com>

On 10.10.2021 12:37, Biju Das wrote:
> Hi Sergey,
> 
>> -----Original Message-----
>> From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
>> Sent: 10 October 2021 10:28
>> To: Biju Das <biju.das.jz@bp.renesas.com>; David S. Miller
>> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>
>> Cc: Sergey Shtylyov <s.shtylyov@omp.ru>; Geert Uytterhoeven
>> <geert+renesas@glider.be>; Sergey Shtylyov <s.shtylyov@omprussia.ru>; Adam
>> Ford <aford173@gmail.com>; Andrew Lunn <andrew@lunn.ch>; Yuusuke Ashizuka
>> <ashiduka@fujitsu.com>; Yoshihiro Shimoda
>> <yoshihiro.shimoda.uh@renesas.com>; netdev@vger.kernel.org; linux-renesas-
>> soc@vger.kernel.org; Chris Paterson <Chris.Paterson2@renesas.com>; Biju
>> Das <biju.das@bp.renesas.com>; Prabhakar Mahadev Lad <prabhakar.mahadev-
>> lad.rj@bp.renesas.com>
>> Subject: Re: [PATCH net-next v2 13/14] ravb: Update EMAC configuration
>> mode comment
>>
>> On 10.10.2021 10:29, Biju Das wrote:
>>
>>> Update EMAC configuration mode comment from "PAUSE prohibition"
>>> to "EMAC Mode: PAUSE prohibition; Duplex; TX; RX; CRC Pass Through;
>>> Promiscuous".
>>>
>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>> Suggested-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>> ---
>>> v1->v2:
>>>    * No change
>>> V1:
>>>    * New patch.
>>> ---
>>>    drivers/net/ethernet/renesas/ravb_main.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
>>> b/drivers/net/ethernet/renesas/ravb_main.c
>>> index 9a770a05c017..b78aca235c37 100644
>>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>>> @@ -519,7 +519,7 @@ static void ravb_emac_init_gbeth(struct net_device
>> *ndev)
>>>    	/* Receive frame limit set register */
>>>    	ravb_write(ndev, GBETH_RX_BUFF_MAX + ETH_FCS_LEN, RFLR);
>>>
>>> -	/* PAUSE prohibition */
>>> +	/* EMAC Mode: PAUSE prohibition; Duplex; TX; RX; CRC Pass Through;
>>> +Promiscuous */
>>
>>      Promiscuous mode, really? Why?!
> 
> This is TOE related 

    The promiscuous mode is supported by _all_ Ethernet controllers, I think.

> and is recommendation from BSP/HW team.

    On what grounds?

> If you think it is wrong.
> I can take this out. Please let me know. Currently the board is booting and everything works without issues.

    Please do take it out. It'll needlessly overload the controller when 
there's much traffic on the local network.

> The meaning of promiscuous in H/W manual as follows.

    I know what the promiscuous mode is. :-)
    It's needed by things like 'tcpdump' and normally shoild be off.

> Promiscuous Mode
> 1: All the frames except for PAUSE frame are received. Self-addressed unicast,
> different address unicast, multicast, and broadcast frames are all transferred to
> TOE. PAUSE frame reception is controlled by PFR bit.
> 0: Self-addressed unicast, multicast, and broadcast frames are received, then
> transferred to TOE.
> 
> Regards,
> Biju

MBR, Sergey

  reply	other threads:[~2021-10-10  9:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10  7:29 [PATCH net-next v2 00/14] Add functional support for Gigabit Ethernet driver Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 01/14] ravb: Use ALIGN macro for max_rx_len Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 02/14] ravb: Add rx_max_buf_size to struct ravb_hw_info Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 03/14] ravb: Fillup ravb_alloc_rx_desc_gbeth() stub Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 04/14] ravb: Fillup ravb_rx_ring_free_gbeth() stub Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 05/14] ravb: Fillup ravb_rx_ring_format_gbeth() stub Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 06/14] ravb: Fillup ravb_rx_gbeth() stub Biju Das
2021-10-11 12:34   ` Sergey Shtylyov
2021-10-10  7:29 ` [PATCH net-next v2 07/14] ravb: Add carrier_counters to struct ravb_hw_info Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 08/14] ravb: Add support to retrieve stats for GbEthernet Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 09/14] ravb: Rename "tsrq" variable Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 10/14] ravb: Optimize ravb_emac_init_gbeth function Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 11/14] ravb: Rename "nc_queue" feature bit Biju Das
2021-10-11 15:38   ` Sergey Shtylyov
2021-10-10  7:29 ` [PATCH net-next v2 12/14] ravb: Document PFRI register bit Biju Das
2021-10-11 15:42   ` Sergey Shtylyov
2021-10-10  7:29 ` [PATCH net-next v2 13/14] ravb: Update EMAC configuration mode comment Biju Das
2021-10-10  9:27   ` Sergei Shtylyov
2021-10-10  9:37     ` Biju Das
2021-10-10  9:49       ` Sergei Shtylyov [this message]
2021-10-10 10:56         ` Biju Das
2021-10-10 11:29           ` Biju Das
2021-10-10 15:06           ` Andrew Lunn
2021-10-12 13:34             ` Biju Das
2021-10-10 17:24           ` Sergey Shtylyov
2021-10-10 17:45             ` Sergei Shtylyov
     [not found]           ` <20211011072032.6948dbe0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
2021-10-12 13:39             ` Biju Das
2021-10-10  7:29 ` [PATCH net-next v2 14/14] ravb: Fix typo AVB->DMAC Biju Das
2021-10-11 15:44   ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57dbab90-6f2c-40f5-2b73-43c1ee2c6e06@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=aford173@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=ashiduka@fujitsu.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=davem@davemloft.net \
    --cc=geert+renesas@glider.be \
    --cc=kuba@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=s.shtylyov@omp.ru \
    --cc=s.shtylyov@omprussia.ru \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.