From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54D9CC433EF for ; Mon, 4 Oct 2021 18:39:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13BFC6140D for ; Mon, 4 Oct 2021 18:39:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 13BFC6140D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXSrn-0004SB-AG for qemu-devel@archiver.kernel.org; Mon, 04 Oct 2021 14:39:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXSqr-000399-JN for qemu-devel@nongnu.org; Mon, 04 Oct 2021 14:38:13 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:35622 helo=mail.default.ilande.bv.iomart.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXSqq-0005WN-1s for qemu-devel@nongnu.org; Mon, 04 Oct 2021 14:38:13 -0400 Received: from [2a00:23c4:8b9d:4100:5d98:71b5:90ca:dad1] by mail.default.ilande.bv.iomart.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mXSqZ-0007n3-7n; Mon, 04 Oct 2021 19:37:59 +0100 To: BALATON Zoltan References: <20211002110007.30825-1-mark.cave-ayland@ilande.co.uk> <20211002110007.30825-2-mark.cave-ayland@ilande.co.uk> <2d85248a-bddd-c390-d0a2-356d57627786@eik.bme.hu> From: Mark Cave-Ayland Message-ID: <57e06bdc-7e31-8aae-79d0-9d71c9778455@ilande.co.uk> Date: Mon, 4 Oct 2021 19:38:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <2d85248a-bddd-c390-d0a2-356d57627786@eik.bme.hu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a00:23c4:8b9d:4100:5d98:71b5:90ca:dad1 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH 01/12] macfb: handle errors that occur during realize X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.bv.iomart.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.bv.iomart.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, laurent@vivier.eu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 02/10/2021 12:36, BALATON Zoltan wrote: > On Sat, 2 Oct 2021, Mark Cave-Ayland wrote: >> Make sure any errors that occur within the macfb realize chain are detected >> and handled correctly to prevent crashes and to ensure that error messages are >> reported back to the user. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/display/macfb.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/hw/display/macfb.c b/hw/display/macfb.c >> index 76808b69cc..2b747a8de8 100644 >> --- a/hw/display/macfb.c >> +++ b/hw/display/macfb.c > > There's one more in macfb_common_realize() after: > > memory_region_init_ram_nomigrate(&s->mem_vram, OBJECT(s), "macfb-vram", > MACFB_VRAM_SIZE, errp); > > otherwise > > Reviewed-by: BALATON Zoltan Ah yes, IIRC from the last patchset the outcome of the discussion with Markus was that these functions should use &error_abort. I'll make the same change here for v2. ATB, Mark.