From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757596AbeDXMl4 (ORCPT ); Tue, 24 Apr 2018 08:41:56 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:59716 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752673AbeDXMlw (ORCPT ); Tue, 24 Apr 2018 08:41:52 -0400 Subject: Re: [PATCH v6 3/9] PCI: endpoint: functions/pci-epf-test: Add second entry To: Gustavo Pimentel , , , , , , References: <9efd4af2f91e1be2b65d2df93444b35871673e8b.1524062073.git.gustavo.pimentel@synopsys.com> CC: , , From: Kishon Vijay Abraham I Message-ID: <57e5c94a-1e9a-6b4f-cbf8-5ac85ae1a919@ti.com> Date: Tue, 24 Apr 2018 18:11:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <9efd4af2f91e1be2b65d2df93444b35871673e8b.1524062073.git.gustavo.pimentel@synopsys.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 18 April 2018 08:16 PM, Gustavo Pimentel wrote: > Adds a seconds entry on the pci_epf_test_ids structure that disables the > linkup_notifier parameter on driver for the designware EP. > > This allows designware EPs that doesn't have linkup notification signal > to work with pcitest. > > Updates the binding documentation accordingly. > > Signed-off-by: Gustavo Pimentel > --- > Change v2->v3: > - Added second entry in pci_epf_test_ids structure. > - Remove test_reg_bar field assignment on second entry. > Changes v3->v4: > - Nothing changed, just to follow the patch set version. > Changes v4->v5: > - Changed pci_epf_test_cfg2 to pci_epf_test_designware. > Changes v5->v6: > - Changed name field from pci_epf_test_designware to pci_epf_test_dw. > > Documentation/PCI/endpoint/function/binding/pci-test.txt | 2 ++ > drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/Documentation/PCI/endpoint/function/binding/pci-test.txt b/Documentation/PCI/endpoint/function/binding/pci-test.txt > index 3b68b95..dc39f47 100644 > --- a/Documentation/PCI/endpoint/function/binding/pci-test.txt > +++ b/Documentation/PCI/endpoint/function/binding/pci-test.txt > @@ -1,6 +1,8 @@ > PCI TEST ENDPOINT FUNCTION > > name: Should be "pci_epf_test" to bind to the pci_epf_test driver. > +name: Should be "pci_epf_test_dw" to bind to the pci_epf_test driver > + with a custom configuration for the designware EP. > > Configurable Fields: > vendorid : should be 0x104c > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 7cef851..b7dff87 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) > return 0; > } > > +static const struct pci_epf_test_data data_cfg2 = { Would prefer a descriptive name, otherwise Acked-by: Kishon Vijay Abraham I > + .linkup_notifier = false > +}; > + > static const struct pci_epf_device_id pci_epf_test_ids[] = { > { > .name = "pci_epf_test", > }, > + { > + .name = "pci_epf_test_dw", > + .driver_data = (kernel_ulong_t)&data_cfg2, > + }, > {}, > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v6 3/9] PCI: endpoint: functions/pci-epf-test: Add second entry Date: Tue, 24 Apr 2018 18:11:41 +0530 Message-ID: <57e5c94a-1e9a-6b4f-cbf8-5ac85ae1a919@ti.com> References: <9efd4af2f91e1be2b65d2df93444b35871673e8b.1524062073.git.gustavo.pimentel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9efd4af2f91e1be2b65d2df93444b35871673e8b.1524062073.git.gustavo.pimentel@synopsys.com> Sender: linux-kernel-owner@vger.kernel.org To: Gustavo Pimentel , bhelgaas@google.com, lorenzo.pieralisi@arm.com, Joao.Pinto@synopsys.com, jingoohan1@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wednesday 18 April 2018 08:16 PM, Gustavo Pimentel wrote: > Adds a seconds entry on the pci_epf_test_ids structure that disables the > linkup_notifier parameter on driver for the designware EP. > > This allows designware EPs that doesn't have linkup notification signal > to work with pcitest. > > Updates the binding documentation accordingly. > > Signed-off-by: Gustavo Pimentel > --- > Change v2->v3: > - Added second entry in pci_epf_test_ids structure. > - Remove test_reg_bar field assignment on second entry. > Changes v3->v4: > - Nothing changed, just to follow the patch set version. > Changes v4->v5: > - Changed pci_epf_test_cfg2 to pci_epf_test_designware. > Changes v5->v6: > - Changed name field from pci_epf_test_designware to pci_epf_test_dw. > > Documentation/PCI/endpoint/function/binding/pci-test.txt | 2 ++ > drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/Documentation/PCI/endpoint/function/binding/pci-test.txt b/Documentation/PCI/endpoint/function/binding/pci-test.txt > index 3b68b95..dc39f47 100644 > --- a/Documentation/PCI/endpoint/function/binding/pci-test.txt > +++ b/Documentation/PCI/endpoint/function/binding/pci-test.txt > @@ -1,6 +1,8 @@ > PCI TEST ENDPOINT FUNCTION > > name: Should be "pci_epf_test" to bind to the pci_epf_test driver. > +name: Should be "pci_epf_test_dw" to bind to the pci_epf_test driver > + with a custom configuration for the designware EP. > > Configurable Fields: > vendorid : should be 0x104c > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 7cef851..b7dff87 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) > return 0; > } > > +static const struct pci_epf_test_data data_cfg2 = { Would prefer a descriptive name, otherwise Acked-by: Kishon Vijay Abraham I > + .linkup_notifier = false > +}; > + > static const struct pci_epf_device_id pci_epf_test_ids[] = { > { > .name = "pci_epf_test", > }, > + { > + .name = "pci_epf_test_dw", > + .driver_data = (kernel_ulong_t)&data_cfg2, > + }, > {}, > }; > >