From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65562C4332F for ; Thu, 15 Dec 2022 13:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229848AbiLONRh (ORCPT ); Thu, 15 Dec 2022 08:17:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiLONRf (ORCPT ); Thu, 15 Dec 2022 08:17:35 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B710F2DA98 for ; Thu, 15 Dec 2022 05:17:32 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id p8so15579670lfu.11 for ; Thu, 15 Dec 2022 05:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Sg/7PKZ2PpLj44QUzjyo60iofeYQC0nT1+8EbxEYeYk=; b=paqjLWLQjV3QM7o0g45iNNwnnTCrY5fNU98IFbOl88i8N05oz/7pwz8U4konc2LKBI 4im+yTolmz5RvPwIXBBUAW69FKxIc9OOOjJtXmEHrf/WorTXyD6pQItLL9R1llswJIIJ 3TN68XWRZQ1cYIxLWbygHK9yuR1hPGe3XyTaV59MCbZJXTPJ2HVCbLMnOee/0KYhenAV sREeEt+/+7zk3hgKUtaTsTOMs291dD1X1zcivWER55m+BRaEQ+HSuEeE1A1s0kI4i/Hy AGldpgU9DwGbNITetJbtATshSvEbWobZWYd4M+5KsBU2ThZ3zLb5YRcyXcyUrN0ywf5d nzPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sg/7PKZ2PpLj44QUzjyo60iofeYQC0nT1+8EbxEYeYk=; b=3cc6Y4NXO/BmWRkfQDTPuNvnkldUo+zS75alo53YEaqWPzCXwRLYUQpgUWaqMuidlq qoOEPy+b/B+ft1az/3ZOTmTduoxDDwMXhPa4sdeYDCfsYxmfLU37BiZQwuYhSUUhzR5j 1ftiTOzpJORXBHZSyn0z6WyT5iw3fUgJd+2InhMfMGrkjPk+Arn5S1R6gT0lHwjCa0TW TIFncYFgoyADkaVFB00QDn+JNL503vVLg2XTqm4DfAH3B7oqquseDfe5SPSkKdMQFXDz L9r12tEXkqRgG4lBavs3Ri1FbiGd+Yg8hY7ACXDR/OP5e7sItSx0xpA7KE/QxHHKYBHW v65A== X-Gm-Message-State: ANoB5pki+ET0GK7I5b8Uq4qVdzpBBPvq6J/wwj4RIH+Shx0l7JXLspkc I/pC1oSYbGQkdxRgCFWekwzfVA== X-Google-Smtp-Source: AA0mqf6adzOmCFsfsG4Pco2bqy42zVq9ZhzDRHVcRCAsSdpPIgPtuFiVQeUoqpWpdoJCmTZoxIVM0w== X-Received: by 2002:a05:6512:1690:b0:4b6:eca8:f6ca with SMTP id bu16-20020a056512169000b004b6eca8f6camr6144996lfb.67.1671110251085; Thu, 15 Dec 2022 05:17:31 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id o9-20020a05651205c900b0049478cc4eb9sm1156938lfo.230.2022.12.15.05.17.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 05:17:29 -0800 (PST) Message-ID: <57e7f32b-86d6-81b4-1501-d732deee6c48@linaro.org> Date: Thu, 15 Dec 2022 14:17:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/6] arm64: dts: qcom: msm8956-loire: Add usb vbus and id extcons to ci-hdrc Content-Language: en-US To: Marijn Suijten , phone-devel@vger.kernel.org, Bjorn Andersson Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Andy Gross , Rob Herring , Krzysztof Kozlowski , AngeloGioacchino Del Regno , Luca Weiss , Adam Skladowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221214232049.703484-1-marijn.suijten@somainline.org> <20221214232049.703484-3-marijn.suijten@somainline.org> From: Konrad Dybcio In-Reply-To: <20221214232049.703484-3-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 15.12.2022 00:20, Marijn Suijten wrote: > ci-hdrc does not have the ability to detect voltage presence (5V vbus) > on the USB connector nor the role (via an ID sensing pin), and relies on > the PMIC-side charger to provide such information through an extcon > driver. > > Signed-off-by: Marijn Suijten > Reviewed-by: AngeloGioacchino Del Regno > --- > arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi > index 67baced639c9..700583a56a0e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire.dtsi > @@ -77,6 +77,8 @@ &gcc { > > &otg { > status = "okay"; > + > + extcon = <&pmi8950_usb_vbus>, <&pmi8950_usb_id>; Please add it above to keep status as the last property. Konrad > }; > > &pm8004_spmi_regulators {