From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prashant Bhole Subject: Re: [PATCH bpf-next 0/6] Error handling when map lookup isn't supported Date: Tue, 9 Oct 2018 09:47:29 +0900 Message-ID: <57e8a677-bfe7-4a39-f58c-daa1a5dba72b@lab.ntt.co.jp> References: <20181005033601.6776-1-bhole_prashant_q7@lab.ntt.co.jp> <20181005183512.lmjbgf2qoene3r4w@ast-mbp.dhcp.thefacebook.com> <49b6c6b1-d66b-db0d-d866-9720b269c1a2@lab.ntt.co.jp> <5029a2fe-10f8-116a-428d-e02790ec8366@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Jakub Kicinski , "David S . Miller" , Quentin Monnet , netdev@vger.kernel.org To: Daniel Borkmann , Alexei Starovoitov Return-path: Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]:55493 "EHLO tama50.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726427AbeJIICy (ORCPT ); Tue, 9 Oct 2018 04:02:54 -0400 In-Reply-To: <5029a2fe-10f8-116a-428d-e02790ec8366@iogearbox.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/9/2018 9:43 AM, Daniel Borkmann wrote: > On 10/09/2018 02:02 AM, Prashant Bhole wrote: >> On 10/6/2018 3:35 AM, Alexei Starovoitov wrote: >>> On Fri, Oct 05, 2018 at 12:35:55PM +0900, Prashant Bhole wrote: >>>> Currently when map a lookup fails, user space API can not make any >>>> distinction whether given key was not found or lookup is not supported >>>> by particular map. >>>> >>>> In this series we modify return value of maps which do not support >>>> lookup. Lookup on such map implementation will return -EOPNOTSUPP. >>>> bpf() syscall with BPF_MAP_LOOKUP_ELEM command will set EOPNOTSUPP >>>> errno. We also handle this error in bpftool to print appropriate >>>> message. >>>> >>>> Patch 1: adds handling of BPF_MAP_LOOKUP ELEM command of bpf syscall >>>> such that errno will set to EOPNOTSUPP when map doesn't support lookup >>>> >>>> Patch 2: Modifies the return value of map_lookup_elem() to EOPNOTSUPP >>>> for maps which do not support lookup >>>> >>>> Patch 3: Splits do_dump() in bpftool/map.c. Element printing code is >>>> moved out into new function dump_map_elem(). This was done in order to >>>> reduce deep indentation and accomodate further changes. >>>> >>>> Patch 4: Changes in bpftool to print strerror() message when lookup >>>> error is occured. This will result in appropriate message like >>>> "Operation not supported" when map doesn't support lookup. >>>> >>>> Patch 5: test_verifier: change fixup map naming convention as >>>> suggested by Alexei >>>> >>>> Patch 6: Added verifier tests to check whether verifier rejects call >>>> to bpf_map_lookup_elem from bpf program. For all map types those >>>> do not support map lookup. >>> >>> for the set: >>> Acked-by: Alexei Starovoitov >> >> Thanks. Is there any reason this series did not get posted on netdev-list and can not be seen in the patchwork? > > Hmm, could you repost to netdev? Perhaps a netdev or patchwork issue that > it did not land there. I just double-checked and it's indeed not present. > Shall I repost with the same version and Alexei's Acked-by for the series? -Prashant