From: Andrew Donnellan <ajd@linux.ibm.com>
To: Nayna Jain <nayna@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: gjoyce@linux.vnet.ibm.com, npiggin@gmail.com,
brking@linux.ibm.com, George Wilson <gcwilson@linux.ibm.com>
Subject: Re: [PATCH 1/6] powerpc/pseries: fix the object owners enum value in plpks driver
Date: Fri, 25 Nov 2022 14:54:35 +1100 [thread overview]
Message-ID: <57e96767cc52a3ce0c4d9fc25c90ada2f82eabfc.camel@linux.ibm.com> (raw)
In-Reply-To: <20221106205839.600442-2-nayna@linux.ibm.com>
On Sun, 2022-11-06 at 15:58 -0500, Nayna Jain wrote:
> OS_VAR_LINUX enum in PLPKS driver should be 0x02 instead of 0x01.
This should be PLPKS_VAR_LINUX. And it's a macro, not an enum.
The new value does indeed match the (currently IBM internal)
specification - 0x01 is AIX.
>
> Fixes: 2454a7af0f2a ("powerpc/pseries: define driver for Platform
> KeyStore")
> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
Should be noted that at present, this macro isn't used anywhere - it is
used in a future series.
> ---
> arch/powerpc/platforms/pseries/plpks.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/plpks.h
> b/arch/powerpc/platforms/pseries/plpks.h
> index c6a291367bb1..275ccd86bfb5 100644
> --- a/arch/powerpc/platforms/pseries/plpks.h
> +++ b/arch/powerpc/platforms/pseries/plpks.h
> @@ -17,7 +17,7 @@
> #define WORLDREADABLE 0x08000000
> #define SIGNEDUPDATE 0x01000000
>
> -#define PLPKS_VAR_LINUX 0x01
> +#define PLPKS_VAR_LINUX 0x02
> #define PLPKS_VAR_COMMON 0x04
>
> struct plpks_var {
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2022-11-25 3:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 20:58 [PATCH 0/6] powerpc/pseries - bugfixes/cleanups for PLPKS driver Nayna Jain
2022-11-06 20:58 ` [PATCH 1/6] powerpc/pseries: fix the object owners enum value in plpks driver Nayna Jain
2022-11-25 3:54 ` Andrew Donnellan [this message]
2022-11-06 20:58 ` [PATCH 2/6] powerpc/pseries: Fix the H_CALL error code in PLPKS driver Nayna Jain
2022-11-25 5:17 ` Andrew Donnellan
2022-11-06 20:58 ` [PATCH 3/6] powerpc/pseries: Return -EIO instead of -EINTR for H_ABORTED error Nayna Jain
2022-11-30 2:55 ` Andrew Donnellan
2022-11-06 20:58 ` [PATCH 4/6] powerpc/pseries: cleanup error logs in plpks driver Nayna Jain
2022-11-06 20:58 ` [PATCH 5/6] powerpc/pseries: replace kmalloc with kzalloc in PLPKS driver Nayna Jain
2022-11-25 3:31 ` Andrew Donnellan
2022-11-06 20:58 ` [PATCH 6/6] powerpc/pseries: fix plpks_read_var() code for different consumers Nayna Jain
2022-11-30 9:24 ` [PATCH 0/6] powerpc/pseries - bugfixes/cleanups for PLPKS driver Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57e96767cc52a3ce0c4d9fc25c90ada2f82eabfc.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=brking@linux.ibm.com \
--cc=gcwilson@linux.ibm.com \
--cc=gjoyce@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nayna@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.