From: Ricardo Martincoski <ricardo.martincoski@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] netatop: enable required kernel feature
Date: Sat, 08 Oct 2016 17:45:44 -0300 [thread overview]
Message-ID: <57f95af83f96b_78bc3fbbf8005ef8245d1@ultri3.mail> (raw)
In-Reply-To: 20161007232042.0e49c4b2@free-electrons.com
Thomas,
On Fri, Oct 07, 2016 at 06:20 PM, Thomas Petazzoni wrote:
> On Fri, 7 Oct 2016 17:30:30 -0300, Ricardo Martincoski wrote:
>> When netatop is enabled, the required kernel feature is enabled.
>>
>> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
>
> Is CONFIG_NETFILTER=y required to *build* the netatop module, or only
> needed at runtime ?
It is required to build the module.
>
> Two cases:
>
> - If it's needed to build the netatop module, then this change should
> be part of the commit adding the netatop package.
Ok. I will send both in one commit when I respin.
>
> - If it's needed only at runtime, we have a more relaxed policy, and we
> generally don't enforce the kernel options in such a case.
>
Thank you for your review.
Regards,
Ricardo
next prev parent reply other threads:[~2016-10-08 20:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 20:30 [Buildroot] [PATCH 1/4] atop: new package Ricardo Martincoski
2016-10-07 20:30 ` [Buildroot] [PATCH 2/4] netatop: " Ricardo Martincoski
2016-10-07 21:19 ` Thomas Petazzoni
2016-10-08 21:58 ` Ricardo Martincoski
2016-10-07 20:30 ` [Buildroot] [PATCH 3/4] netatop: enable required kernel feature Ricardo Martincoski
2016-10-07 21:20 ` Thomas Petazzoni
2016-10-08 20:45 ` Ricardo Martincoski [this message]
2016-10-07 20:30 ` [Buildroot] [PATCH 4/4] DEVELOPERS: list {, net}atop package under my name Ricardo Martincoski
2016-10-07 21:21 ` Thomas Petazzoni
2016-10-07 21:18 ` [Buildroot] [PATCH 1/4] atop: new package Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57f95af83f96b_78bc3fbbf8005ef8245d1@ultri3.mail \
--to=ricardo.martincoski@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.