All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Muller <hlmuller@yahoo.com>
To: netfilter@lists.netfilter.org
Subject: iptables-1.3.7 Requires ip_tables to be built as module
Date: Thu, 15 Feb 2007 11:49:07 -0800 (PST)	[thread overview]
Message-ID: <580354.86542.qm@web53604.mail.yahoo.com> (raw)

Yasuyuki,

During the review, I noticed the inclusion of the load_iptables_ko function within the
compatible_revision function.  Removal of the inclusion results in no error messages,
and testing of firewall doesn't seem to show adverse affects.

This is the patch I created for testing:

diff -Naur iptables-1.3.7.orig/ip6tables.c iptables-1.3.7/ip6tables.c
--- iptables-1.3.7.orig/ip6tables.c    2007-02-15 14:04:54.000000000 -0500
+++ iptables-1.3.7/ip6tables.c    2007-02-15 14:06:32.000000000 -0500
@@ -1120,8 +1120,6 @@
     strcpy(rev.name, name);
     rev.revision = revision;
 
-    load_ip6tables_ko(modprobe);
-
     max_rev = getsockopt(sockfd, IPPROTO_IPV6, opt, &rev, &s);
     if (max_rev < 0) {
         /* Definitely don't support this? */
diff -Naur iptables-1.3.7.orig/iptables.c iptables-1.3.7/iptables.c
--- iptables-1.3.7.orig/iptables.c    2007-02-15 14:04:54.000000000 -0500
+++ iptables-1.3.7/iptables.c    2007-02-15 14:06:09.000000000 -0500
@@ -1148,8 +1148,6 @@
         exit(1);
     }
 
-    load_iptables_ko(modprobe);
-
     strcpy(rev.name, name);
     rev.revision = revision;

Best regards,

Harvey




             reply	other threads:[~2007-02-15 19:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15 19:49 Harvey Muller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-02-15 18:41 iptables-1.3.7 Requires ip_tables to be built as module Harvey Muller
2007-02-13 13:46 Harvey Muller
2007-02-12 19:49 Harvey Muller
2007-02-13  7:21 ` Graham Murray
2007-02-13  7:47   ` Yasuyuki KOZAKAI
2007-02-12 15:23 Harvey Muller
2007-02-12 16:17 ` Graham Murray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=580354.86542.qm@web53604.mail.yahoo.com \
    --to=hlmuller@yahoo.com \
    --cc=netfilter@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.