From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw9lr-0007Ub-D7 for qemu-devel@nongnu.org; Mon, 17 Oct 2016 11:24:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bw9lq-0002AJ-G8 for qemu-devel@nongnu.org; Mon, 17 Oct 2016 11:24:11 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:4167) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1bw9lq-0002A2-9u for qemu-devel@nongnu.org; Mon, 17 Oct 2016 11:24:10 -0400 References: <1476589070-5792-1-git-send-email-rth@twiddle.net> <1476589070-5792-3-git-send-email-rth@twiddle.net> From: Claudio Fontana Message-ID: <5804ECF9.3060103@huawei.com> Date: Mon, 17 Oct 2016 17:23:37 +0200 MIME-Version: 1.0 In-Reply-To: <1476589070-5792-3-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/15] tcg: Minor adjustments to deposit expanders List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org On 16.10.2016 05:37, Richard Henderson wrote: > Assert that len is not 0. > > Since we have asserted that ofs + len <= N, a later > check for len == N implies that ofs == 0. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c > index cc4a331..39bab98 100644 > --- a/tcg/tcg-op.c > +++ b/tcg/tcg-op.c > @@ -543,10 +543,11 @@ void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2, > TCGv_i32 t1; > > tcg_debug_assert(ofs < 32); > + tcg_debug_assert(len > 0); > tcg_debug_assert(len <= 32); > tcg_debug_assert(ofs + len <= 32); > > - if (ofs == 0 && len == 32) { > + if (len == 32) { > tcg_gen_mov_i32(ret, arg2); > return; > } > @@ -1693,10 +1694,11 @@ void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2, > TCGv_i64 t1; > > tcg_debug_assert(ofs < 64); > + tcg_debug_assert(len > 0); > tcg_debug_assert(len <= 64); > tcg_debug_assert(ofs + len <= 64); > > - if (ofs == 0 && len == 64) { > + if (len == 64) { > tcg_gen_mov_i64(ret, arg2); > return; > } > Reviewed-by: Claudio Fontana