* [merged] mm-slab-fix-kmemcg-cache-creation-delayed-issue.patch removed from -mm tree
@ 2016-10-28 18:30 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2016-10-28 18:30 UTC (permalink / raw)
To: iamjoonsoo.kim, cl, dsmythies, penberg, rientjes, stable, mm-commits
The patch titled
Subject: mm/slab: fix kmemcg cache creation delayed issue
has been removed from the -mm tree. Its filename was
mm-slab-fix-kmemcg-cache-creation-delayed-issue.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: mm/slab: fix kmemcg cache creation delayed issue
There is a bug report that SLAB makes extreme load average due to over
2000 kworker thread.
https://bugzilla.kernel.org/show_bug.cgi?id=172981
This issue is caused by kmemcg feature that try to create new set of
kmem_caches for each memcg. Recently, kmem_cache creation is slowed by
synchronize_sched() and futher kmem_cache creation is also delayed since
kmem_cache creation is synchronized by a global slab_mutex lock. So, the
number of kworker that try to create kmem_cache increases quitely.
synchronize_sched() is for lockless access to node's shared array but it's
not needed when a new kmem_cache is created. So, this patch rules out
that case.
Fixes: 801faf0db894 ("mm/slab: lockless decision to grow cache")
Link: http://lkml.kernel.org/r/1475734855-4837-1-git-send-email-iamjoonsoo.kim@lge.com
Reported-by: Doug Smythies <dsmythies@telus.net>
Tested-by: Doug Smythies <dsmythies@telus.net>
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/slab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/slab.c~mm-slab-fix-kmemcg-cache-creation-delayed-issue mm/slab.c
--- a/mm/slab.c~mm-slab-fix-kmemcg-cache-creation-delayed-issue
+++ a/mm/slab.c
@@ -966,7 +966,7 @@ static int setup_kmem_cache_node(struct
* guaranteed to be valid until irq is re-enabled, because it will be
* freed after synchronize_sched().
*/
- if (force_change)
+ if (old_shared && force_change)
synchronize_sched();
fail:
_
Patches currently in -mm which might be from iamjoonsoo.kim@lge.com are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-10-28 18:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-28 18:30 [merged] mm-slab-fix-kmemcg-cache-creation-delayed-issue.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.